From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alln-iport-2.cisco.com (alln-iport-2.cisco.com [173.37.142.89]) by dpdk.org (Postfix) with ESMTP id 1C34F7EB0 for ; Tue, 16 Dec 2014 11:34:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=2337; q=dns/txt; s=iport; t=1418726049; x=1419935649; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=ktgn9lAjp4t/Psxi0jZAI7PpjNA/pw+LIGQ1iRX6y8w=; b=ZwBqmmgEvLYOQBfcQTwoqTUCufJxFe9/eqY3rYPgsM3LBXODa4fB4aUF XyrJCmDvijgTJZkNk7gKdIOv5cTMt2jbwf2LF2DguaSll7w/IZdn3PF3q Lsofxx2riBv/pIpyDjZdQwImXTBu5NiNoG0GoOFpzgmKH3dw/zy5nWpUL E=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AoEFAPIJkFStJA2G/2dsb2JhbABagwaBKgTLZAKBHBYBAQEBAX2EDAEBAQMBOj8QAgEIGB4QMiUCBAENBYgkCNRWAQEBAQEBAQEBAQEBAQEBAQEBAQEBF49yB4QpAQSOAohvgQuCXoVsh2Qig2xugUV+AQEB X-IronPort-AV: E=Sophos;i="5.07,586,1413244800"; d="scan'208";a="106086053" Received: from alln-core-12.cisco.com ([173.36.13.134]) by alln-iport-2.cisco.com with ESMTP; 16 Dec 2014 10:34:08 +0000 Received: from xhc-aln-x13.cisco.com (xhc-aln-x13.cisco.com [173.36.12.87]) by alln-core-12.cisco.com (8.14.5/8.14.5) with ESMTP id sBGAY7Eo011348 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Tue, 16 Dec 2014 10:34:07 GMT Received: from xmb-aln-x07.cisco.com ([169.254.2.173]) by xhc-aln-x13.cisco.com ([173.36.12.87]) with mapi id 14.03.0195.001; Tue, 16 Dec 2014 04:34:07 -0600 From: "Sujith Sankar (ssujith)" To: "Burakov, Anatoly" , Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH] enic: corrected the usage of VFIO_PRESENT Thread-Index: AQHQFeRr1xRBtyDx5UWdyYsoypZs7pyRtUyAgACszQCAAAsoAIAAX20A Date: Tue, 16 Dec 2014 10:34:06 +0000 Message-ID: References: <1418372303-31565-1-git-send-email-ssujith@cisco.com> <5911790.4rCTPaIceN@xps13> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.3.9.131030 x-originating-ip: [10.65.51.177] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] enic: corrected the usage of VFIO_PRESENT X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Dec 2014 10:34:09 -0000 On 16/12/14 3:52 pm, "Burakov, Anatoly" wrote: >> On 16/12/14 4:54 am, "Thomas Monjalon" >> wrote: >>=20 >> >2014-12-12 13:48, Sujith Sankar: >> >> This patch corrects the usage of the flag VFIO_PRESENT in enic >>driver. >> > >> >Please, could you explain why the flag VFIO_PRESENT was not well used? >>=20 >> Without including eal_vfio.h, VFIO_PRESENT is not available in enic. >> Hence VFIO specific code in enic was not getting compiled and some >>errors >> were generated during run-time. >>=20 >> > >> >> This has uncovered a few warnings, and this patch corrects those too. >> >[...] >> >> --- a/lib/librte_pmd_enic/enic_main.c >> >> +++ b/lib/librte_pmd_enic/enic_main.c >> >> @@ -39,6 +39,7 @@ >> >> #include >> >> #include >> >> #include >> >> +#include >> >> >> >> #include >> >> #include >> >> @@ -46,6 +47,7 @@ >> >> #include >> >> #include >> >> #include >> >> +#include >> > >> >This header was not designed to be included by PMDs. >> >It will break compilation on BSD. >>=20 >> Is there an alternative to make VFIO_PRESENT available in enic? Please >> advise. >>=20 >> Thanks, >> -Sujith >>=20 >> > >> >> #include "enic_compat.h" >> >> #include "enic.h" >> >> @@ -561,6 +563,7 @@ enic_free_consistent(__rte_unused struct >> >>rte_pci_device *hwdev, >> >> /* Nothing to be done */ >> >> } >> >> >> >> +#ifndef VFIO_PRESENT >> >> static void >> >> enic_intr_handler(__rte_unused struct rte_intr_handle *handle, >> >> void *arg) >> >> @@ -572,6 +575,7 @@ enic_intr_handler(__rte_unused struct >> >>rte_intr_handle *handle, >> >> >> >> enic_log_q_error(enic); >> >> } >> >> +#endif >> > >> >-- >> >Thomas > >Hi Sujith > >Thomas is correct, VFIO code is designed to be EAL-only (mainly because >it's Linuxapp-specific, and PMD's are intended to be cross-platform at >least when it comes to compilation). Whatever it is that you're working >around is better fixed in the EAL itself rather than in the PMD. I agree with you and Thomas. Let me find the root cause for the false trigger.=20 Thanks, -Sujith > >Thanks, >Anatoly