DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Sujith Sankar (ssujith)" <ssujith@cisco.com>
To: "Wu, Jingjing" <jingjing.wu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Prasad Rao \(prrao\)" <prrao@cisco.com>
Subject: Re: [dpdk-dev] [PATCH v6 5/6] enicpmd: DPDK-ENIC PMD interface
Date: Tue, 30 Dec 2014 04:45:33 +0000	[thread overview]
Message-ID: <D0C82A9E.2BA5D%ssujith@cisco.com> (raw)
In-Reply-To: <9BB6961774997848B5B42BEC655768F8B6647D@SHSMSX104.ccr.corp.intel.com>



On 29/12/14 1:45 pm, "Wu, Jingjing" <jingjing.wu@intel.com> wrote:

>Hi, ssujith
>
>> +	.tx_queue_release     = enicpmd_dev_tx_queue_release,
>> +	.dev_led_on           = NULL,
>> +	.dev_led_off          = NULL,
>> +	.flow_ctrl_get        = NULL,
>> +	.flow_ctrl_set        = NULL,
>> +	.priority_flow_ctrl_set = NULL,
>> +	.mac_addr_add         = enicpmd_add_mac_addr,
>> +	.mac_addr_remove      = enicpmd_remove_mac_addr,
>> +	.fdir_add_signature_filter    = NULL,
>> +	.fdir_update_signature_filter = NULL,
>> +	.fdir_remove_signature_filter = NULL,
>> +	.fdir_infos_get               = enicpmd_fdir_info_get,
>> +	.fdir_add_perfect_filter      = enicpmd_fdir_add_perfect_filter,
>> +	.fdir_update_perfect_filter   = enicpmd_fdir_add_perfect_filter,
>> +	.fdir_remove_perfect_filter   = enicpmd_fdir_remove_perfect_filter,
>> +	.fdir_set_masks               = NULL,
>> +};
>> +
>
>I found that in perfect fdir is also supported in enic driver.
>
>During the R1.8 development, we defined a new dev_ops call filter_ctrl,
>which can be used to control kinds of filters, flow director is included
>too. Which is mentioned in
>http://www.dpdk.org/ml/archives/dev/2014-September/005179.html .
>In R1.8, filter_ctrl is only used by i40e driver. And we also planned use
>it in the existing ixgbe/e1000 driver in the next days. The old APIs such
>as fdir_add_perfect_filter, fdir_remove_perfect_filter can be replaced
>then.


Hi Jingjing,
Thanks for the info and the link.  I shall take a look at it.
It looks like bringing in one interface for all filter related operations.
 I believe ENIC should also move to it.

Thanks,
-Sujith

>
>So, do you have any plan to migrate the fdir in enic to the filter_ctrl
>API?
>
>Jingjing
>
>Thanks!
>
>> +struct enic *enicpmd_list_head = NULL;
>> +/* Initialize the driver
>> + * It returns 0 on success.
>> + */
>> +static int eth_enicpmd_dev_init(
>> +	__attribute__((unused))struct eth_driver *eth_drv,
>> +	struct rte_eth_dev *eth_dev)
>> +{
>> +	struct rte_pci_device *pdev;
>> +	struct rte_pci_addr *addr;
>> +	struct enic *enic = pmd_priv(eth_dev);
>> +
>> +	ENICPMD_FUNC_TRACE();
>> +
>> +	enic->rte_dev = eth_dev;
>> +	eth_dev->dev_ops = &enicpmd_eth_dev_ops;
>> +	eth_dev->rx_pkt_burst = &enicpmd_recv_pkts;
>> +	eth_dev->tx_pkt_burst = &enicpmd_xmit_pkts;
>> +
>> +	pdev = eth_dev->pci_dev;
>> +	enic->pdev = pdev;
>> +	addr = &pdev->addr;
>> +
>> +	snprintf(enic->bdf_name, ENICPMD_BDF_LENGTH,
>> "%04x:%02x:%02x.%x",
>> +		addr->domain, addr->bus, addr->devid, addr->function);
>> +
>> +	return enic_probe(enic);
>> +}
>> +
>> +static struct eth_driver rte_enic_pmd = {
>> +	{
>> +		.name = "rte_enic_pmd",
>> +		.id_table = pci_id_enic_map,
>> +		.drv_flags = RTE_PCI_DRV_NEED_MAPPING,
>> +	},
>> +	.eth_dev_init = eth_enicpmd_dev_init,
>> +	.dev_private_size = sizeof(struct enic), };
>> +
>> +/* Driver initialization routine.
>> + * Invoked once at EAL init time.
>> + * Register as the [Poll Mode] Driver of Cisco ENIC device.
>> + */
>> +int rte_enic_pmd_init(const char *name __rte_unused,
>> +	const char *params __rte_unused)
>> +{
>> +	ENICPMD_FUNC_TRACE();
>> +
>> +	rte_eth_driver_register(&rte_enic_pmd);
>> +	return 0;
>> +}
>> +
>> +static struct rte_driver rte_enic_driver = {
>> +	.type = PMD_PDEV,
>> +	.init = rte_enic_pmd_init,
>> +};
>> +
>> +PMD_REGISTER_DRIVER(rte_enic_driver);
>> +
>> --
>> 1.9.1
>

  reply	other threads:[~2014-12-30  4:46 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-25 17:26 [dpdk-dev] [PATCH v6 0/6] enicpmd: Cisco Systems Inc. VIC Ethernet PMD Sujith Sankar
2014-11-25 17:26 ` [dpdk-dev] [PATCH v6 1/6] enicpmd: License text Sujith Sankar
2014-11-25 17:26 ` [dpdk-dev] [PATCH v6 2/6] enicpmd: Makefile Sujith Sankar
2014-11-25 17:26 ` [dpdk-dev] [PATCH v6 3/6] enicpmd: VNIC common code partially shared with ENIC kernel mode driver Sujith Sankar
2014-11-25 17:26 ` [dpdk-dev] [PATCH v6 4/6] enicpmd: pmd specific code Sujith Sankar
2014-11-27 14:49   ` Wodkowski, PawelX
2014-11-25 17:26 ` [dpdk-dev] [PATCH v6 5/6] enicpmd: DPDK-ENIC PMD interface Sujith Sankar
2014-12-29  8:15   ` Wu, Jingjing
2014-12-30  4:45     ` Sujith Sankar (ssujith) [this message]
2015-01-06  9:41       ` Thomas Monjalon
2015-01-30  8:53       ` Wu, Jingjing
2014-11-25 17:26 ` [dpdk-dev] [PATCH v6 6/6] enicpmd: DPDK changes for accommodating ENIC PMD Sujith Sankar
2014-11-25 19:51 ` [dpdk-dev] [PATCH v6 0/6] enicpmd: Cisco Systems Inc. VIC Ethernet PMD David Marchand
2014-11-26 22:11   ` Thomas Monjalon
2014-11-27  4:27     ` Sujith Sankar (ssujith)
2014-11-27 15:31       ` Thomas Monjalon
2015-01-20 11:25         ` David Marchand
2015-01-21  5:03           ` Sujith Sankar (ssujith)
2015-02-26 11:49             ` Thomas Monjalon
2015-02-26 13:08               ` Wiles, Keith
2015-02-27  8:09                 ` Sujith Sankar (ssujith)
2015-02-27  8:47                   ` [dpdk-dev] Why only rx queue "0" can receive network packet by i40e NIC lhffjzh
2015-02-27  9:03                     ` lhffjzh
2015-02-27 10:55                     ` Thomas Monjalon
2015-02-28  1:47                       ` lhffjzh
2015-02-28  3:17                         ` Zhang, Helin
2015-02-28  4:33                           ` lhffjzh
2015-02-28 14:33                             ` Zhang, Helin
2015-07-23  0:47                               ` Jeff Venable, Sr.
2015-07-23  0:56                                 ` Zhang, Helin
2015-07-30  1:58                                   ` Jeff Venable, Sr.
2015-07-31 15:35                                     ` Zhang, Helin
2015-02-27 10:46                   ` [dpdk-dev] [PATCH v6 0/6] enicpmd: Cisco Systems Inc. VIC Ethernet PMD Thomas Monjalon
2015-03-11  9:05                     ` Sujith Sankar (ssujith)
2015-05-11  9:25                   ` Thomas Monjalon
2014-11-25 20:11 ` Neil Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D0C82A9E.2BA5D%ssujith@cisco.com \
    --to=ssujith@cisco.com \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    --cc=prrao@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).