From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AB2AB43EAD; Wed, 24 Apr 2024 15:24:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 98BCA4347D; Wed, 24 Apr 2024 15:24:24 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 61CB043497 for ; Wed, 24 Apr 2024 15:24:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713965051; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=y6Y3/Jxgh/YEC5ofn/82yzPLjfxgYuXrmwMH46JVR3Q=; b=MJS0LoWbc0s5fIZ5CkzwDFEMfTROKXTHV7TWXTlJcohnT6m8aA1EwHjzpegENpRSiYNPgi Oq9C3TWQ8i2c6BCZw7SzVhdo9SCrtDnSBJ3lFnkqxNWYZK5p/KdqRH6N4f+HnS88cB74Ju qJ2EM6LX538dgsOkpnHLvpfzRykd5Qs= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-458-aKkIT7BVPeadOwp0sAOBUg-1; Wed, 24 Apr 2024 09:24:10 -0400 X-MC-Unique: aKkIT7BVPeadOwp0sAOBUg-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-417fb8195d7so33293005e9.0 for ; Wed, 24 Apr 2024 06:24:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713965049; x=1714569849; h=in-reply-to:references:user-agent:to:from:cc:subject:message-id :date:content-transfer-encoding:mime-version:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=y6Y3/Jxgh/YEC5ofn/82yzPLjfxgYuXrmwMH46JVR3Q=; b=vXCainO8VzzB9b7oKod/h2CBxPtAmJHxCfeFkCwqf7yapROR7Jmy5a0lw1snIcBiZy VI650PxLZb51k8JCCwiwQXs/5bVPdwYDUwW6W2mEGz54hLU+8Jk9wkynO5Sz0W2ne2kZ m2w9dCt0mJfBfksIsu5B6CN/LO78kAXW49Acx/pBVlP/Bx9ohJuD1StHrv2Ln0TLuaN+ PPH+yJ0U///EyMa+Qp3AjZsoulk1iDAAlCvmKdfrwHmZTy+i4Dv2EZlzCKMBucZ7ES35 9E1c46iglYowb8T+B0fCmib0yFDg2mooXeZ85jMgDQUuNn/wDjos0TKvbD8Xjvno6tXp 2+Tw== X-Gm-Message-State: AOJu0Yznu1x2o+xdO+yeHq4WStC9tQVZwFNTFjjmn2z8YsvwJVhmlh7q xTRtVJmZOU2GHEo+ho8JNHgJlJpO5IHl7wYogsktRJ1TZ+zZ9BFR0P4uIffV8h0foMQv6Fg95IR hvBIkfnvrZjLJD832DU6TDyx5s9DktygPqmAWRicSUDtqkzY+ X-Received: by 2002:a05:600c:5246:b0:418:e6a1:c0e8 with SMTP id fc6-20020a05600c524600b00418e6a1c0e8mr1549410wmb.7.1713965049537; Wed, 24 Apr 2024 06:24:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF/LEGZbf+ZrBfBl4e60l/HLymSo2GYuanNXpJvVBXF2oLNg9bPYXWO1G+zTdoFpbErWsaPgQ== X-Received: by 2002:a05:600c:5246:b0:418:e6a1:c0e8 with SMTP id fc6-20020a05600c524600b00418e6a1c0e8mr1549396wmb.7.1713965049157; Wed, 24 Apr 2024 06:24:09 -0700 (PDT) Received: from localhost (2a01cb000f8b9700598da2e1679e8383.ipv6.abo.wanadoo.fr. [2a01:cb00:f8b:9700:598d:a2e1:679e:8383]) by smtp.gmail.com with ESMTPSA id g18-20020a05600c4ed200b00418729383a4sm23615831wmq.46.2024.04.24.06.24.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Apr 2024 06:24:08 -0700 (PDT) Mime-Version: 1.0 Date: Wed, 24 Apr 2024 15:24:08 +0200 Message-Id: Subject: Re: [RFC] graph/node: feedback and future improvements Cc: , "Jerin Jacob" , "Kiran Kumar K" , "Nithin Dabilpuram" , "Pavan Nikhilesh" , "Thomas Monjalon" From: "Robin Jarry" To: "Jerin Jacob" User-Agent: aerc/0.17.0-127-gd6c3edd0e9f8 References: In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8; format=Flowed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Robin Jarry, Apr 14, 2024 at 12:35: > Jerin Jacob, Apr 06, 2024 at 01:11: > > Great. > > > > You may consider improving and/or adding inbuilt nodes for generic=20 > > protocol processing. Furthermore, consider contributing on app/graph.= =20 > > I think, most likely, you should be able to leverage app/graph. > > Thanks! I am definitely planning to upstream nodes into DPDK as much as= =20 > possible. I still need to determine what is the correct level of data=20 > path node public API so that the nodes can be agnostic of the control=20 > plane implementation. Hey Jerin, while working on ARP support [1], I noticed that we need to have=20 configurability of nodes (or set of nodes to be more precise) from the=20 outside. But the nodes in the set also need to specify metadata that=20 they expect from other nodes to store in mbufs. For now, I have used a single dynamic field which I repurpose for every=20 node set depending on the use case [2]. However this raises a question: how can we make it generic (and agnostic to the application) before=20 inclusion in lib/node? I would be glad to have your opinion on the subject. Cheers! [1] https://github.com/rjarry/brouter/commit/e05246f51b736821b6689d40 [2] https://github.com/rjarry/brouter/blob/main/modules/infra/datapath/br_m= buf.h