* [dpdk-dev] fm10k_rxtx.c does not compile
@ 2015-02-18 17:01 Wiles, Keith
2015-02-18 17:18 ` Thomas Monjalon
0 siblings, 1 reply; 4+ messages in thread
From: Wiles, Keith @ 2015-02-18 17:01 UTC (permalink / raw)
To: dev
I just pulled the code and found a unused function error ‘dump_rxd()’
I had to add the ifdef around the function and remove the ifdef inside the function:
#ifdef RTE_LIBRTE_FM10K_DEBUG_RX
static inline void dump_rxd(union fm10k_rx_desc *rxd)
{
RTE_SET_USED(rxd);
PMD_RX_LOG(DEBUG, "+----------------|----------------+");
PMD_RX_LOG(DEBUG, "| GLORT | PKT HDR & TYPE |");
PMD_RX_LOG(DEBUG, "| 0x%08x | 0x%08x |", rxd->d.glort,
rxd->d.data);
PMD_RX_LOG(DEBUG, "+----------------|----------------+");
PMD_RX_LOG(DEBUG, "| VLAN & LEN | STATUS |");
PMD_RX_LOG(DEBUG, "| 0x%08x | 0x%08x |", rxd->d.vlan_len,
rxd->d.staterr);
PMD_RX_LOG(DEBUG, "+----------------|----------------+");
PMD_RX_LOG(DEBUG, "| RESERVED | RSS_HASH |");
PMD_RX_LOG(DEBUG, "| 0x%08x | 0x%08x |", 0, rxd->d.rss);
PMD_RX_LOG(DEBUG, "+----------------|----------------+");
PMD_RX_LOG(DEBUG, "| TIME TAG |");
PMD_RX_LOG(DEBUG, "| 0x%016lx |", rxd->q.timestamp);
PMD_RX_LOG(DEBUG, "+----------------|----------------+");
}
#endif
Also clang on Ubuntu 14.04 does not like the option:
CC fm10k_pf.o
error: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-const-variable'? [-Werror,-Wunknown-warning-option]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] fm10k_rxtx.c does not compile
2015-02-18 17:01 [dpdk-dev] fm10k_rxtx.c does not compile Wiles, Keith
@ 2015-02-18 17:18 ` Thomas Monjalon
2015-02-18 17:29 ` Wiles, Keith
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Monjalon @ 2015-02-18 17:18 UTC (permalink / raw)
To: Wiles, Keith; +Cc: dev
Hi Keith,
2015-02-18 17:01, Wiles, Keith:
> I just pulled the code and found a unused function error ‘dump_rxd()’
>
> I had to add the ifdef around the function and remove the ifdef inside the function:
>
> #ifdef RTE_LIBRTE_FM10K_DEBUG_RX
> static inline void dump_rxd(union fm10k_rx_desc *rxd)
> {
> RTE_SET_USED(rxd);
> PMD_RX_LOG(DEBUG, "+----------------|----------------+");
> PMD_RX_LOG(DEBUG, "| GLORT | PKT HDR & TYPE |");
> PMD_RX_LOG(DEBUG, "| 0x%08x | 0x%08x |", rxd->d.glort,
> rxd->d.data);
> PMD_RX_LOG(DEBUG, "+----------------|----------------+");
> PMD_RX_LOG(DEBUG, "| VLAN & LEN | STATUS |");
> PMD_RX_LOG(DEBUG, "| 0x%08x | 0x%08x |", rxd->d.vlan_len,
> rxd->d.staterr);
> PMD_RX_LOG(DEBUG, "+----------------|----------------+");
> PMD_RX_LOG(DEBUG, "| RESERVED | RSS_HASH |");
> PMD_RX_LOG(DEBUG, "| 0x%08x | 0x%08x |", 0, rxd->d.rss);
> PMD_RX_LOG(DEBUG, "+----------------|----------------+");
> PMD_RX_LOG(DEBUG, "| TIME TAG |");
> PMD_RX_LOG(DEBUG, "| 0x%016lx |", rxd->q.timestamp);
> PMD_RX_LOG(DEBUG, "+----------------|----------------+");
> }
> #endif
>
> Also clang on Ubuntu 14.04 does not like the option:
> CC fm10k_pf.o
> error: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-const-variable'? [-Werror,-Wunknown-warning-option]
Thanks for reporting.
I have no error with GCC 4.9.2.
Please could you try to send a patch?
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] fm10k_rxtx.c does not compile
2015-02-18 17:18 ` Thomas Monjalon
@ 2015-02-18 17:29 ` Wiles, Keith
2015-02-18 18:10 ` Jeff Shaw
0 siblings, 1 reply; 4+ messages in thread
From: Wiles, Keith @ 2015-02-18 17:29 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev
I believe Jeff @ Intel is going to submit a patch soon.
On 2/18/15, 11:18 AM, "Thomas Monjalon" <thomas.monjalon@6wind.com> wrote:
>Hi Keith,
>
>2015-02-18 17:01, Wiles, Keith:
>> I just pulled the code and found a unused function error Œdump_rxd()¹
>>
>> I had to add the ifdef around the function and remove the ifdef inside
>>the function:
>>
>> #ifdef RTE_LIBRTE_FM10K_DEBUG_RX
>> static inline void dump_rxd(union fm10k_rx_desc *rxd)
>> {
>> RTE_SET_USED(rxd);
>> PMD_RX_LOG(DEBUG, "+----------------|----------------+");
>> PMD_RX_LOG(DEBUG, "| GLORT | PKT HDR & TYPE |");
>> PMD_RX_LOG(DEBUG, "| 0x%08x | 0x%08x |", rxd->d.glort,
>> rxd->d.data);
>> PMD_RX_LOG(DEBUG, "+----------------|----------------+");
>> PMD_RX_LOG(DEBUG, "| VLAN & LEN | STATUS |");
>> PMD_RX_LOG(DEBUG, "| 0x%08x | 0x%08x |", rxd->d.vlan_len,
>> rxd->d.staterr);
>> PMD_RX_LOG(DEBUG, "+----------------|----------------+");
>> PMD_RX_LOG(DEBUG, "| RESERVED | RSS_HASH |");
>> PMD_RX_LOG(DEBUG, "| 0x%08x | 0x%08x |", 0, rxd->d.rss);
>> PMD_RX_LOG(DEBUG, "+----------------|----------------+");
>> PMD_RX_LOG(DEBUG, "| TIME TAG |");
>> PMD_RX_LOG(DEBUG, "| 0x%016lx |", rxd->q.timestamp);
>> PMD_RX_LOG(DEBUG, "+----------------|----------------+");
>> }
>> #endif
>>
>> Also clang on Ubuntu 14.04 does not like the option:
>> CC fm10k_pf.o
>> error: unknown warning option '-Wno-unused-but-set-variable'; did you
>>mean '-Wno-unused-const-variable'? [-Werror,-Wunknown-warning-option]
>
>Thanks for reporting.
>I have no error with GCC 4.9.2.
>Please could you try to send a patch?
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-02-18 18:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-18 17:01 [dpdk-dev] fm10k_rxtx.c does not compile Wiles, Keith
2015-02-18 17:18 ` Thomas Monjalon
2015-02-18 17:29 ` Wiles, Keith
2015-02-18 18:10 ` Jeff Shaw
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).