From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id A9F10B48B for ; Wed, 18 Feb 2015 19:39:53 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP; 18 Feb 2015 10:31:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,603,1418112000"; d="scan'208";a="653966819" Received: from orsmsx109.amr.corp.intel.com ([10.22.240.7]) by orsmga001.jf.intel.com with ESMTP; 18 Feb 2015 10:39:17 -0800 Received: from orsmsx115.amr.corp.intel.com (10.22.240.11) by ORSMSX109.amr.corp.intel.com (10.22.240.7) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 18 Feb 2015 10:39:16 -0800 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by ORSMSX115.amr.corp.intel.com (10.22.240.11) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 18 Feb 2015 10:39:11 -0800 Received: from fmsmsx113.amr.corp.intel.com ([169.254.13.112]) by FMSMSX154.amr.corp.intel.com ([169.254.6.133]) with mapi id 14.03.0195.001; Wed, 18 Feb 2015 10:39:11 -0800 From: "Wiles, Keith" To: "Shaw, Jeffrey B" , "dev@dpdk.org" Thread-Topic: [PATCH] fm10k: fix clang unused function error Thread-Index: AQHQS6XOomEYxqMoM0yRcayJtVJXq5z23piA Date: Wed, 18 Feb 2015 18:39:10 +0000 Message-ID: References: <1424282860-1517-1-git-send-email-jeffrey.b.shaw@intel.com> In-Reply-To: <1424282860-1517-1-git-send-email-jeffrey.b.shaw@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.255.34.223] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] fm10k: fix clang unused function error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Feb 2015 18:39:54 -0000 On 2/18/15, 12:07 PM, "Shaw, Jeffrey B" wrote: >This commit fixes the following error which was reported when >compiling with clang by moving the function inside an >RTE_LIBRTE_FM10K_DEBUG_RX ifdef block. > >error: unused function 'dump_rxd' > >Signed-off-by: Jeff Shaw Acked-by: keith.wiles@intel.com >--- > lib/librte_pmd_fm10k/fm10k_rxtx.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > >diff --git a/lib/librte_pmd_fm10k/fm10k_rxtx.c >b/lib/librte_pmd_fm10k/fm10k_rxtx.c >index f6768f0..83bddfc 100644 >--- a/lib/librte_pmd_fm10k/fm10k_rxtx.c >+++ b/lib/librte_pmd_fm10k/fm10k_rxtx.c >@@ -41,11 +41,9 @@ > #define rte_packet_prefetch(p) do {} while (0) > #endif >=20 >+#ifdef RTE_LIBRTE_FM10K_DEBUG_RX > static inline void dump_rxd(union fm10k_rx_desc *rxd) > { >-#ifndef RTE_LIBRTE_FM10K_DEBUG_RX >- RTE_SET_USED(rxd); >-#endif > PMD_RX_LOG(DEBUG, "+----------------|----------------+"); > PMD_RX_LOG(DEBUG, "| GLORT | PKT HDR & TYPE |"); > PMD_RX_LOG(DEBUG, "| 0x%08x | 0x%08x |", rxd->d.glort, >@@ -62,6 +60,7 @@ static inline void dump_rxd(union fm10k_rx_desc *rxd) > PMD_RX_LOG(DEBUG, "| 0x%016lx |", rxd->q.timestamp); > PMD_RX_LOG(DEBUG, "+----------------|----------------+"); > } >+#endif >=20 > static inline void > rx_desc_to_ol_flags(struct rte_mbuf *m, const union fm10k_rx_desc *d) >--=20 >2.1.0 >