From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 46E172E7B for ; Wed, 8 Apr 2015 18:25:46 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP; 08 Apr 2015 09:25:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,545,1422950400"; d="scan'208";a="552969585" Received: from orsmsx108.amr.corp.intel.com ([10.22.240.6]) by orsmga003.jf.intel.com with ESMTP; 08 Apr 2015 09:25:46 -0700 Received: from orsmsx158.amr.corp.intel.com (10.22.240.20) by ORSMSX108.amr.corp.intel.com (10.22.240.6) with Microsoft SMTP Server (TLS) id 14.3.224.2; Wed, 8 Apr 2015 09:25:44 -0700 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by ORSMSX158.amr.corp.intel.com (10.22.240.20) with Microsoft SMTP Server (TLS) id 14.3.224.2; Wed, 8 Apr 2015 09:25:44 -0700 Received: from fmsmsx113.amr.corp.intel.com ([169.254.13.111]) by FMSMSX152.amr.corp.intel.com ([10.18.125.5]) with mapi id 14.03.0224.002; Wed, 8 Apr 2015 09:25:44 -0700 From: "Wiles, Keith" To: Thomas Monjalon , "Butler, Siobhan A" Thread-Topic: [dpdk-dev] tools brainstorming Thread-Index: AQHQYx11uIkL9FTheESuDxqnoTBHMp1DgO2AgAACsgCAAFonAP//rtYA Date: Wed, 8 Apr 2015 16:25:44 +0000 Message-ID: References: <3571725.20GtF5MAnU@xps13> <0C5AFCA4B3408848ADF2A3073F7D8CC86D58F9C2@IRSMSX109.ger.corp.intel.com> <2232884.6IKBPajdgE@xps13> In-Reply-To: <2232884.6IKBPajdgE@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.13.154] Content-Type: text/plain; charset="us-ascii" Content-ID: <2E16B6FC64E20A4C9CE5BE9F54802359@intel.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] tools brainstorming X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Apr 2015 16:25:46 -0000 On 4/8/15, 11:16 AM, "Thomas Monjalon" wrote: >2015-04-08 15:53, Wiles, Keith: >> One of the biggest problems with any style is helping the developer >> maintain the style. Using some tool does help and I have used astyle >> before, not bad code formatter. Here is a few that seem to be >>reasonable. >>=20 >> http://astyle.sourceforge.net/ >>=20 >> http://uncrustify.sourceforge.net/ >>=20 >> http://sourceforge.net/projects/gcgreatcode/ > >I'm not sure it's a good idea to convert the codebase automatically. >The coding style must be a reference for new patches and they must be >automatically checked with a dedicated checkpatch tool. I was not suggesting these tools be used automatically only to get code to comply as it is being imported or patched. If we product a config file for one of the above tools then everyone can review his code before sending the patch. >By forbidding patches which don't comply, the codebase will be naturally >converted over time. It is difficult to view patches to determine if they comply, which is the only problem. Seeing the patched file is easier to see code format problems IMO. > >I didn't review this proposal yet. >My first comment is that it's too long to read :) >When a consensus is done, it must be added with a patch with custom >checkpatch addition. >