From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id EC4983237 for ; Tue, 14 Apr 2015 18:19:39 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP; 14 Apr 2015 09:19:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,576,1422950400"; d="scan'208";a="555889550" Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5]) by orsmga003.jf.intel.com with ESMTP; 14 Apr 2015 09:19:38 -0700 Received: from orsmsx111.amr.corp.intel.com (10.22.240.12) by ORSMSX107.amr.corp.intel.com (10.22.240.5) with Microsoft SMTP Server (TLS) id 14.3.224.2; Tue, 14 Apr 2015 09:19:38 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by ORSMSX111.amr.corp.intel.com (10.22.240.12) with Microsoft SMTP Server (TLS) id 14.3.224.2; Tue, 14 Apr 2015 09:19:38 -0700 Received: from fmsmsx113.amr.corp.intel.com ([169.254.13.111]) by FMSMSX155.amr.corp.intel.com ([169.254.5.89]) with mapi id 14.03.0224.002; Tue, 14 Apr 2015 09:19:38 -0700 From: "Wiles, Keith" To: Thomas Monjalon , "Richardson, Bruce" Thread-Topic: [dpdk-dev] tools brainstorming Thread-Index: AQHQYx11uIkL9FTheESuDxqnoTBHMp1DgO2AgAACsgCAAFonAIAJVriAgAAIvYD//7uqAA== Date: Tue, 14 Apr 2015 16:19:37 +0000 Message-ID: References: <3571725.20GtF5MAnU@xps13> <2232884.6IKBPajdgE@xps13> <20150414145255.GC3296@bricha3-MOBL3> <1483348.C8YyOOilOR@xps13> In-Reply-To: <1483348.C8YyOOilOR@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.86.116] Content-Type: text/plain; charset="us-ascii" Content-ID: <31F7D0E60ABD7042BDA9881D0B62F3B1@intel.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] tools brainstorming X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Apr 2015 16:19:40 -0000 On 4/14/15, 10:24 AM, "Thomas Monjalon" wrote: >2015-04-14 15:52, Bruce Richardson: >> On Wed, Apr 08, 2015 at 06:16:12PM +0200, Thomas Monjalon wrote: >> > When a consensus is done, it must be added with a patch with custom >> > checkpatch addition. >> >=20 >> My personal feeling is that we should try and keep checkpatch >>modifications to a >> minimum. Right now, we can use checkpatch as-is from kernel.org, right? > >Yes that's something we have to discuss. >It should be preferred to avoid "forking" checkpatch. > >At the moment, I'm using this configuration: > > options=3D"$options --max-line-length=3D100" > options=3D"$options --show-types" > options=3D"$options --ignore=3DLINUX_VERSION_CODE,FILE_PATH_CHANGES,\ > VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,\ > SPLIT_STRING,LINE_SPACING,NEW_TYPEDEFS,COMPLEX_MACRO" > > linux/scripts/checkpatch.pl $options > >I would like to submit a script to run checkpatch with DPDK configuration >when the coding rules are clear. > >However, I've already seen some options which are not enough configurable >(don't remember which one). For such corner case, I would see 3 solutions >(from the most to the least desired): > - submit a patch to allow more configuration to kernel.org > - give up automatic handling of corner cases > - maintain a fork in scripts/ directory Here is the next solution - Stop using checkpatch and use a real tool for formatting code instead. If someone uses a tool before commit, then create the patch which does not require checkpatch. Most of these tools can define an output file or they leave behind the original file as a backup or we can see if they have a non-modify mode and just points out the problems. As in astyle '--dry-run' can be used, plus it saves the original file as XXXXX.orig or you can change the .orig to your own value. >