From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 99835C346 for ; Tue, 14 Apr 2015 20:52:53 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP; 14 Apr 2015 11:52:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,577,1422950400"; d="scan'208";a="555974163" Received: from orsmsx104.amr.corp.intel.com ([10.22.225.131]) by orsmga003.jf.intel.com with ESMTP; 14 Apr 2015 11:52:52 -0700 Received: from orsmsx158.amr.corp.intel.com (10.22.240.20) by ORSMSX104.amr.corp.intel.com (10.22.225.131) with Microsoft SMTP Server (TLS) id 14.3.224.2; Tue, 14 Apr 2015 11:52:52 -0700 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by ORSMSX158.amr.corp.intel.com (10.22.240.20) with Microsoft SMTP Server (TLS) id 14.3.224.2; Tue, 14 Apr 2015 11:52:51 -0700 Received: from fmsmsx113.amr.corp.intel.com ([169.254.13.111]) by FMSMSX153.amr.corp.intel.com ([10.18.125.6]) with mapi id 14.03.0224.002; Tue, 14 Apr 2015 11:52:51 -0700 From: "Wiles, Keith" To: "Wiles, Keith" , Thomas Monjalon , "Richardson, Bruce" Thread-Topic: [dpdk-dev] tools brainstorming Thread-Index: AQHQYx11uIkL9FTheESuDxqnoTBHMp1DgO2AgAACsgCAAFonAIAJVriAgAAIvYD//7uqAIAAKs+A Date: Tue, 14 Apr 2015 18:52:51 +0000 Message-ID: References: <3571725.20GtF5MAnU@xps13> <2232884.6IKBPajdgE@xps13> <20150414145255.GC3296@bricha3-MOBL3> <1483348.C8YyOOilOR@xps13> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.86.116] Content-Type: text/plain; charset="Windows-1252" Content-ID: <46FBC1DEC6B0094AB21C4D4EDC59BCBD@intel.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] tools brainstorming X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Apr 2015 18:52:54 -0000 On 4/14/15, 11:19 AM, "Wiles, Keith" wrote: > > >On 4/14/15, 10:24 AM, "Thomas Monjalon" wrote: > >>2015-04-14 15:52, Bruce Richardson: >>> On Wed, Apr 08, 2015 at 06:16:12PM +0200, Thomas Monjalon wrote: >>> > When a consensus is done, it must be added with a patch with custom >>> > checkpatch addition. >>> >=20 >>> My personal feeling is that we should try and keep checkpatch >>>modifications to a >>> minimum. Right now, we can use checkpatch as-is from kernel.org, right? >> >>Yes that's something we have to discuss. >>It should be preferred to avoid "forking" checkpatch. >> >>At the moment, I'm using this configuration: >> >> options=3D"$options --max-line-length=3D100" >> options=3D"$options --show-types" >> options=3D"$options --ignore=3DLINUX_VERSION_CODE,FILE_PATH_CHANGES,\ >> VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,\ >> SPLIT_STRING,LINE_SPACING,NEW_TYPEDEFS,COMPLEX_MACRO" >> >> linux/scripts/checkpatch.pl $options >> >>I would like to submit a script to run checkpatch with DPDK configuration >>when the coding rules are clear. >> >>However, I've already seen some options which are not enough configurable >>(don't remember which one). For such corner case, I would see 3 solutions >>(from the most to the least desired): >> - submit a patch to allow more configuration to kernel.org >> - give up automatic handling of corner cases >> - maintain a fork in scripts/ directory >Here is the next solution > - Stop using checkpatch and use a real tool for formatting code instead. >If someone uses a tool before commit, then create the patch which does not >require checkpatch. >Most of these tools can define an output file or they leave behind the >original file as a backup or we can see if they have a non-modify mode and >just points out the problems. As in astyle '--dry-run' can be used, plus >it saves the original file as XXXXX.orig or you can change the .orig to >your own value. >> Using uncrustify with following config file seems to be very close to what we have today and removes trailing white spaces. I changed the indent_with_tabs to 2 instead of 1. I am sure we could even get closer. The uncrustify creates the updated file into XXXXX.uncrustify which does not effect the original file. Then you can use meld or some other tool to view the changes. http://uncrustify.sourceforge.net/default.cfg The source is here http://uncrustify.sourceforge.net/ pretty simple install on my Ubuntu 14.04 machine. I also installed the amd64 image of UniversalindentGUI. I tried the =8CUbuntu Software Center=B9 version, but it required a bit more effort the= n just installing. It appeared the code needed a specific version of a library I did not track down. http://uncrustify.sourceforge.net/ It looks like using uncrustify and a config file gives use a tool to verify the code is formatted correctly before commit and patch create. Have a look and see what you think.