Re: [dpdk-dev] [PATCH v2 2/2] Update Docs for new EXTRA_LDLIBS variable

["Wiles, Keith" <keith.wiles@intel.com>]

On 4/29/15, 10:04 AM, "Gonzalez Monroy, Sergio"
<sergio.gonzalez.monroy@intel.com> wrote:

>On 29/04/2015 16:00, Wiles, Keith wrote:
>>
>> On 4/29/15, 9:55 AM, "Gonzalez Monroy, Sergio"
>> <sergio.gonzalez.monroy@intel.com> wrote:
>>
>>> On 29/04/2015 15:37, Keith Wiles wrote:
>>>> Signed-off-by: Keith Wiles <keith.wiles@intel.com>
>>>> ---
>>>>    doc/build-sdk-quick.txt                          | 1 +
>>>>    doc/guides/prog_guide/dev_kit_build_system.rst   | 2 ++
>>>>    doc/guides/prog_guide/dev_kit_root_make_help.rst | 2 +-
>>>>    3 files changed, 4 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/doc/build-sdk-quick.txt b/doc/build-sdk-quick.txt
>>>> index 041a40e..26d5442 100644
>>>> --- a/doc/build-sdk-quick.txt
>>>> +++ b/doc/build-sdk-quick.txt
>>>> @@ -13,6 +13,7 @@ Build variables
>>>>    	EXTRA_CPPFLAGS   preprocessor options
>>>>    	EXTRA_CFLAGS     compiler options
>>>>    	EXTRA_LDFLAGS    linker options
>>>> +	EXTRA_LDLIBS     linker libary options
>>>>    	RTE_KERNELDIR    linux headers path
>>>>    	CROSS     toolchain prefix
>>>>    	V         verbose
>>>> diff --git a/doc/guides/prog_guide/dev_kit_build_system.rst
>>>> b/doc/guides/prog_guide/dev_kit_build_system.rst
>>>> index cf5c96f..b8ef167 100644
>>>> --- a/doc/guides/prog_guide/dev_kit_build_system.rst
>>>> +++ b/doc/guides/prog_guide/dev_kit_build_system.rst
>>>> @@ -413,6 +413,8 @@ Variables that Can be Set/Overridden by the User
>>>>in
>>>> a Makefile or Command Line
>>>>    
>>>>    *   EXTRA_LDFLAGS: The content of this variable is appended after
>>>> LDFLAGS when linking.
>>>>    
>>>> +*   EXTRA_LDLIBS: The content of this variable is appended after
>>>> LDLIBS when linking.
>>>> +
>>>>    *   EXTRA_ASFLAGS: The content of this variable is appended after
>>>> ASFLAGS when assembling.
>>>>    
>>>>    *   EXTRA_CPPFLAGS: The content of this variable is appended after
>>>> CPPFLAGS when using a C preprocessor on assembly files.
>>>> diff --git a/doc/guides/prog_guide/dev_kit_root_make_help.rst
>>>> b/doc/guides/prog_guide/dev_kit_root_make_help.rst
>>>> index 4f30192..fdc5fea 100644
>>>> --- a/doc/guides/prog_guide/dev_kit_root_make_help.rst
>>>> +++ b/doc/guides/prog_guide/dev_kit_root_make_help.rst
>>>> @@ -205,7 +205,7 @@ The following variables can be specified on the
>>>> command line:
>>>>    
>>>>        Enable dependency debugging. This provides some useful
>>>> information about why a target is built or not.
>>>>    
>>>> -*   EXTRA_CFLAGS=, EXTRA_LDFLAGS=, EXTRA_ASFLAGS=, EXTRA_CPPFLAGS=
>>>> +*   EXTRA_CFLAGS=, EXTRA_LDFLAGS=, EXTRA_LDLIBS=, EXTRA_ASFLAGS=,
>>>> EXTRA_CPPFLAGS=
>>>>    
>>>>        Append specific compilation, link or asm flags.
>>>>    
>>> Do we need to remove LDLIBS from section 28.3.4?
>> Missed it, but it should be LDLIBS-y now
>It would still be lost cause you are resetting LDLIBS-y value at the
>start of rte.app.mk, right?

Yes, LDLIBS-y is reset at the top, just as LDLIBS was reset in the
original rte.app.mk file. I would assume this is the correct design and we
should reset LDLIBS-y at the top of the file, right?

>The only way to add to LDLIBS-y would be using EXTRA_LDLIBS.
>
>Sergio
>>> With the current patch the value of LDLIBS in the app makefile is lost.
>>>
>>> Sergio
>