From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 75619C8DC for ; Wed, 29 Apr 2015 17:16:23 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP; 29 Apr 2015 08:16:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,671,1422950400"; d="scan'208";a="687497884" Received: from orsmsx105.amr.corp.intel.com ([10.22.225.132]) by orsmga001.jf.intel.com with ESMTP; 29 Apr 2015 08:16:14 -0700 Received: from orsmsx156.amr.corp.intel.com (10.22.240.22) by ORSMSX105.amr.corp.intel.com (10.22.225.132) with Microsoft SMTP Server (TLS) id 14.3.224.2; Wed, 29 Apr 2015 08:16:13 -0700 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by ORSMSX156.amr.corp.intel.com (10.22.240.22) with Microsoft SMTP Server (TLS) id 14.3.224.2; Wed, 29 Apr 2015 08:16:13 -0700 Received: from fmsmsx113.amr.corp.intel.com ([169.254.13.26]) by FMSMSX152.amr.corp.intel.com ([169.254.6.233]) with mapi id 14.03.0224.002; Wed, 29 Apr 2015 08:16:12 -0700 From: "Wiles, Keith" To: "Gonzalez Monroy, Sergio" Thread-Topic: [dpdk-dev] [PATCH v2 2/2] Update Docs for new EXTRA_LDLIBS variable Thread-Index: AQHQgool58Nrd6RP/0G1NEKl3k1/BZ1kiTiA//+tmACAAFUGgP//r3UA Date: Wed, 29 Apr 2015 15:16:11 +0000 Message-ID: References: <1430318263-3189-1-git-send-email-keith.wiles@intel.com> <1430318263-3189-2-git-send-email-keith.wiles@intel.com> <5540F0C9.30806@intel.com> <5540F2FB.1060704@intel.com> In-Reply-To: <5540F2FB.1060704@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.252.204.210] Content-Type: text/plain; charset="us-ascii" Content-ID: <80A34389DC186C4E9B0D868B7131A524@intel.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 2/2] Update Docs for new EXTRA_LDLIBS variable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Apr 2015 15:16:24 -0000 On 4/29/15, 10:04 AM, "Gonzalez Monroy, Sergio" wrote: >On 29/04/2015 16:00, Wiles, Keith wrote: >> >> On 4/29/15, 9:55 AM, "Gonzalez Monroy, Sergio" >> wrote: >> >>> On 29/04/2015 15:37, Keith Wiles wrote: >>>> Signed-off-by: Keith Wiles >>>> --- >>>> doc/build-sdk-quick.txt | 1 + >>>> doc/guides/prog_guide/dev_kit_build_system.rst | 2 ++ >>>> doc/guides/prog_guide/dev_kit_root_make_help.rst | 2 +- >>>> 3 files changed, 4 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/doc/build-sdk-quick.txt b/doc/build-sdk-quick.txt >>>> index 041a40e..26d5442 100644 >>>> --- a/doc/build-sdk-quick.txt >>>> +++ b/doc/build-sdk-quick.txt >>>> @@ -13,6 +13,7 @@ Build variables >>>> EXTRA_CPPFLAGS preprocessor options >>>> EXTRA_CFLAGS compiler options >>>> EXTRA_LDFLAGS linker options >>>> + EXTRA_LDLIBS linker libary options >>>> RTE_KERNELDIR linux headers path >>>> CROSS toolchain prefix >>>> V verbose >>>> diff --git a/doc/guides/prog_guide/dev_kit_build_system.rst >>>> b/doc/guides/prog_guide/dev_kit_build_system.rst >>>> index cf5c96f..b8ef167 100644 >>>> --- a/doc/guides/prog_guide/dev_kit_build_system.rst >>>> +++ b/doc/guides/prog_guide/dev_kit_build_system.rst >>>> @@ -413,6 +413,8 @@ Variables that Can be Set/Overridden by the User >>>>in >>>> a Makefile or Command Line >>>> =20 >>>> * EXTRA_LDFLAGS: The content of this variable is appended after >>>> LDFLAGS when linking. >>>> =20 >>>> +* EXTRA_LDLIBS: The content of this variable is appended after >>>> LDLIBS when linking. >>>> + >>>> * EXTRA_ASFLAGS: The content of this variable is appended after >>>> ASFLAGS when assembling. >>>> =20 >>>> * EXTRA_CPPFLAGS: The content of this variable is appended after >>>> CPPFLAGS when using a C preprocessor on assembly files. >>>> diff --git a/doc/guides/prog_guide/dev_kit_root_make_help.rst >>>> b/doc/guides/prog_guide/dev_kit_root_make_help.rst >>>> index 4f30192..fdc5fea 100644 >>>> --- a/doc/guides/prog_guide/dev_kit_root_make_help.rst >>>> +++ b/doc/guides/prog_guide/dev_kit_root_make_help.rst >>>> @@ -205,7 +205,7 @@ The following variables can be specified on the >>>> command line: >>>> =20 >>>> Enable dependency debugging. This provides some useful >>>> information about why a target is built or not. >>>> =20 >>>> -* EXTRA_CFLAGS=3D, EXTRA_LDFLAGS=3D, EXTRA_ASFLAGS=3D, EXTRA_CPPFLA= GS=3D >>>> +* EXTRA_CFLAGS=3D, EXTRA_LDFLAGS=3D, EXTRA_LDLIBS=3D, EXTRA_ASFLAGS= =3D, >>>> EXTRA_CPPFLAGS=3D >>>> =20 >>>> Append specific compilation, link or asm flags. >>>> =20 >>> Do we need to remove LDLIBS from section 28.3.4? >> Missed it, but it should be LDLIBS-y now >It would still be lost cause you are resetting LDLIBS-y value at the >start of rte.app.mk, right? Yes, LDLIBS-y is reset at the top, just as LDLIBS was reset in the original rte.app.mk file. I would assume this is the correct design and we should reset LDLIBS-y at the top of the file, right? >The only way to add to LDLIBS-y would be using EXTRA_LDLIBS. > >Sergio >>> With the current patch the value of LDLIBS in the app makefile is lost. >>> >>> Sergio >