From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alln-iport-6.cisco.com (alln-iport-6.cisco.com [173.37.142.93]) by dpdk.org (Postfix) with ESMTP id 2D0852A07 for ; Thu, 7 May 2015 05:43:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=3346; q=dns/txt; s=iport; t=1430970221; x=1432179821; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=bOnH5gF0/As3q55wntFw6AQo17BTTbzbNCAAHfNbKbw=; b=VGWacRc8L+FmLiJXKUZZm1at+b4BpiPfmLAAW/66gJhVCKz3hsYFF5HD 50S7CPwhS5XRM/t3FLVRHLcmroxXtlvSQdgRMV38t5eCQi3wec/d/rVwM Z3Mf94fwOI++XXglV0GnnrW1n58zOP1bdeI2Nslz8OGo12hkzyd0DYaxM I=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0CuBABd3kpV/5JdJa1cgwyBMgbFdwmHWwKBJzgUAQEBAQEBAYEKhCEBAQQ6PxACAQgYHhAyJQIEDgWILMUJAQEBAQEBAQEBAQEBAQEBAQEBAQEBF4s5hQUHhC0BBJIoiliWOSNhgxVvgUSBAQEBAQ X-IronPort-AV: E=Sophos;i="5.13,382,1427760000"; d="scan'208";a="147869838" Received: from rcdn-core-10.cisco.com ([173.37.93.146]) by alln-iport-6.cisco.com with ESMTP; 07 May 2015 03:43:40 +0000 Received: from xhc-rcd-x13.cisco.com (xhc-rcd-x13.cisco.com [173.37.183.87]) by rcdn-core-10.cisco.com (8.14.5/8.14.5) with ESMTP id t473hdqX006844 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Thu, 7 May 2015 03:43:39 GMT Received: from xmb-aln-x07.cisco.com ([169.254.2.81]) by xhc-rcd-x13.cisco.com ([173.37.183.87]) with mapi id 14.03.0195.001; Wed, 6 May 2015 22:43:39 -0500 From: "Sujith Sankar (ssujith)" To: Bruce Richardson Thread-Topic: [dpdk-dev] [PATCH] enicpmd: build changes for FreeBSD Thread-Index: AQHQh9zlymEohBPOq0202QZmFYsPAJ1vbHMAgAEj4AA= Date: Thu, 7 May 2015 03:43:39 +0000 Message-ID: References: <1430903460-5480-1-git-send-email-ssujith@cisco.com> <20150506154903.GA11808@bricha3-MOBL3> In-Reply-To: <20150506154903.GA11808@bricha3-MOBL3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.3.9.131030 x-originating-ip: [10.127.150.73] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] enicpmd: build changes for FreeBSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 May 2015 03:43:41 -0000 On 06/05/15 9:19 pm, "Bruce Richardson" wrote: >On Wed, May 06, 2015 at 02:41:00PM +0530, Sujith Sankar wrote: >> This patch adds the changes required to build enic for FreeBSD >>=20 > >Hi, > >I see no issues with this patch, but I suggest the description for it >should >be changed. There is no actual build problem or error with the enic (at >least >not that I can see), it builds fine with gcc and clang currently. This >patch >instead adds support for the enic to the nic_uio driver so the enic can be >"used", not just "built" on FreeBSD. Correct? Bruce, I fully agree with you. I shall change the description and re-submit the patch. Thanks ! -Sujith > >Other than that description reworking: > >Acked-by: Bruce Richardson > >> Signed-off-by: Sujith Sankar >> --- >> lib/librte_eal/bsdapp/nic_uio/nic_uio.c | 1 + >> lib/librte_eal/common/include/rte_pci_dev_ids.h | 17 +++++++++++++++++ >> 2 files changed, 18 insertions(+) >>=20 >> diff --git a/lib/librte_eal/bsdapp/nic_uio/nic_uio.c >>b/lib/librte_eal/bsdapp/nic_uio/nic_uio.c >> index 5ae8560..e649e32 100644 >> --- a/lib/librte_eal/bsdapp/nic_uio/nic_uio.c >> +++ b/lib/librte_eal/bsdapp/nic_uio/nic_uio.c >> @@ -113,6 +113,7 @@ struct pci_bdf { >> #define RTE_PCI_DEV_ID_DECL_I40EVF(vend, dev) {vend, dev}, >> #define RTE_PCI_DEV_ID_DECL_VIRTIO(vend, dev) {vend, dev}, >> #define RTE_PCI_DEV_ID_DECL_VMXNET3(vend, dev) {vend, dev}, >> +#define RTE_PCI_DEV_ID_DECL_ENIC(vend, dev) {vend, dev}, >> =20 >> const struct device devices[] =3D { >> #include >> diff --git a/lib/librte_eal/common/include/rte_pci_dev_ids.h >>b/lib/librte_eal/common/include/rte_pci_dev_ids.h >> index 21d2eed..5d1b285 100644 >> --- a/lib/librte_eal/common/include/rte_pci_dev_ids.h >> +++ b/lib/librte_eal/common/include/rte_pci_dev_ids.h >> @@ -140,6 +140,10 @@ >> #define RTE_PCI_DEV_ID_DECL_FM10KVF(vend, dev) >> #endif >> =20 >> +#ifndef RTE_PCI_DEV_ID_DECL_ENIC >> +#define RTE_PCI_DEV_ID_DECL_ENIC(vend, dev) >> +#endif >> + >> #ifndef PCI_VENDOR_ID_INTEL >> /** Vendor ID used by Intel devices */ >> #define PCI_VENDOR_ID_INTEL 0x8086 >> @@ -155,6 +159,11 @@ >> #define PCI_VENDOR_ID_VMWARE 0x15AD >> #endif >> =20 >> +#ifndef PCI_VENDOR_ID_CISCO >> +/** Vendor ID used by Cisco VIC devices */ >> +#define PCI_VENDOR_ID_CISCO 0x1137 >> +#endif >> + >> /******************** Physical EM devices from e1000_hw.h >>********************/ >> =20 >> #define E1000_DEV_ID_82542 0x1000 >> @@ -548,6 +557,14 @@ RTE_PCI_DEV_ID_DECL_VMXNET3(PCI_VENDOR_ID_VMWARE, >>VMWARE_DEV_ID_VMXNET3) >> =20 >> RTE_PCI_DEV_ID_DECL_FM10KVF(PCI_VENDOR_ID_INTEL, FM10K_DEV_ID_VF) >> =20 >> +/****************** Cisco VIC devices ******************/ >> + >> +#define PCI_DEVICE_ID_CISCO_VIC_ENET 0x0043 /* ethernet vnic >>*/ >> +#define PCI_DEVICE_ID_CISCO_VIC_ENET_VF 0x0071 /* enet SRIOV VF >>*/ >> + >> +RTE_PCI_DEV_ID_DECL_ENIC(PCI_VENDOR_ID_CISCO, >>PCI_DEVICE_ID_CISCO_VIC_ENET) >> +RTE_PCI_DEV_ID_DECL_ENIC(PCI_VENDOR_ID_CISCO, >>PCI_DEVICE_ID_CISCO_VIC_ENET_VF) >> + >> /* >> * Undef all RTE_PCI_DEV_ID_DECL_* here. >> */ >> --=20 >> 1.9.1 >>=20