From: "Wiles, Keith" <keith.wiles@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] Remove NO_AUTOLIBS option
Date: Tue, 12 May 2015 19:18:58 +0000 [thread overview]
Message-ID: <D177BC0E.1FF0B%keith.wiles@intel.com> (raw)
In-Reply-To: <18120312.yv66er7Y4a@xps13>
On 5/12/15, 8:07 AM, "Thomas Monjalon" <thomas.monjalon@6wind.com> wrote:
>2015-05-01 09:29, Keith Wiles:
>> NO_AUTOLIBS is not required as it was not used or defined in the config
>>files.
>>
>> Signed-off-by: Keith Wiles <keith.wiles@intel.com>
>> ---
>> mk/rte.app.mk | 5 -----
>> 1 file changed, 5 deletions(-)
>
>Thanks Keith for trying to clean it, but removing half of an obsolete
>feature
>is not a real clean-up ;)
>When running "git grep NO_AUTOLIBS", it will return results in
>doc/guides/prog_guide
Sorry, did not find that one in the docs. I thought I had searched for
other locations.
>
>I fixed the doc and manually applied your patch based on your _LDLIBS-y
>patch.
>Maybe I'm too kind, I know people who whould refuse this patch :)
>
>Sorry for being long here, but I want to show the work done when applying
>patches and I want to ask: is it a good thing to manually fix patches in
>order
>to speed-up the process or should it be more strict?
prev parent reply other threads:[~2015-05-12 19:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-01 14:29 Keith Wiles
2015-05-12 13:07 ` Thomas Monjalon
2015-05-12 19:18 ` Wiles, Keith [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D177BC0E.1FF0B%keith.wiles@intel.com \
--to=keith.wiles@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).