From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <keith.wiles@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 650075A45
 for <dev@dpdk.org>; Thu, 14 May 2015 17:14:35 +0200 (CEST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by orsmga103.jf.intel.com with ESMTP; 14 May 2015 08:14:34 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.13,429,1427785200"; d="scan'208";a="725941811"
Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5])
 by fmsmga002.fm.intel.com with ESMTP; 14 May 2015 08:14:33 -0700
Received: from orsmsx151.amr.corp.intel.com (10.22.226.38) by
 ORSMSX107.amr.corp.intel.com (10.22.240.5) with Microsoft SMTP Server (TLS)
 id 14.3.224.2; Thu, 14 May 2015 08:14:33 -0700
Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by
 ORSMSX151.amr.corp.intel.com (10.22.226.38) with Microsoft SMTP Server (TLS)
 id 14.3.224.2; Thu, 14 May 2015 08:14:33 -0700
Received: from fmsmsx113.amr.corp.intel.com ([169.254.13.51]) by
 FMSMSX102.amr.corp.intel.com ([169.254.10.250]) with mapi id 14.03.0224.002;
 Thu, 14 May 2015 08:14:33 -0700
From: "Wiles, Keith" <keith.wiles@intel.com>
To: Olivier MATZ <olivier.matz@6wind.com>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH v9 1/2] mk:Simplify the ifdefs in the makefile
Thread-Index: AQHQjZrjtoS/qRxWp0ChAO6JP6SCmp173b8A///Z7IA=
Date: Thu, 14 May 2015 15:14:33 +0000
Message-ID: <D17A25A7.201E1%keith.wiles@intel.com>
References: <1431386066-6147-1-git-send-email-keith.wiles@intel.com>
 <1431534934-15278-1-git-send-email-keith.wiles@intel.com>
 <55549578.1020009@6wind.com>
In-Reply-To: <55549578.1020009@6wind.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.254.90.134]
Content-Type: text/plain; charset="us-ascii"
Content-ID: <5264D29DF1F2A94F8FD2281B595CBA20@intel.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v9 1/2] mk:Simplify the ifdefs in the makefile
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 14 May 2015 15:14:35 -0000



On 5/14/15, 7:30 AM, "Olivier MATZ" <olivier.matz@6wind.com> wrote:

>Hi,
>
>On 05/13/2015 06:35 PM, Keith Wiles wrote:
>> Simplify the ifdefs in rte.app.mk to make the code more
>> readable and maintainable by introducing a internal
>> _LDLIBS-y variable to build up the LDLIBS variable.
>>=20
>> The new internal variable _LDLIBS-y should not be
>> used outside of the rte.app.mk file.
>>=20
>> Signed-off-by: Keith Wiles <keith.wiles@intel.com>
>> ---
>>  mk/rte.app.mk | 243
>>+++++++++++++++-------------------------------------------
>>  1 file changed, 61 insertions(+), 182 deletions(-)
>>=20
>> diff --git a/mk/rte.app.mk b/mk/rte.app.mk
>> index af8a1b0..1a2043a 100644
>> --- a/mk/rte.app.mk
>> +++ b/mk/rte.app.mk
>> [...]
>> =20
>> -LDLIBS +=3D $(CPU_LDLIBS)
>> +LDLIBS +=3D $(_LDLIBS-y) $(CPU_LDLIBS) $(EXTRA_LDLIBS)
>> =20
>>  .PHONY: all
>>  all: install
>
>
>You are still adding EXTRA_LDLIBS in a patch called "simplify the
>ifdefs".

I did have them split correctly and its my bad I somehow did not get then
committed correctly.

>
>A good idea before sending a new version of a patch on the mailing
>list is to check the list of the modifications that were discussed.
>Then this list can be added in the cover letter or after the "---"
>marker of your patch, allowing the reviewers to better understand
>what changed in this version.
>
>Regards,
>Olivier