From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alln-iport-7.cisco.com (alln-iport-7.cisco.com [173.37.142.94]) by dpdk.org (Postfix) with ESMTP id 8E7935A35 for ; Thu, 21 May 2015 03:53:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1822; q=dns/txt; s=iport; t=1432173196; x=1433382796; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=IrnL+Z1WaynVCdck7P1wvRba9AGApq1ts6AsgS4XCv8=; b=XGGVO096HsQ+XFc0lRjA6Dm1HiKxvzmNes8mOfKgCYo3HdHnLyuY0MU6 58k2LVJA92mCDXXWH6y4FBA6YGquLy96az1BHNafFE/6eLjEP5Tn3PxIb xvGWmO4tctkfNhC82F4BX07dR1LaEoppqBpzFVrWob714vDsXcowCsAaw s=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0D7AwBNOl1V/4YNJK1cgxCBMgbDVgmHUQKBPTgUAQEBAQEBAYEKhCIBAQEDASdSEAIBCBEDAQIBLjIdCAIEDgWIJAjPQgEBAQEBAQEBAQEBAQEBAQEBAQEZizqFBQcGhCcBBIt5hneLAJcUI2GBKRyBUm+BRoEBAQEB X-IronPort-AV: E=Sophos;i="5.13,466,1427760000"; d="scan'208";a="151878375" Received: from alln-core-12.cisco.com ([173.36.13.134]) by alln-iport-7.cisco.com with ESMTP; 21 May 2015 01:52:59 +0000 Received: from xhc-aln-x13.cisco.com (xhc-aln-x13.cisco.com [173.36.12.87]) by alln-core-12.cisco.com (8.14.5/8.14.5) with ESMTP id t4L1qwUl001521 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Thu, 21 May 2015 01:52:58 GMT Received: from xmb-aln-x07.cisco.com ([169.254.2.29]) by xhc-aln-x13.cisco.com ([173.36.12.87]) with mapi id 14.03.0195.001; Wed, 20 May 2015 20:52:58 -0500 From: "Sujith Sankar (ssujith)" To: Stephen Hemminger Thread-Topic: [dpdk-dev] [PATCH 1/2] enic: silence log message Thread-Index: AQHQciLCZ98PMxKQkk+ZwCREEtQArZ2DpyqAgAJZGQD//7k8gIAA4/iA Date: Thu, 21 May 2015 01:52:58 +0000 Message-ID: References: <1428514670-7982-1-git-send-email-stephen@networkplumber.org> <1428514670-7982-2-git-send-email-stephen@networkplumber.org> <20150519100853.GB11036@bricha3-MOBL3> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.3.9.131030 x-originating-ip: [10.127.150.73] Content-Type: text/plain; charset="iso-8859-1" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" , Stephen Hemminger Subject: Re: [dpdk-dev] [PATCH 1/2] enic: silence log message X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 May 2015 01:53:17 -0000 Stephen, The enic debug flag is off by default. So it is going to print the version only if the user wants it to. Isn=B9t that fine? Thanks, -Sujith=20 From: Stephen Hemminger Date: Wednesday, 20 May 2015 11:17 pm To: "Sujith Sankar (ssujith)" Cc: Bruce Richardson , "dev@dpdk.org" , Stephen Hemminger Subject: Re: [dpdk-dev] [PATCH 1/2] enic: silence log message Other drivers are quiet, why does this one need to be noisy On Wed, May 20, 2015 at 9:30 AM, Sujith Sankar (ssujith) wrote: On 19/05/15 3:38 pm, "Bruce Richardson" wrote: >On Wed, Apr 08, 2015 at 10:37:49AM -0700, Stephen Hemminger wrote: >> From: Stephen Hemminger >> >> Silence is normal. drivers should speak only when spoken to and not >> be chatty. >> >> Signed-off-by: Stephen Hemminger > >Acked-by: Bruce Richardson > >> --- >> lib/librte_pmd_enic/enic_main.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/lib/librte_pmd_enic/enic_main.c >>b/lib/librte_pmd_enic/enic_main.c >> index 0892b3e..508621e 100644 >> --- a/lib/librte_pmd_enic/enic_main.c >> +++ b/lib/librte_pmd_enic/enic_main.c >> @@ -1048,8 +1048,6 @@ int enic_probe(struct enic *enic) >> struct rte_pci_device *pdev =3D enic->pdev; >> int err =3D -1; >> >> - dev_debug(enic, " Initializing ENIC PMD version %s\n", >>DRV_VERSION); >> - It would be good to retain this under RTE_LIBRTE_ENIC_DEBUG. >> enic->bar0.vaddr =3D (void *)pdev->mem_resource[0].addr; >> enic->bar0.len =3D pdev->mem_resource[0].len; >> >> -- >> 2.1.4 >>