From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 833461DB1 for ; Wed, 27 May 2015 16:40:00 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP; 27 May 2015 07:39:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,506,1427785200"; d="scan'208";a="498936417" Received: from orsmsx108.amr.corp.intel.com ([10.22.240.6]) by FMSMGA003.fm.intel.com with ESMTP; 27 May 2015 07:39:59 -0700 Received: from orsmsx159.amr.corp.intel.com (10.22.240.24) by ORSMSX108.amr.corp.intel.com (10.22.240.6) with Microsoft SMTP Server (TLS) id 14.3.224.2; Wed, 27 May 2015 07:39:58 -0700 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by ORSMSX159.amr.corp.intel.com (10.22.240.24) with Microsoft SMTP Server (TLS) id 14.3.224.2; Wed, 27 May 2015 07:39:58 -0700 Received: from fmsmsx113.amr.corp.intel.com ([169.254.13.213]) by FMSMSX102.amr.corp.intel.com ([169.254.10.68]) with mapi id 14.03.0224.002; Wed, 27 May 2015 07:39:58 -0700 From: "Wiles, Keith" To: =?iso-8859-1?Q?Simon_K=E5gstr=F6m?= , "dev@dpdk.org" Thread-Topic: [dpdk-dev] Small request for patch review in DPDK Thread-Index: AQHQmEJcq6EGilLlw0ix/iMIaQMp152QBwCA Date: Wed, 27 May 2015 14:39:57 +0000 Message-ID: References: <55655D3D.8070208@netinsight.net> In-Reply-To: <55655D3D.8070208@netinsight.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.23.28] Content-Type: text/plain; charset="iso-8859-1" Content-ID: <0F2579CDCE58954495B050775A4E6222@intel.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] Small request for patch review in DPDK X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 May 2015 14:40:01 -0000 On 5/27/15, 12:59 AM, "Simon K=E5gstr=F6m" wrote: >Hi! > >As a well-meaning outsider submitting small patches to DPDK, I'd very >much appreciate help from the community with review and comments. Since >I'm a DPDK newbie, the patches might be incorrect or wrong in some other >way, so I think it's even more important with reviews for people like me. > >But I can't help getting this nagging feeling that the patches are >actually lost in the flood of mail to the DPDK mailing list, since I >haven't gotten any reaction to any of the three patches I've sent the >last month. > > >The patches in question are > > kni: Add set_rx_mode callback to handle multicast groups > rte_reorder: Allow sequence numbers > 0 as starting point > eal_common_options: Allow combining -m and --no-huge > >so if someone feels like mining their DPDK mail box, please review if >you have the time and knowledge about the area :-) > > >And I can't help thinking that maybe github pull requests would be >harder to miss (or at least easier to find after a few weeks of other >traffic). Do not open that can of worms :-) But I agree with you. > >// Simon