From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id DC76C5A50 for ; Thu, 28 May 2015 15:10:04 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP; 28 May 2015 06:10:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,513,1427785200"; d="scan'208";a="733094874" Received: from orsmsx110.amr.corp.intel.com ([10.22.240.8]) by fmsmga002.fm.intel.com with ESMTP; 28 May 2015 06:10:03 -0700 Received: from orsmsx151.amr.corp.intel.com (10.22.226.38) by ORSMSX110.amr.corp.intel.com (10.22.240.8) with Microsoft SMTP Server (TLS) id 14.3.224.2; Thu, 28 May 2015 06:10:03 -0700 Received: from fmsmsx106.amr.corp.intel.com (10.18.124.204) by ORSMSX151.amr.corp.intel.com (10.22.226.38) with Microsoft SMTP Server (TLS) id 14.3.224.2; Thu, 28 May 2015 06:10:03 -0700 Received: from fmsmsx113.amr.corp.intel.com ([169.254.13.213]) by FMSMSX106.amr.corp.intel.com ([169.254.5.98]) with mapi id 14.03.0224.002; Thu, 28 May 2015 06:10:02 -0700 From: "Wiles, Keith" To: =?iso-8859-1?Q?Simon_K=E5gstr=F6m?= , "dev@dpdk.org" Thread-Topic: [dpdk-dev] DPDK: Proposal for a patch patch-test integration tree Thread-Index: AQHQmL6Rj4kcHGTwHUGMtz8zINKvx52RajCAgAAVDIA= Date: Thu, 28 May 2015 13:10:01 +0000 Message-ID: References: <55662DAF.3000909@redhat.com> <5566BBAF.1040408@netinsight.net> In-Reply-To: <5566BBAF.1040408@netinsight.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.23.28] Content-Type: text/plain; charset="iso-8859-1" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] DPDK: Proposal for a patch patch-test integration tree X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 May 2015 13:10:05 -0000 On 5/28/15, 1:54 AM, "Simon K=E5gstr=F6m" wrote: >I spot a can of worms to be opened here :-) > >On 2015-05-27 22:48, Thomas F Herbert wrote: >> Work Flow and Process: >>=20 >> All patches will be taken from from public submissions to dpdk-dev.org >> scraped from dpdk patchwork. Patches will be applied to the patch-test >> tree and tested against HEAD as they are received. The feedback from the >> testing will be provided to the community. The patch-test tree will >> periodically be git pull'ed from dpdk. >>=20 >> Longer term goal: >>=20 >> Initially, the patches will be applied along with some simple smoke >> tests. The longer term goal is to automate this process, apply more >> extensive tests and post the results in dpdk patchwork, >> http://dpdk.org/dev/patchwork/project/dpdk/list/ which would have an >> accompanying mailing list for distribution of a results summary of the >> tests. > >Actually, github and services such as travis-ci and coveralls already >provide this functionality (with very little setup). So when someone >sends a pull request, the continuous integration service travis-ci will >notice it, and start a build and (possibly) run a test suite on the code >- with the patches applied. > >If code coverage is collected in the process [1], it's uploaded to the >coveralls site. Both travis-ci and coveralls will add a note to the pull >request saying something like "Build failed with this patch, be careful" >or "Build OK, everything is fine" and "Coverage decreased with 5% with >this patch" etc etc. > >Of course, github provides an API so it's entirely possible to add your >own continuous integration support with the same functionality as >travis-ci (customized for DPDK). > > > >So before venturing into implementing something like this, I think the >DPDK project should at least consider the existing alternatives. Using the above process seems very reasonable and we already have github account we can mirror the code and run these processes. This gives us a more standard method instead of a home grown method, but as Simon states we could enhance the process via the API. I may have bruised a few worms here, so very sorry :-) > >And with that, I close the can of worms again. I hope no worms were hurt >in the process! :-) > >// Simon > >[1] https://github.com/SimonKagstrom/kcov - yes my personal project