From: "Wiles, Keith" <keith.wiles@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [RFC PATCH] eal:Add new API for parsing args at rte_eal_init time
Date: Wed, 3 Jun 2015 19:43:21 +0000 [thread overview]
Message-ID: <D194C283.217F3%keith.wiles@intel.com> (raw)
In-Reply-To: <3638515.Z9q363AFg3@xps13>
On 6/3/15, 2:24 PM, "Thomas Monjalon" <thomas.monjalon@6wind.com> wrote:
>Hi Keith,
>
>2015-06-03 13:49, Keith Wiles:
>> Signed-off-by: Keith Wiles <keith.wiles@intel.com>
>> ---
>> lib/librte_eal/bsdapp/eal/eal.c | 20 ++++++++++++++++++++
>> lib/librte_eal/common/include/rte_eal.h | 32
>>++++++++++++++++++++++++++++++++
>> 2 files changed, 52 insertions(+)
>
>These comments would be useful:
>As a RFC patch, it is not complete yet.
>This new API may be used for <reason>.
I was going to add this to the real patch:
The new API is to reduce some of the clutter in the applications. Most of
the applications need to do the following:
int ret = rte_eal_init(argc, argv);
if ( ret < 0 )
rte_exit(EXIT_FAILURE, "rte_eal_init: failed!");
argc -= ret;
argv += ret;
ret = parse_args(argc, argv);
if ( ret < 0 )
rte_exit(EXIT_FAILURE, "parse_args:failed!");
With this new API:
int ret = rte_eal_init_parse(argc, argv, parse_args);
if ( ret < 0 )
rte_exit(EXIT_FAILURE, "rte_eal_init_parse: Failed!");
>
next prev parent reply other threads:[~2015-06-03 19:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-03 18:49 Keith Wiles
2015-06-03 19:24 ` Thomas Monjalon
2015-06-03 19:43 ` Wiles, Keith [this message]
2015-06-04 0:12 ` Stephen Hemminger
2015-06-04 11:50 ` Wiles, Keith
2015-06-04 13:55 ` Neil Horman
2015-06-04 14:27 ` Wiles, Keith
2015-06-04 14:43 ` David Marchand
2015-06-04 14:51 ` Wiles, Keith
2015-06-04 14:55 ` Wiles, Keith
2015-06-04 14:47 ` Stephen Hemminger
2015-06-04 16:51 ` Thomas F Herbert
2015-06-04 21:27 ` Chilikin, Andrey
2015-06-05 6:01 ` Simon Kågström
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D194C283.217F3%keith.wiles@intel.com \
--to=keith.wiles@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).