From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <keith.wiles@intel.com> Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 0B306C388 for <dev@dpdk.org>; Thu, 4 Jun 2015 16:51:04 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP; 04 Jun 2015 07:51:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,553,1427785200"; d="scan'208";a="740960262" Received: from orsmsx103.amr.corp.intel.com ([10.22.225.130]) by orsmga002.jf.intel.com with ESMTP; 04 Jun 2015 07:51:03 -0700 Received: from orsmsx152.amr.corp.intel.com (10.22.226.39) by ORSMSX103.amr.corp.intel.com (10.22.225.130) with Microsoft SMTP Server (TLS) id 14.3.224.2; Thu, 4 Jun 2015 07:51:03 -0700 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by ORSMSX152.amr.corp.intel.com (10.22.226.39) with Microsoft SMTP Server (TLS) id 14.3.224.2; Thu, 4 Jun 2015 07:51:03 -0700 Received: from fmsmsx113.amr.corp.intel.com ([169.254.13.213]) by fmsmsx117.amr.corp.intel.com ([169.254.3.17]) with mapi id 14.03.0224.002; Thu, 4 Jun 2015 07:51:02 -0700 From: "Wiles, Keith" <keith.wiles@intel.com> To: David Marchand <david.marchand@6wind.com> Thread-Topic: [dpdk-dev] [RFC PATCH] eal:Add new API for parsing args at rte_eal_init time Thread-Index: AQHQnltA/wkwK4V9H0iqXqFk9uBgcZ2cXhyAgAB20AD//7UYAIAAWCQA//+uZgA= Date: Thu, 4 Jun 2015 14:51:02 +0000 Message-ID: <D195CFC8.218EB%keith.wiles@intel.com> References: <1433357393-54434-1-git-send-email-keith.wiles@intel.com> <20150603171255.545e0df8@urahara> <D195A551.21883%keith.wiles@intel.com> <20150604135542.GC24585@hmsreliant.think-freely.org> <D195C831.218BA%keith.wiles@intel.com> <CALwxeUugo_WbFcvBfgq17QiUGwwetO3wTRjNHEHmT385TkTb3A@mail.gmail.com> In-Reply-To: <CALwxeUugo_WbFcvBfgq17QiUGwwetO3wTRjNHEHmT385TkTb3A@mail.gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.252.134.161] Content-Type: text/plain; charset="us-ascii" Content-ID: <CC784F1F9066C44C991518CC9A6377D1@intel.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" <dev@dpdk.org> Subject: Re: [dpdk-dev] [RFC PATCH] eal:Add new API for parsing args at rte_eal_init time X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 04 Jun 2015 14:51:05 -0000 From: David Marchand <david.marchand@6wind.com<mailto:david.marchand@6wind.= com>> Date: Thursday, June 4, 2015 at 9:43 AM To: Keith Wiles <keith.wiles@intel.com<mailto:keith.wiles@intel.com>> Cc: Neil Horman <nhorman@tuxdriver.com<mailto:nhorman@tuxdriver.com>>, "dev= @dpdk.org<mailto:dev@dpdk.org>" <dev@dpdk.org<mailto:dev@dpdk.org>> Subject: Re: [dpdk-dev] [RFC PATCH] eal:Add new API for parsing args at rte= _eal_init time On Thu, Jun 4, 2015 at 4:27 PM, Wiles, Keith <keith.wiles@intel.com<mailto:= keith.wiles@intel.com>> wrote: Hi Neil and Stephen, I agree this is not saving instructions and adding performance, but of code clutter and providing a layered model for the developer. The rte_eal_init() routine still exists and I was not trying to remove that API only layer a convenient API for common constructs. > >Its not a bad addition, I'm just not sure its worth having to take on the >additional API surface to include. I'd be more supportive if you could >enhance >the function to allow the previously mentioned before/after flexibiilty. >Then >we could just deprecate rte_eal_init as an API call entirely, and use this >instead. I can see we can create an API to add support for doing the applications args first or after, but would that even be acceptable? What's the point ? Adding stuff just for saving lines ? Are you serious about this ? Wow, OK dropped! -- David Marchand