From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id AFEF15A8C for ; Fri, 17 Jul 2015 13:06:03 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP; 17 Jul 2015 04:06:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,495,1432623600"; d="scan'208";a="525880909" Received: from orsmsx110.amr.corp.intel.com ([10.22.240.8]) by FMSMGA003.fm.intel.com with ESMTP; 17 Jul 2015 04:06:02 -0700 Received: from orsmsx151.amr.corp.intel.com (10.22.226.38) by ORSMSX110.amr.corp.intel.com (10.22.240.8) with Microsoft SMTP Server (TLS) id 14.3.224.2; Fri, 17 Jul 2015 04:06:01 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by ORSMSX151.amr.corp.intel.com (10.22.226.38) with Microsoft SMTP Server (TLS) id 14.3.224.2; Fri, 17 Jul 2015 04:06:01 -0700 Received: from fmsmsx113.amr.corp.intel.com ([169.254.13.28]) by FMSMSX109.amr.corp.intel.com ([169.254.15.204]) with mapi id 14.03.0224.002; Fri, 17 Jul 2015 04:06:00 -0700 From: "Wiles, Keith" To: Thomas Monjalon , Stephen Hemminger , "Lu, Wenzhuo" Thread-Topic: [dpdk-dev] igb PMD should set the default tx wthresh correctly. Thread-Index: AQHQwCspfRCKZqBdz0SdwTGXaiq8YJ3fa14AgABbDACAAEB7gA== Date: Fri, 17 Jul 2015 11:06:00 +0000 Message-ID: References: <20150716101650.45c0e25a@urahara> <6A0DE07E22DDAD4C9103DF62FEBC0909CFAAE6@shsmsx102.ccr.corp.intel.com> <20150716194920.3710f25e@urahara> <1679490.KK3tNg9jEu@xps13> In-Reply-To: <1679490.KK3tNg9jEu@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.237.220.91] Content-Type: text/plain; charset="us-ascii" Content-ID: <428FDF0F8C23424FA0F979C9E1B4E281@intel.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] igb PMD should set the default tx wthresh correctly. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jul 2015 11:06:04 -0000 On 7/17/15, 9:15 AM, "dev on behalf of Thomas Monjalon" wrote: >2015-07-16 19:49, Stephen Hemminger: >> On Fri, 17 Jul 2015 00:52:09 +0000 >> "Lu, Wenzhuo" wrote: >>=20 >> > Hi Stephen, >> > I don't think there's a conflict. The message just reminder us that >>we can adjust the values to achieve better performance. >> > I saw ixgbe and i40e also use 0 as the same default value. To my >>opinion, it's good to keep the same behavior. >> > Thanks. >>=20 >> In my opnion, no application should have to make special case setup >> for each device type. Having to have a table that lists all the >>parameters >> for each device name is not supportable or scaleable. >>=20 >> The DPDK started out as "lets do benchmarks fast" but as a production >> toolkit it needs to stop having this kind of thing. >>=20 >> The message shows up to the end-user, who thinks it is a driver bug. >> The "us" is now real customers not DPDK developers. > >+1 to have better default values and less scary messages. +1 I agree we should have default values. The scary message is for debugging only in the best of cases and just wrong for the normal case. >