Re: [dpdk-dev] [PATCH] mbuf: fix tunnel flags check

["Sanford, Robert" <rsanford@akamai.com>]

I just noticed a few minor typos in comments:

diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
index 917dd59..6352c32 100644
--- a/lib/librte_mbuf/rte_mbuf.h
+++ b/lib/librte_mbuf/rte_mbuf.h
@@ -680,14 +680,14 @@ extern "C" {
 /**
  * Check if the (outer) L3 header is IPv4. To avoid comparing IPv4 types
one by
  * one, bit 4 is selected to be used for IPv4 only. Then checking bit 4
can
- * determin if it is an IPV4 packet.
+ * determine if it is an IPV4 packet.
  */
 #define  RTE_ETH_IS_IPV4_HDR(ptype) ((ptype) & RTE_PTYPE_L3_IPV4)

 
 /**
- * Check if the (outer) L3 header is IPv4. To avoid comparing IPv4 types
one by
- * one, bit 6 is selected to be used for IPv4 only. Then checking bit 6
can
- * determin if it is an IPV4 packet.
+ * Check if the (outer) L3 header is IPv6. To avoid comparing IPv6 types
one by
+ * one, bit 6 is selected to be used for IPv6 only. Then checking bit 6
can
+ * determine if it is an IPV6 packet.
  */
 #define  RTE_ETH_IS_IPV6_HDR(ptype) ((ptype) & RTE_PTYPE_L3_IPV6)


--
Regards,
Robert

>On Thu, Jul 16, 2015 at 01:50:12AM +0200, Thomas Monjalon wrote:
>> A packet is tunnelled if the tunnel type is identified or if it has
>> an inner part.
>> 
>> Fix also a typo in RTE_PTYPE_INNER_L3_MASK.
>> 
>> Fixes: f295a00a2b44 ("mbuf: add definitions of unified packet types")
>> 
>> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
>
>Makes sense.
>
>Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
>
>-- 
>Adrien Mazarguil
>6WIND