From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from prod-mail-xrelay02.akamai.com (prod-mail-xrelay02.akamai.com [72.246.2.14]) by dpdk.org (Postfix) with ESMTP id 073957EEF for ; Fri, 24 Jul 2015 17:06:28 +0200 (CEST) Received: from prod-mail-xrelay02.akamai.com (localhost [127.0.0.1]) by postfix.imss70 (Postfix) with ESMTP id 59F1D2923C; Fri, 24 Jul 2015 15:06:27 +0000 (GMT) Received: from prod-mail-relay06.akamai.com (prod-mail-relay06.akamai.com [172.17.120.126]) by prod-mail-xrelay02.akamai.com (Postfix) with ESMTP id 3AF402923D; Fri, 24 Jul 2015 15:06:27 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=akamai.com; s=a1; t=1437750387; bh=Z3Q0QpXB+FHQw6U+2gdVqcpLTe/IGttzobTigCF/qNk=; h=From:To:CC:Subject:Date:References:In-Reply-To:From; b=TCl9Kiy3UofezWSeU/NNZ+os8taG3tLFksO6iuRnWyROg/0OikHjjZwE2lnhN9vyw PDeadbtAhhVvaGB6M40YlitGWsGoMJJMbu7iCeUcBxMKno+pv57a+lSkeJxnZAEdyt hhWJQeSUMPStDXXcTmvBCHD3MpTwZo0/YEstSrVU= Received: from email.msg.corp.akamai.com (ustx2ex-cas3.msg.corp.akamai.com [172.27.25.32]) by prod-mail-relay06.akamai.com (Postfix) with ESMTP id 1FAB02030; Fri, 24 Jul 2015 15:06:27 +0000 (GMT) Received: from USTX2EX-DAG1MB3.msg.corp.akamai.com (172.27.27.103) by ustx2ex-dag1mb1.msg.corp.akamai.com (172.27.27.101) with Microsoft SMTP Server (TLS) id 15.0.1076.9; Fri, 24 Jul 2015 10:06:26 -0500 Received: from USTX2EX-DAG1MB3.msg.corp.akamai.com ([172.27.27.103]) by ustx2ex-dag1mb3.msg.corp.akamai.com ([172.27.27.103]) with mapi id 15.00.1076.000; Fri, 24 Jul 2015 10:06:26 -0500 From: "Sanford, Robert" To: Adrien Mazarguil , Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH] mbuf: fix tunnel flags check Thread-Index: AQHQv1kwD4fnP0eLFUyvyY4hxGOzDp3pHcKAgAG46wA= Date: Fri, 24 Jul 2015 15:06:25 +0000 Message-ID: References: <1437004212-31646-1-git-send-email-thomas.monjalon@6wind.com> <20150723084817.GG4924@6wind.com> In-Reply-To: <20150723084817.GG4924@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.4.3.140616 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [172.19.132.86] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] mbuf: fix tunnel flags check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jul 2015 15:06:28 -0000 I just noticed a few minor typos in comments: diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h index 917dd59..6352c32 100644 --- a/lib/librte_mbuf/rte_mbuf.h +++ b/lib/librte_mbuf/rte_mbuf.h @@ -680,14 +680,14 @@ extern "C" { /** * Check if the (outer) L3 header is IPv4. To avoid comparing IPv4 types one by * one, bit 4 is selected to be used for IPv4 only. Then checking bit 4 can - * determin if it is an IPV4 packet. + * determine if it is an IPV4 packet. */ #define RTE_ETH_IS_IPV4_HDR(ptype) ((ptype) & RTE_PTYPE_L3_IPV4) =20 /** - * Check if the (outer) L3 header is IPv4. To avoid comparing IPv4 types one by - * one, bit 6 is selected to be used for IPv4 only. Then checking bit 6 can - * determin if it is an IPV4 packet. + * Check if the (outer) L3 header is IPv6. To avoid comparing IPv6 types one by + * one, bit 6 is selected to be used for IPv6 only. Then checking bit 6 can + * determine if it is an IPV6 packet. */ #define RTE_ETH_IS_IPV6_HDR(ptype) ((ptype) & RTE_PTYPE_L3_IPV6) -- Regards, Robert >On Thu, Jul 16, 2015 at 01:50:12AM +0200, Thomas Monjalon wrote: >> A packet is tunnelled if the tunnel type is identified or if it has >> an inner part. >>=20 >> Fix also a typo in RTE_PTYPE_INNER_L3_MASK. >>=20 >> Fixes: f295a00a2b44 ("mbuf: add definitions of unified packet types") >>=20 >> Signed-off-by: Thomas Monjalon > >Makes sense. > >Acked-by: Adrien Mazarguil > >--=20 >Adrien Mazarguil >6WIND