From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id C503F8BA7 for ; Fri, 28 Aug 2015 21:48:30 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 28 Aug 2015 12:48:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,426,1437462000"; d="scan'208";a="793085169" Received: from orsmsx110.amr.corp.intel.com ([10.22.240.8]) by fmsmga002.fm.intel.com with ESMTP; 28 Aug 2015 12:48:15 -0700 Received: from orsmsx154.amr.corp.intel.com (10.22.226.12) by ORSMSX110.amr.corp.intel.com (10.22.240.8) with Microsoft SMTP Server (TLS) id 14.3.224.2; Fri, 28 Aug 2015 12:48:14 -0700 Received: from fmsmsx104.amr.corp.intel.com (10.18.124.202) by ORSMSX154.amr.corp.intel.com (10.22.226.12) with Microsoft SMTP Server (TLS) id 14.3.224.2; Fri, 28 Aug 2015 12:48:14 -0700 Received: from fmsmsx113.amr.corp.intel.com ([169.254.13.149]) by fmsmsx104.amr.corp.intel.com ([169.254.3.95]) with mapi id 14.03.0224.002; Fri, 28 Aug 2015 12:48:14 -0700 From: "Wiles, Keith" To: Neil Horman , "Iremonger, Bernard" Thread-Topic: [dpdk-dev] [RFC PATCH 0/6] remove pci driver from vdevs Thread-Index: AQHQ4N7ncERpSa0Th0Ct972msvY3Jp4gk4CAgADzl4CAACZEgIAAR16A Date: Fri, 28 Aug 2015 19:48:13 +0000 Message-ID: References: <1440690041-32391-1-git-send-email-bernard.iremonger@intel.com> <20150827174357.GC8113@tuxdriver.com> <8CEF83825BEC744B83065625E567D7C219F4883E@IRSMSX108.ger.corp.intel.com> <20150828103245.GB3351@hmsreliant.think-freely.org> In-Reply-To: <20150828103245.GB3351@hmsreliant.think-freely.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.255.75.27] Content-Type: text/plain; charset="Windows-1252" Content-ID: <44493324C286EE4FA46A98AB82B5D22D@intel.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [RFC PATCH 0/6] remove pci driver from vdevs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Aug 2015 19:48:31 -0000 On 8/28/15, 5:32 AM, "dev on behalf of Neil Horman" wrote: >On Fri, Aug 28, 2015 at 08:15:47AM +0000, Iremonger, Bernard wrote: >> Hi John, >>=20 >> > -----Original Message----- >> > From: John W. Linville [mailto:linville@tuxdriver.com] >> > Sent: Thursday, August 27, 2015 6:44 PM >> > To: Iremonger, Bernard >> > Cc: dev@dpdk.org >> > Subject: Re: [dpdk-dev] [RFC PATCH 0/6] remove pci driver from vdevs >> >=20 >> > On Thu, Aug 27, 2015 at 04:40:35PM +0100, Bernard Iremonger wrote: >> > > There is a dummy pci driver in the vdev PMD's at present. >> > > This RFC proposes to remove the pci driver from the vdev PMD's. >> > > Changes have been made to librte_ether to handle vdevs which do not >> > have a pci driver. >> > > >> > > The pdev PMD's should work as before with the changes to >>librte_ether >> > > The vdev PMD's which still have a pci driver should work as before >>with the >> > librte_ether changes. >> > > >> > > The following vdev PMD's have had the pci driver removed >> > > >> > > bonding PMD >> > > null PMD >> > > pcap PMD >> > > ring PMD >> >=20 >> > Any reason there is no patch for the af_packet driver? >> >=20 >> > John >>=20 >> I have just modified the Intel vdev PMD's. >> It would be best if the owners of the non Intel vdev's submitted >>patches for their drivers. >>=20 >I disagree. Its ok given that this is an RFC patch I suppose, but if you >intend >to actually propose this change for review, you need to modify all >affected >drivers in a single commit. Asking individual driver maintainers to >submit >patches to not access a struct element that is removed in a separate >patch will >by definition cause FTBFS errors. All references to the structure member >being >removed must also be eliminated in the same or a prior commit, preferably >the >former. +1, if you introduce a chance that effects other places in the code/drivers then you must also make the changes to those parts as well. It really should not be an option IMO. > >Neil > >> Regards, >>=20 >> Bernard.=20 >>=20 >> =20 >>=20 >>=20 > =8B=20 Regards, ++Keith Intel Corporation