DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Sujith Sankar (ssujith)" <ssujith@cisco.com>
To: David Marchand <david.marchand@6wind.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "John Daley \(johndale\)" <johndale@cisco.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] enic: fix allocation when not using first numa node
Date: Fri, 11 Sep 2015 08:28:19 +0000	[thread overview]
Message-ID: <D2188E78.445DA%ssujith@cisco.com> (raw)
In-Reply-To: <1441958551-29313-1-git-send-email-david.marchand@6wind.com>



On 11/09/15 1:32 pm, "David Marchand" <david.marchand@6wind.com> wrote:

>Seen by code review.
>
>If dpdk is run with memory only available on socket != 0, then enic pmd
>refuses to initialize ports as this pmd requires some memory on socket 0.
>Fix this by setting socket to SOCKET_ID_ANY, so that allocations happen on
>the caller socket.
>
>Signed-off-by: David Marchand <david.marchand@6wind.com>
>---
> drivers/net/enic/enic_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c
>index 3b8719f..46a90bd 100644
>--- a/drivers/net/enic/enic_main.c
>+++ b/drivers/net/enic/enic_main.c
>@@ -539,7 +539,7 @@ enic_alloc_consistent(__rte_unused void *priv, size_t
>size,
> 	*dma_handle = 0;
> 
> 	rz = rte_memzone_reserve_aligned((const char *)name,
>-		size, 0, 0, ENIC_ALIGN);
>+					 size, SOCKET_ID_ANY, 0, ENIC_ALIGN);
> 	if (!rz) {
> 		pr_err("%s : Failed to allocate memory requested for %s",
> 			__func__, name);
>--

Acked by: Sujith Sankar <ssujith@cisco.com>

> 
>1.9.1
>

      parent reply	other threads:[~2015-09-11  8:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-11  8:02 David Marchand
2015-09-11  8:02 ` [dpdk-dev] [PATCH 2/2] enic: fix hash creation " David Marchand
2015-09-11  8:29   ` Sujith Sankar (ssujith)
2015-10-20 19:34     ` Thomas Monjalon
2015-09-11  8:28 ` Sujith Sankar (ssujith) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D2188E78.445DA%ssujith@cisco.com \
    --to=ssujith@cisco.com \
    --cc=david.marchand@6wind.com \
    --cc=dev@dpdk.org \
    --cc=johndale@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).