From: "Sujith Sankar (ssujith)" <ssujith@cisco.com>
To: David Marchand <david.marchand@6wind.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "John Daley \(johndale\)" <johndale@cisco.com>
Subject: Re: [dpdk-dev] [PATCH 2/2] enic: fix hash creation when not using first numa node
Date: Fri, 11 Sep 2015 08:29:04 +0000 [thread overview]
Message-ID: <D2188EC7.445DD%ssujith@cisco.com> (raw)
In-Reply-To: <1441958551-29313-2-git-send-email-david.marchand@6wind.com>
On 11/09/15 1:32 pm, "David Marchand" <david.marchand@6wind.com> wrote:
>If dpdk is run with memory only available on socket != 0, then hash
>creation will fail and flow director feature won't be available.
>Fix this by asking for allocation on caller socket.
>
>Signed-off-by: David Marchand <david.marchand@6wind.com>
>---
> drivers/net/enic/enic_clsf.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/drivers/net/enic/enic_clsf.c b/drivers/net/enic/enic_clsf.c
>index 656b25b..e7416ce 100644
>--- a/drivers/net/enic/enic_clsf.c
>+++ b/drivers/net/enic/enic_clsf.c
>@@ -61,7 +61,6 @@
> #define DEFAULT_HASH_FUNC rte_jhash
> #endif
>
>-#define SOCKET_0 0
> #define ENICPMD_CLSF_HASH_ENTRIES ENICPMD_FDIR_MAX
>
> void enic_fdir_stats_get(struct enic *enic, struct rte_eth_fdir_stats
>*stats)
>@@ -247,7 +246,7 @@ int enic_clsf_init(struct enic *enic)
> .key_len = sizeof(struct rte_eth_fdir_filter),
> .hash_func = DEFAULT_HASH_FUNC,
> .hash_func_init_val = 0,
>- .socket_id = SOCKET_0,
>+ .socket_id = SOCKET_ID_ANY,
> };
>
> enic->fdir.hash = rte_hash_create(&hash_params);
>--
Acked by: Sujith Sankar <ssujith@cisco.com>
>
>1.9.1
>
next prev parent reply other threads:[~2015-09-11 8:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-11 8:02 [dpdk-dev] [PATCH 1/2] enic: fix allocation " David Marchand
2015-09-11 8:02 ` [dpdk-dev] [PATCH 2/2] enic: fix hash creation " David Marchand
2015-09-11 8:29 ` Sujith Sankar (ssujith) [this message]
2015-10-20 19:34 ` Thomas Monjalon
2015-09-11 8:28 ` [dpdk-dev] [PATCH 1/2] enic: fix allocation " Sujith Sankar (ssujith)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D2188EC7.445DD%ssujith@cisco.com \
--to=ssujith@cisco.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=johndale@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).