From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rcdn-iport-4.cisco.com (rcdn-iport-4.cisco.com [173.37.86.75]) by dpdk.org (Postfix) with ESMTP id A95F95934 for ; Fri, 11 Sep 2015 10:29:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1270; q=dns/txt; s=iport; t=1441960146; x=1443169746; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=jbn9el1IvrBj1d4XhsprjIjoxDVnLWD49sr6SQEWrAM=; b=LxMPD1UU7Rweo9gkqp/HK+FVq6ZMXZYJXd1ig41hxMxughd2HuZhL0pu 0Ln67lZBnZDkByXhH6x3TE5LC95mAjP5KoY8M8sFH7eBfeMRaiLgo48gB 0hjpHuQ7gA8Blyk2GsKaY0FPSCZNvQNGCLiVmqVE7+CIG6YbpHVggVXhL c=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0AYAgBKj/JV/4YNJK1dgyOBPQa9LAENh3ECgU84FAEBAQEBAQGBCoQkAQEEJxM/EAIBCDYQMiUCBAENBYguy0oBAQEBAQEBAQEBAQEBAQEBAQEBAQEXi3CFDQeELAEElVYBjHmaeR8BAUKCDwEcgVRxiRqBBQEBAQ X-IronPort-AV: E=Sophos;i="5.17,511,1437436800"; d="scan'208";a="27978009" Received: from alln-core-12.cisco.com ([173.36.13.134]) by rcdn-iport-4.cisco.com with ESMTP; 11 Sep 2015 08:29:05 +0000 Received: from XCH-RCD-005.cisco.com (xch-rcd-005.cisco.com [173.37.102.15]) by alln-core-12.cisco.com (8.14.5/8.14.5) with ESMTP id t8B8T5FS000942 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Fri, 11 Sep 2015 08:29:05 GMT Received: from xch-rcd-005.cisco.com (173.37.102.15) by XCH-RCD-005.cisco.com (173.37.102.15) with Microsoft SMTP Server (TLS) id 15.0.1104.5; Fri, 11 Sep 2015 03:29:04 -0500 Received: from xhc-aln-x03.cisco.com (173.36.12.77) by xch-rcd-005.cisco.com (173.37.102.15) with Microsoft SMTP Server (TLS) id 15.0.1104.5 via Frontend Transport; Fri, 11 Sep 2015 03:29:04 -0500 Received: from xmb-aln-x07.cisco.com ([169.254.2.62]) by xhc-aln-x03.cisco.com ([173.36.12.77]) with mapi id 14.03.0248.002; Fri, 11 Sep 2015 03:29:04 -0500 From: "Sujith Sankar (ssujith)" To: David Marchand , "dev@dpdk.org" Thread-Topic: [PATCH 2/2] enic: fix hash creation when not using first numa node Thread-Index: AQHQ7Gg9YbMXGdNWo06ofSXkjEHGLp43r2GA Date: Fri, 11 Sep 2015 08:29:04 +0000 Message-ID: References: <1441958551-29313-1-git-send-email-david.marchand@6wind.com> <1441958551-29313-2-git-send-email-david.marchand@6wind.com> In-Reply-To: <1441958551-29313-2-git-send-email-david.marchand@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.3.9.131030 x-originating-ip: [173.36.7.15] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "John Daley \(johndale\)" Subject: Re: [dpdk-dev] [PATCH 2/2] enic: fix hash creation when not using first numa node X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Sep 2015 08:29:07 -0000 On 11/09/15 1:32 pm, "David Marchand" wrote: >If dpdk is run with memory only available on socket !=3D 0, then hash >creation will fail and flow director feature won't be available. >Fix this by asking for allocation on caller socket. > >Signed-off-by: David Marchand >--- > drivers/net/enic/enic_clsf.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > >diff --git a/drivers/net/enic/enic_clsf.c b/drivers/net/enic/enic_clsf.c >index 656b25b..e7416ce 100644 >--- a/drivers/net/enic/enic_clsf.c >+++ b/drivers/net/enic/enic_clsf.c >@@ -61,7 +61,6 @@ > #define DEFAULT_HASH_FUNC rte_jhash > #endif >=20 >-#define SOCKET_0 0 > #define ENICPMD_CLSF_HASH_ENTRIES ENICPMD_FDIR_MAX >=20 > void enic_fdir_stats_get(struct enic *enic, struct rte_eth_fdir_stats >*stats) >@@ -247,7 +246,7 @@ int enic_clsf_init(struct enic *enic) > .key_len =3D sizeof(struct rte_eth_fdir_filter), > .hash_func =3D DEFAULT_HASH_FUNC, > .hash_func_init_val =3D 0, >- .socket_id =3D SOCKET_0, >+ .socket_id =3D SOCKET_ID_ANY, > }; >=20 > enic->fdir.hash =3D rte_hash_create(&hash_params); >-- Acked by: Sujith Sankar >=20 >1.9.1 >