From: Alex Forster <alex@alexforster.com>
To: Alexander Duyck <alexander.duyck@gmail.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] Question about unsupported transceivers
Date: Thu, 15 Oct 2015 18:29:00 +0000 [thread overview]
Message-ID: <D2456857.29A4%alex@alexforster.com> (raw)
In-Reply-To: <561FE9A8.1010409@gmail.com>
On 10/15/15, 2:00 PM, "Alexander Duyck" <alexander.duyck@gmail.com> wrote:
>
>Your changes are a bit over-kill and actually take things in the wrong
>direction. By commenting out the whole allow_unsupported_sfp block you
>are disabling it by default. Remember the module parameter allows it,
>by removing it there is no way to enable the feature.
>
>Like I mentioned in my previous email just take a look at replacing the
>"OPTION_DISABLED" value with "OPTION_ENABLED" in the .def part of the
>structure. After that you won't need to pass the module parameter as it
>will always be enabled by default.
>
>- Alex
It's hard to see in the patch, but I basically replaced that whole option
check block with:
{
/*
* allow_unsupported_sfp - Enable/Disable support for unsupported
* and untested SFP+ modules.
*/
adapter->hw.allow_unsupported_sfp = true;
}
Alex Forster
next prev parent reply other threads:[~2015-10-15 18:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 15:43 Alex Forster
2015-10-15 16:17 ` Alexander Duyck
2015-10-15 17:13 ` Alex Forster
2015-10-15 18:00 ` Alexander Duyck
2015-10-15 18:29 ` Alex Forster [this message]
2015-10-15 19:53 ` Alexander Duyck
2015-10-19 1:06 ` Alex Forster
2015-10-19 15:08 ` Alexander Duyck
-- strict thread matches above, loose matches on Subject: below --
2015-10-13 17:22 Alex Forster
2015-10-13 18:57 ` Alex Forster
2015-10-13 20:34 ` Alexander Duyck
2015-10-15 14:46 ` Alex Forster
2015-10-15 15:30 ` Alexander Duyck
2015-10-15 15:33 ` Alex Forster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D2456857.29A4%alex@alexforster.com \
--to=alex@alexforster.com \
--cc=alexander.duyck@gmail.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).