From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rcdn-iport-5.cisco.com (rcdn-iport-5.cisco.com [173.37.86.76]) by dpdk.org (Postfix) with ESMTP id DF3F4C46C for ; Wed, 21 Oct 2015 19:22:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=5261; q=dns/txt; s=iport; t=1445448154; x=1446657754; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=LUdyDLCOYbYArxL0CzEy8gICD5Y4E7ZfphYzuxvtPHU=; b=eiZB92ows6rR8pZo+qQCQC61K9JHTJnvoETF8tiAvn4YhQ19+ubNYLc4 J1jVNDcCUC5Slv8HhG9MMeBXyJRvx00mMUYX/wHNYt8UVfTl1HNk2IZnf Bx9scxEks7TiYRAXpkEk1OjM1XtdiqyvBodOOoOV4XOhyjCMbovphzk8d I=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0D5AQCJySdW/5tdJa1dgzaBQwa5aYQhAQ2BWYYdAoFHOBQBAQEBAQEBfwuELwEBBCcTPxACAT4QMiUCBA4FiDDERQEBAQEBAQEBAQEBAQEBAQEBAQEBARiKb4YTB4QuBYc8hweHZAGNHZwhAR8BAUKCER2BVXKFPYEGAQEB X-IronPort-AV: E=Sophos;i="5.20,712,1444694400"; d="scan'208";a="39689301" Received: from rcdn-core-4.cisco.com ([173.37.93.155]) by rcdn-iport-5.cisco.com with ESMTP; 21 Oct 2015 17:22:03 +0000 Received: from XCH-ALN-001.cisco.com (xch-aln-001.cisco.com [173.36.7.11]) by rcdn-core-4.cisco.com (8.14.5/8.14.5) with ESMTP id t9LHM28k028717 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Wed, 21 Oct 2015 17:22:02 GMT Received: from xch-rcd-004.cisco.com (173.37.102.14) by XCH-ALN-001.cisco.com (173.36.7.11) with Microsoft SMTP Server (TLS) id 15.0.1104.5; Wed, 21 Oct 2015 12:21:43 -0500 Received: from xch-rcd-004.cisco.com ([173.37.102.14]) by XCH-RCD-004.cisco.com ([173.37.102.14]) with mapi id 15.00.1104.000; Wed, 21 Oct 2015 12:21:43 -0500 From: "shesha Sreenivasamurthy (shesha)" To: "dev@dpdk.org" Thread-Topic: [PATCH v4] mem: command line option to delete hugepage backing files Thread-Index: AQHRDCPPsCv1kdgqaE6W44MykhmZEZ52EC+A Date: Wed, 21 Oct 2015 17:21:43 +0000 Message-ID: References: <1445422509-33553-1-git-send-email-shesha@cisco.com> In-Reply-To: <1445422509-33553-1-git-send-email-shesha@cisco.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.24.124.83] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v4] mem: command line option to delete hugepage backing files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Oct 2015 17:22:34 -0000 When an application using huge-pages crash or exists, the hugetlbfs backing files are not cleaned up. This is a patch to clean those files. There are multi-process DPDK applications that may be benefited by those backing files. Therefore, I have made that configurable so that the application that does not need those backing files can remove them, thus not changing the current default behavior. The application itself can clean it up, however the rationale behind DPDK cleaning it up is, DPDK created it and therefore, it is better it unlinks it. Signed-off-by: Shesha Sreenivasamurthy --- lib/librte_eal/common/eal_common_options.c | 12 ++++++++++++ lib/librte_eal/common/eal_internal_cfg.h | 1 + lib/librte_eal/common/eal_options.h | 2 ++ lib/librte_eal/linuxapp/eal/eal_memory.c | 12 ++++++++++++ 4 files changed, 27 insertions(+) diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c index 1f459ac..5fe6374 100644 --- a/lib/librte_eal/common/eal_common_options.c +++ b/lib/librte_eal/common/eal_common_options.c @@ -79,6 +79,7 @@ eal_long_options[] =3D { {OPT_MASTER_LCORE, 1, NULL, OPT_MASTER_LCORE_NUM }, {OPT_NO_HPET, 0, NULL, OPT_NO_HPET_NUM }, {OPT_NO_HUGE, 0, NULL, OPT_NO_HUGE_NUM }, + {OPT_HUGE_UNLINK, 0, NULL, OPT_HUGE_UNLINK_NUM }, {OPT_NO_PCI, 0, NULL, OPT_NO_PCI_NUM }, {OPT_NO_SHCONF, 0, NULL, OPT_NO_SHCONF_NUM }, {OPT_PCI_BLACKLIST, 1, NULL, OPT_PCI_BLACKLIST_NUM }, @@ -722,6 +723,10 @@ eal_parse_common_option(int opt, const char *optarg, conf->no_hugetlbfs =3D 1; break; =20 + case OPT_HUGE_UNLINK_NUM: + conf->hugepage_unlink =3D 1; + break; + case OPT_NO_PCI_NUM: conf->no_pci =3D 1; break; @@ -856,6 +861,12 @@ eal_check_common_options(struct internal_config *internal_cfg) return -1; } =20 + if (internal_cfg->no_hugetlbfs && internal_cfg->hugepage_unlink) { + RTE_LOG(ERR, EAL, "Option --"OPT_HUGE_UNLINK" cannot " + "be specified together with --"OPT_NO_HUGE"\n"); + return -1; + } + if (rte_eal_devargs_type_count(RTE_DEVTYPE_WHITELISTED_PCI) !=3D 0 && rte_eal_devargs_type_count(RTE_DEVTYPE_BLACKLISTED_PCI) !=3D 0) { RTE_LOG(ERR, EAL, "Options blacklist (-b) and whitelist (-w) " @@ -906,6 +917,7 @@ eal_common_usage(void) " -h, --help This help\n" "\nEAL options for DEBUG use only:\n" " --"OPT_NO_HUGE" Use malloc instead of hugetlbfs\n" + " --"OPT_HUGE_UNLINK" Unlink hugepage backing file after initalization\n" " --"OPT_NO_PCI" Disable PCI\n" " --"OPT_NO_HPET" Disable HPET\n" " --"OPT_NO_SHCONF" No shared config (mmap'd files)\n" diff --git a/lib/librte_eal/common/eal_internal_cfg.h b/lib/librte_eal/common/eal_internal_cfg.h index e2ecb0d..84b075f 100644 --- a/lib/librte_eal/common/eal_internal_cfg.h +++ b/lib/librte_eal/common/eal_internal_cfg.h @@ -64,6 +64,7 @@ struct internal_config { volatile unsigned force_nchannel; /**< force number of channels */ volatile unsigned force_nrank; /**< force number of ranks */ volatile unsigned no_hugetlbfs; /**< true to disable hugetlbfs */ + volatile unsigned hugepage_unlink; /** < true to unlink backing files */ volatile unsigned xen_dom0_support; /**< support app running on Xen Dom0*/ volatile unsigned no_pci; /**< true to disable PCI */ volatile unsigned no_hpet; /**< true to disable HPET */ diff --git a/lib/librte_eal/common/eal_options.h b/lib/librte_eal/common/eal_options.h index f6714d9..745f38c 100644 --- a/lib/librte_eal/common/eal_options.h +++ b/lib/librte_eal/common/eal_options.h @@ -63,6 +63,8 @@ enum { OPT_PROC_TYPE_NUM, #define OPT_NO_HPET "no-hpet" OPT_NO_HPET_NUM, +#define OPT_HUGE_UNLINK "huge-unlink" + OPT_HUGE_UNLINK_NUM, #define OPT_NO_HUGE "no-huge" OPT_NO_HUGE_NUM, #define OPT_NO_PCI "no-pci" diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c b/lib/librte_eal/linuxapp/eal/eal_memory.c index ac2745e..c6f383b 100644 --- a/lib/librte_eal/linuxapp/eal/eal_memory.c +++ b/lib/librte_eal/linuxapp/eal/eal_memory.c @@ -348,6 +348,12 @@ map_all_hugepages(struct hugepage_file *hugepg_tbl, || (hugepage_sz =3D=3D RTE_PGSIZE_16G)) { hugepg_tbl[i].final_va =3D hugepg_tbl[i].orig_va; hugepg_tbl[i].orig_va =3D NULL; + if (internal_config.hugepage_unlink && + unlink(hugepg_tbl[i].filepath)) { + RTE_LOG(ERR, EAL, "%s(): Removing %s failed: %s\n", + __func__, hugepg_tbl[i].filepath, strerror(errno)); + return -1; + } continue; } #endif @@ -407,6 +413,12 @@ map_all_hugepages(struct hugepage_file *hugepg_tbl, } else { hugepg_tbl[i].final_va =3D virtaddr; + if (internal_config.hugepage_unlink && + unlink(hugepg_tbl[i].filepath)) { + RTE_LOG(ERR, EAL, "%s(): Removing %s failed: %s\n", + __func__, hugepg_tbl[i].filepath, strerror(errno)); + return -1; + } } =20 /* set shared flock on the file. */ --=20 1.9.1