From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 121311B18C for ; Sat, 29 Sep 2018 02:54:51 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Sep 2018 17:54:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,317,1534834800"; d="scan'208";a="94890578" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga001.jf.intel.com with ESMTP; 28 Sep 2018 17:50:49 -0700 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 28 Sep 2018 17:50:49 -0700 Received: from fmsmsx151.amr.corp.intel.com ([169.254.7.87]) by FMSMSX154.amr.corp.intel.com ([169.254.6.126]) with mapi id 14.03.0319.002; Fri, 28 Sep 2018 17:50:49 -0700 From: "Wang, Yipeng1" To: Honnappa Nagarahalli , "Richardson, Bruce" CC: "dev@dpdk.org" , "michel@digirati.com.br" , "Gobriel, Sameh" Thread-Topic: [PATCH v2 6/7] test/hash: implement extendable bucket hash test Thread-Index: AQHUUgpSFZ8VB1FepUa0+UjfyR9uLKUC+vGwgAN82fA= Date: Sat, 29 Sep 2018 00:50:48 +0000 Message-ID: References: <1536253745-133104-1-git-send-email-yipeng1.wang@intel.com> <1537550255-252066-1-git-send-email-yipeng1.wang@intel.com> <1537550255-252066-7-git-send-email-yipeng1.wang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGU3YmYyNzgtNGRhOS00YTNiLTgxODktMDEyM2NjMjNlZDgxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUzBaT3I2N3lcL0tPSHdFc0Y1Z3ltNG5WNDZrSVJOQ0E3RzV2anZyRkJvR3l5cE96Um9qT3huaEVDc1N4K21cLzBEIn0= x-originating-ip: [10.1.200.106] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 6/7] test/hash: implement extendable bucket hash test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Sep 2018 00:54:52 -0000 >-----Original Message----- >From: Honnappa Nagarahalli [mailto:Honnappa.Nagarahalli@arm.com] >Sent: Wednesday, September 26, 2018 9:24 PM >To: Wang, Yipeng1 ; Richardson, Bruce >Cc: dev@dpdk.org; michel@digirati.com.br >Subject: RE: [PATCH v2 6/7] test/hash: implement extendable bucket hash te= st > >> RETURN_IF_ERROR(handle =3D=3D NULL, "hash creation failed"); >> >> for (j =3D 0; j < ITERATIONS; j++) { >My understanding is that when extendable table feature is enabled, we will= add entries to the full capacity. Hence the >rte_hash_count and rte_hash_reset should get tested in this test case. > [Wang, Yipeng] Currently both functions are already there in the loop right= ? For V4, I've added another condition to double check if the count =3D=3D pa= ram->entries. >> @@ -1186,8 +1312,13 @@ static int test_hash_iteration(void) >> for (i =3D 0; i < ut_params.key_len; i++) >> keys[added_keys][i] =3D rte_rand() % 255; >> ret =3D rte_hash_add_key_data(handle, keys[added_keys], >> data[added_keys]); >> -if (ret < 0) >> +if (ret < 0) { >> +if (ext_table) { >> +printf("Insertion failed for ext table\n"); >> +goto err; >> +} >> break; >> +} >> } >> >I suggest we add a call to rte_hash_count() to verify that configured maxi= mum number of entries are added, will be a good corner test >for rte_hash_count as well. > [Wang, Yipeng] Please check if the newly added logic in V4 addresses your c= oncern.=20