From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 50C6D58F6 for ; Fri, 26 Oct 2018 04:04:14 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Oct 2018 19:04:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,426,1534834800"; d="scan'208";a="81007009" Received: from orsmsx105.amr.corp.intel.com ([10.22.225.132]) by fmsmga007.fm.intel.com with ESMTP; 25 Oct 2018 19:04:13 -0700 Received: from orsmsx161.amr.corp.intel.com (10.22.240.84) by ORSMSX105.amr.corp.intel.com (10.22.225.132) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 25 Oct 2018 19:04:13 -0700 Received: from orsmsx105.amr.corp.intel.com ([169.254.2.135]) by ORSMSX161.amr.corp.intel.com ([169.254.4.49]) with mapi id 14.03.0319.002; Thu, 25 Oct 2018 19:04:13 -0700 From: "Wang, Yipeng1" To: Honnappa Nagarahalli , "Richardson, Bruce" CC: "stephen@networkplumber.org" , "dev@dpdk.org" , "Gobriel, Sameh" , nd Thread-Topic: [PATCH v2 1/4] hash: fix unnecessary pause Thread-Index: AQHUbAAhGfr7c2ZV9EShnjSi2zesjKUwSaJggABu26A= Date: Fri, 26 Oct 2018 02:04:12 +0000 Message-ID: References: <1540404570-102126-1-git-send-email-yipeng1.wang@intel.com> <1540404570-102126-2-git-send-email-yipeng1.wang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDlmMmIzZGQtZTZmZS00ODIyLTk5NTQtMmNiNWQxNzc0NTUwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiM2k3VUtKcG53R2FET0gwMVI1N2M2NVkzSUhNa2dcLzcrWTNRNDdaUk54NDFoY2M0YzZ0MkpcL212dmZQK05lcGxJIn0= x-originating-ip: [10.22.254.140] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/4] hash: fix unnecessary pause X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Oct 2018 02:04:16 -0000 >-----Original Message----- >From: Honnappa Nagarahalli [mailto:Honnappa.Nagarahalli@arm.com] >> --- >> lib/librte_hash/rte_cuckoo_hash.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/lib/librte_hash/rte_cuckoo_hash.c >> b/lib/librte_hash/rte_cuckoo_hash.c >> index 0648a22..4a2647e 100644 >> --- a/lib/librte_hash/rte_cuckoo_hash.c >> +++ b/lib/librte_hash/rte_cuckoo_hash.c >> @@ -574,14 +574,14 @@ rte_hash_reset(struct rte_hash *h) >> >> /* clear the free ring */ >> while (rte_ring_dequeue(h->free_slots, &ptr) =3D=3D 0) >> - rte_pause(); >> + continue; >Minor comment: 'continue' can be removed. > [Wang, Yipeng] I did not find a pretty way to do it without coding style w= arning, e.g. add semicolon in same line... Anyone know a common way to do it in DPDK?