From: "Wang, Yipeng1" <yipeng1.wang@intel.com>
To: gavin hu <gavin.hu@arm.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "nd@arm.com" <nd@arm.com>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"jerinj@marvell.com" <jerinj@marvell.com>,
"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
"Honnappa.Nagarahalli@arm.com" <Honnappa.Nagarahalli@arm.com>,
"olivier.matz@6wind.com" <olivier.matz@6wind.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>,
"Gobriel, Sameh" <sameh.gobriel@intel.com>
Subject: Re: [dpdk-dev] [PATCH v6 3/3] hash: flush the rings instead of dequeuing one by one
Date: Wed, 9 Jan 2019 18:53:26 +0000 [thread overview]
Message-ID: <D2C4A16CA39F7F4E8E384D204491D7A661541F01@ORSMSX105.amr.corp.intel.com> (raw)
In-Reply-To: <1547033502-3167-4-git-send-email-gavin.hu@arm.com>
>-----Original Message-----
>From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of gavin hu
>Sent: Wednesday, January 9, 2019 3:32 AM
>To: dev@dpdk.org
>Cc: nd@arm.com; thomas@monjalon.net; jerinj@marvell.com; hemant.agrawal@nxp.com; Honnappa.Nagarahalli@arm.com;
>gavin.hu@arm.com; olivier.matz@6wind.com; Richardson, Bruce <bruce.richardson@intel.com>; stable@dpdk.org
>Subject: [dpdk-dev] [PATCH v6 3/3] hash: flush the rings instead of dequeuing one by one
>
>From: Gavin Hu <gavin.hu@arm.com>
>
>Within rte_hash_reset, calling a while loop to dequeue one by
>one from the ring, while not using them at all, is wasting cycles,
>The patch just flush the ring by resetting the indices can save cpu
>cycles.
>
>Fixes: b26473ff8f4a ("hash: add reset function")
>Fixes: 75706568a7eb ("hash: add extendable bucket feature")
>Cc: stable@dpdk.org
[Wang, Yipeng] I don't think it is a bug fix applicable to previous stable versions.
>
>Signed-off-by: Gavin Hu <gavin.hu@arm.com>
>Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
[Wang, Yipeng] Otherwise the hash table change looks good to me and unit test passed on my setup.
Acked-by: Yipeng Wang <yipeng1.wang@intel.com>
next prev parent reply other threads:[~2019-01-09 18:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-02 0:55 [dpdk-dev] [PATCH v4 0/3] add rte ring reset api and use it to flush a ring by hash Gavin Hu
2019-01-02 0:55 ` [dpdk-dev] [PATCH v4 1/3] test/ring: ring perf test case enhancement Gavin Hu
2019-01-02 12:49 ` Thomas Monjalon
2019-01-03 2:40 ` Gavin Hu (Arm Technology China)
2019-01-02 0:55 ` [dpdk-dev] [PATCH v4 2/3] ring: add reset api to flush the ring when not in use Gavin Hu
2019-01-02 0:55 ` [dpdk-dev] [PATCH v4 3/3] hash: flush the rings instead of dequeuing one by one Gavin Hu
2019-01-02 12:50 ` [dpdk-dev] [PATCH v4 0/3] add rte ring reset api and use it to flush a ring by hash Thomas Monjalon
2019-01-02 18:40 ` Honnappa Nagarahalli
2019-01-03 2:43 ` Gavin Hu (Arm Technology China)
2019-01-03 2:38 ` [dpdk-dev] [PATCH v5 0/3] ring test enhancement and new ring reset api and use it " gavin hu
2019-01-03 2:38 ` [dpdk-dev] [PATCH v5 1/3] test/ring: ring perf test case enhancement gavin hu
2019-01-03 7:39 ` Thomas Monjalon
2019-01-03 8:22 ` Gavin Hu (Arm Technology China)
2019-01-09 11:31 ` [dpdk-dev] [PATCH v6 0/3] ring test enhancement and new ring reset api and use it by hash gavin hu
2019-01-09 11:31 ` [dpdk-dev] [PATCH v6 1/3] test/ring: ring perf test case enhancement gavin hu
2019-09-09 5:19 ` [dpdk-dev] [PATCH v7] " Joyce Kong
2019-10-08 8:07 ` Olivier Matz
2019-10-24 7:56 ` David Marchand
2019-01-09 11:31 ` [dpdk-dev] [PATCH v6 2/3] ring: add reset API to flush the ring when not in use gavin hu
2019-01-09 11:31 ` [dpdk-dev] [PATCH v6 3/3] hash: flush the rings instead of dequeuing one by one gavin hu
2019-01-09 18:53 ` Wang, Yipeng1 [this message]
2019-01-03 2:38 ` [dpdk-dev] [PATCH v5 2/3] ring: add reset API to flush the ring when not in use gavin hu
2019-01-03 2:38 ` [dpdk-dev] [PATCH v5 3/3] hash: flush the rings instead of dequeuing one by one gavin hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D2C4A16CA39F7F4E8E384D204491D7A661541F01@ORSMSX105.amr.corp.intel.com \
--to=yipeng1.wang@intel.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=gavin.hu@arm.com \
--cc=hemant.agrawal@nxp.com \
--cc=jerinj@marvell.com \
--cc=nd@arm.com \
--cc=olivier.matz@6wind.com \
--cc=sameh.gobriel@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).