From: "Wang, Yipeng1" <yipeng1.wang@intel.com>
To: Ruifeng Wang <ruifeng.wang@arm.com>,
"jerinj@marvell.com" <jerinj@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"honnappa.nagarahalli@arm.com" <honnappa.nagarahalli@arm.com>,
"gavin.hu@arm.com" <gavin.hu@arm.com>, "nd@arm.com" <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH v2] hash: optimize signature compare by using neon intrinsic
Date: Wed, 13 Feb 2019 20:31:54 +0000 [thread overview]
Message-ID: <D2C4A16CA39F7F4E8E384D204491D7A67348F285@ORSMSX104.amr.corp.intel.com> (raw)
In-Reply-To: <20190212070104.33830-1-ruifeng.wang@arm.com>
Hi, Ruifeng,
I don't have an ARM Platform at hand to test but I gone through the code against a NEON instruction manual,
and the logic looks good to me. One small comment is the coding style for switch case, I think it is more common
to leave the braces on their own lines.
Otherwise:
Acked-by: Yipeng Wang<yipeng1.wang@intel.com>
>-----Original Message-----
>From: Ruifeng Wang [mailto:ruifeng.wang@arm.com]
>Sent: Monday, February 11, 2019 11:01 PM
>To: Wang, Yipeng1 <yipeng1.wang@intel.com>; jerinj@marvell.com
>Cc: dev@dpdk.org; honnappa.nagarahalli@arm.com; gavin.hu@arm.com; nd@arm.com; Ruifeng Wang <ruifeng.wang@arm.com>
>Subject: [PATCH v2] hash: optimize signature compare by using neon intrinsic
>
>Implemented signature compare function based on neon intrinsic.
>Hash bulk lookup had 3% - 6% performance gain after optimization.
>
>Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
>Reviewed-by: Gavin Hu <gavin.hu@arm.com>
next prev parent reply other threads:[~2019-02-13 20:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-12 7:01 Ruifeng Wang
2019-02-13 20:31 ` Wang, Yipeng1 [this message]
2019-02-14 2:40 ` Ruifeng Wang (Arm Technology China)
2019-02-25 17:52 ` Jerin Jacob Kollanukkaran
2019-03-28 18:49 ` Thomas Monjalon
2019-03-28 18:49 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D2C4A16CA39F7F4E8E384D204491D7A67348F285@ORSMSX104.amr.corp.intel.com \
--to=yipeng1.wang@intel.com \
--cc=dev@dpdk.org \
--cc=gavin.hu@arm.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=jerinj@marvell.com \
--cc=nd@arm.com \
--cc=ruifeng.wang@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).