From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 2D2BB1B202 for ; Wed, 13 Feb 2019 21:31:56 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Feb 2019 12:31:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,366,1544515200"; d="scan'208";a="320153594" Received: from orsmsx102.amr.corp.intel.com ([10.22.225.129]) by fmsmga005.fm.intel.com with ESMTP; 13 Feb 2019 12:31:56 -0800 Received: from orsmsx124.amr.corp.intel.com (10.22.240.120) by ORSMSX102.amr.corp.intel.com (10.22.225.129) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 13 Feb 2019 12:31:55 -0800 Received: from orsmsx104.amr.corp.intel.com ([169.254.4.6]) by ORSMSX124.amr.corp.intel.com ([169.254.2.98]) with mapi id 14.03.0415.000; Wed, 13 Feb 2019 12:31:55 -0800 From: "Wang, Yipeng1" To: Ruifeng Wang , "jerinj@marvell.com" CC: "dev@dpdk.org" , "honnappa.nagarahalli@arm.com" , "gavin.hu@arm.com" , "nd@arm.com" Thread-Topic: [PATCH v2] hash: optimize signature compare by using neon intrinsic Thread-Index: AQHUwqEFVfp2ErLhsU+PE2Nsa139DqXeLoYw Date: Wed, 13 Feb 2019 20:31:54 +0000 Message-ID: References: <20190212070104.33830-1-ruifeng.wang@arm.com> In-Reply-To: <20190212070104.33830-1-ruifeng.wang@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDBiZDA1OGYtOTc2OS00YWRjLWIwOTktNzI4ZGI1MjcxMWZjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiOHhZWndIelBWOXA0VDNxVzRJU1BkbVFIMVl6TU9Ucll0TSs4dUxTWDhhb3paZFZ1NzBtWnhyd2R4b0trQWpNOSJ9 x-originating-ip: [10.22.254.139] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] hash: optimize signature compare by using neon intrinsic X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Feb 2019 20:31:57 -0000 Hi, Ruifeng, I don't have an ARM Platform at hand to test but I gone through the code ag= ainst a NEON instruction manual,=20 and the logic looks good to me. One small comment is the coding style for s= witch case, I think it is more common to leave the braces on their own lines. Otherwise: Acked-by: Yipeng Wang >-----Original Message----- >From: Ruifeng Wang [mailto:ruifeng.wang@arm.com] >Sent: Monday, February 11, 2019 11:01 PM >To: Wang, Yipeng1 ; jerinj@marvell.com >Cc: dev@dpdk.org; honnappa.nagarahalli@arm.com; gavin.hu@arm.com; nd@arm.c= om; Ruifeng Wang >Subject: [PATCH v2] hash: optimize signature compare by using neon intrins= ic > >Implemented signature compare function based on neon intrinsic. >Hash bulk lookup had 3% - 6% performance gain after optimization. > >Signed-off-by: Ruifeng Wang >Reviewed-by: Gavin Hu