From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 0B6653977; Thu, 9 May 2019 21:32:49 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 May 2019 12:32:48 -0700 X-ExtLoop1: 1 Received: from orsmsx103.amr.corp.intel.com ([10.22.225.130]) by orsmga005.jf.intel.com with ESMTP; 09 May 2019 12:32:47 -0700 Received: from orsmsx104.amr.corp.intel.com ([169.254.4.183]) by ORSMSX103.amr.corp.intel.com ([169.254.5.76]) with mapi id 14.03.0415.000; Thu, 9 May 2019 12:32:47 -0700 From: "Wang, Yipeng1" To: Dharmik Thakkar , "Gobriel, Sameh" , "Richardson, Bruce" , "De Lara Guarch, Pablo" CC: "dev@dpdk.org" , "honnappa.nagarahalli@arm.com" , "zhongdahulinfan@163.com" , "stable@dpdk.org" Thread-Topic: [PATCH v4 2/3] hash: fix total entries in free key with position Thread-Index: AQHVBot0PX1j0Xm9EEC9fbMzZM390aZjLsHQ Date: Thu, 9 May 2019 19:32:46 +0000 Message-ID: References: <20190509133924.7153-1-dharmik.thakkar@arm.com> <20190509171907.14693-1-dharmik.thakkar@arm.com> <20190509171907.14693-3-dharmik.thakkar@arm.com> In-Reply-To: <20190509171907.14693-3-dharmik.thakkar@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjA2OGYzM2EtNjA3ZS00YzQxLThlOWUtOGE0YTQ1Y2NkZmU1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWmxESVpHUnlmaHJ1Y29ZRkI1N0JrTTJ6N2dlTytIVE9NXC9ldjgyQmI5cGtUeHVKTkhjdlwvYVpYOXd1b1lWdmlvIn0= x-originating-ip: [10.22.254.139] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 2/3] hash: fix total entries in free key with position X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 May 2019 19:32:50 -0000 >-----Original Message----- >From: Dharmik Thakkar [mailto:dharmik.thakkar@arm.com] >Sent: Thursday, May 9, 2019 10:19 AM >To: Wang, Yipeng1 ; Gobriel, Sameh ; Richardson, Bruce >; De Lara Guarch, Pablo >Cc: dev@dpdk.org; honnappa.nagarahalli@arm.com; zhongdahulinfan@163.com; D= harmik Thakkar ; >stable@dpdk.org >Subject: [PATCH v4 2/3] hash: fix total entries in free key with position > >In rte_hash, with current implementation, it is possible that keys >are stored at indexes greater than the number of total entries. > >Currently, in rte_hash_free_key_with_position(), due to incorrect >computation of total_entries, application cannot free keys with >indexes greater than the number of total entries. > >This patch fixes this incorrect computation of total_entries. > >Bugzilla ID: 261 >Fixes: 9d033dac7d7c ("hash: support no free on delete") >Cc: honnappa.nagarahalli@arm.com >Cc: stable@dpdk.org > >Reported-by: Linfan >Suggested-by: Linfan >Signed-off-by: Dharmik Thakkar Acked-by: Yipeng Wang From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id DD60FA0096 for ; Thu, 9 May 2019 21:32:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7D312493D; Thu, 9 May 2019 21:32:51 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 0B6653977; Thu, 9 May 2019 21:32:49 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 May 2019 12:32:48 -0700 X-ExtLoop1: 1 Received: from orsmsx103.amr.corp.intel.com ([10.22.225.130]) by orsmga005.jf.intel.com with ESMTP; 09 May 2019 12:32:47 -0700 Received: from orsmsx104.amr.corp.intel.com ([169.254.4.183]) by ORSMSX103.amr.corp.intel.com ([169.254.5.76]) with mapi id 14.03.0415.000; Thu, 9 May 2019 12:32:47 -0700 From: "Wang, Yipeng1" To: Dharmik Thakkar , "Gobriel, Sameh" , "Richardson, Bruce" , "De Lara Guarch, Pablo" CC: "dev@dpdk.org" , "honnappa.nagarahalli@arm.com" , "zhongdahulinfan@163.com" , "stable@dpdk.org" Thread-Topic: [PATCH v4 2/3] hash: fix total entries in free key with position Thread-Index: AQHVBot0PX1j0Xm9EEC9fbMzZM390aZjLsHQ Date: Thu, 9 May 2019 19:32:46 +0000 Message-ID: References: <20190509133924.7153-1-dharmik.thakkar@arm.com> <20190509171907.14693-1-dharmik.thakkar@arm.com> <20190509171907.14693-3-dharmik.thakkar@arm.com> In-Reply-To: <20190509171907.14693-3-dharmik.thakkar@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjA2OGYzM2EtNjA3ZS00YzQxLThlOWUtOGE0YTQ1Y2NkZmU1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWmxESVpHUnlmaHJ1Y29ZRkI1N0JrTTJ6N2dlTytIVE9NXC9ldjgyQmI5cGtUeHVKTkhjdlwvYVpYOXd1b1lWdmlvIn0= x-originating-ip: [10.22.254.139] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 2/3] hash: fix total entries in free key with position X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190509193246.2af4Lt6zHAoosB9P74T2lam3qmlXHJoPtA1Ssi6fhto@z> >-----Original Message----- >From: Dharmik Thakkar [mailto:dharmik.thakkar@arm.com] >Sent: Thursday, May 9, 2019 10:19 AM >To: Wang, Yipeng1 ; Gobriel, Sameh ; Richardson, Bruce >; De Lara Guarch, Pablo >Cc: dev@dpdk.org; honnappa.nagarahalli@arm.com; zhongdahulinfan@163.com; D= harmik Thakkar ; >stable@dpdk.org >Subject: [PATCH v4 2/3] hash: fix total entries in free key with position > >In rte_hash, with current implementation, it is possible that keys >are stored at indexes greater than the number of total entries. > >Currently, in rte_hash_free_key_with_position(), due to incorrect >computation of total_entries, application cannot free keys with >indexes greater than the number of total entries. > >This patch fixes this incorrect computation of total_entries. > >Bugzilla ID: 261 >Fixes: 9d033dac7d7c ("hash: support no free on delete") >Cc: honnappa.nagarahalli@arm.com >Cc: stable@dpdk.org > >Reported-by: Linfan >Suggested-by: Linfan >Signed-off-by: Dharmik Thakkar Acked-by: Yipeng Wang