From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 7197744C3 for ; Thu, 9 May 2019 21:36:46 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 May 2019 12:36:45 -0700 X-ExtLoop1: 1 Received: from orsmsx108.amr.corp.intel.com ([10.22.240.6]) by fmsmga004.fm.intel.com with ESMTP; 09 May 2019 12:36:45 -0700 Received: from orsmsx163.amr.corp.intel.com (10.22.240.88) by ORSMSX108.amr.corp.intel.com (10.22.240.6) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 9 May 2019 12:36:44 -0700 Received: from orsmsx104.amr.corp.intel.com ([169.254.4.183]) by ORSMSX163.amr.corp.intel.com ([169.254.9.163]) with mapi id 14.03.0415.000; Thu, 9 May 2019 12:36:44 -0700 From: "Wang, Yipeng1" To: Thomas Monjalon , "Gobriel, Sameh" CC: "dev@dpdk.org" , Dharmik Thakkar , "honnappa.nagarahalli@arm.com" , "zhongdahulinfan@163.com" Thread-Topic: [dpdk-dev] [PATCH v4 0/3] hash: fix bugs in 'free key with position' Thread-Index: AQHVBot+qfJg49iF1UikbHSpZEYKZqZjocmA//+NSdA= Date: Thu, 9 May 2019 19:36:43 +0000 Message-ID: References: <20190509133924.7153-1-dharmik.thakkar@arm.com> <20190509171907.14693-1-dharmik.thakkar@arm.com> <2469312.dFCSdvozyX@xps> In-Reply-To: <2469312.dFCSdvozyX@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDlhZjI0ZDctMDkwMS00MDcxLWE2YTAtYzU0MTBhOTZlNzIzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiOElsUElrTEpUTDMwa25cL2FDQ29LcEY1WUdDR1ZLNktBMm1uQ2l3M2dQdkMzVEd3ZnA1WnIxcjVtZVFIdU54TFMifQ== x-originating-ip: [10.22.254.139] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 0/3] hash: fix bugs in 'free key with position' X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 May 2019 19:36:46 -0000 >-----Original Message----- >From: Thomas Monjalon [mailto:thomas@monjalon.net] >Sent: Thursday, May 9, 2019 12:24 PM >To: Wang, Yipeng1 ; Gobriel, Sameh >Cc: dev@dpdk.org; Dharmik Thakkar ; honnappa.naga= rahalli@arm.com; zhongdahulinfan@163.com >Subject: Re: [dpdk-dev] [PATCH v4 0/3] hash: fix bugs in 'free key with po= sition' > >09/05/2019 19:19, Dharmik Thakkar: >> This patch series solves 2 bugs reported on Bugzilla (bug-261) within >> the function rte_hash_free_key_with_postion(). It also adds a test case >> to catch similar bugs in the future. >> >> https://bugs.dpdk.org/show_bug.cgi?id=3D261 > >Yipeng, Sameh, should it enter in 19.05-rc4? >Are you sure it does not break things more? >If yes, please give your ack. [Wang, Yipeng]=20 Please go ahead Thomas, I reviewed the code and it will not break other thi= ngs. The changes are refrained inside an experimental API function. I haven't done the meson build test though. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id C28A8A0096 for ; Thu, 9 May 2019 21:36:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C46E4493D; Thu, 9 May 2019 21:36:47 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 7197744C3 for ; Thu, 9 May 2019 21:36:46 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 May 2019 12:36:45 -0700 X-ExtLoop1: 1 Received: from orsmsx108.amr.corp.intel.com ([10.22.240.6]) by fmsmga004.fm.intel.com with ESMTP; 09 May 2019 12:36:45 -0700 Received: from orsmsx163.amr.corp.intel.com (10.22.240.88) by ORSMSX108.amr.corp.intel.com (10.22.240.6) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 9 May 2019 12:36:44 -0700 Received: from orsmsx104.amr.corp.intel.com ([169.254.4.183]) by ORSMSX163.amr.corp.intel.com ([169.254.9.163]) with mapi id 14.03.0415.000; Thu, 9 May 2019 12:36:44 -0700 From: "Wang, Yipeng1" To: Thomas Monjalon , "Gobriel, Sameh" CC: "dev@dpdk.org" , Dharmik Thakkar , "honnappa.nagarahalli@arm.com" , "zhongdahulinfan@163.com" Thread-Topic: [dpdk-dev] [PATCH v4 0/3] hash: fix bugs in 'free key with position' Thread-Index: AQHVBot+qfJg49iF1UikbHSpZEYKZqZjocmA//+NSdA= Date: Thu, 9 May 2019 19:36:43 +0000 Message-ID: References: <20190509133924.7153-1-dharmik.thakkar@arm.com> <20190509171907.14693-1-dharmik.thakkar@arm.com> <2469312.dFCSdvozyX@xps> In-Reply-To: <2469312.dFCSdvozyX@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDlhZjI0ZDctMDkwMS00MDcxLWE2YTAtYzU0MTBhOTZlNzIzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiOElsUElrTEpUTDMwa25cL2FDQ29LcEY1WUdDR1ZLNktBMm1uQ2l3M2dQdkMzVEd3ZnA1WnIxcjVtZVFIdU54TFMifQ== x-originating-ip: [10.22.254.139] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 0/3] hash: fix bugs in 'free key with position' X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190509193643.qZFCsG30DAHB6Hmr4RN46q6OHx8QFmwiQHPq4Pwe3Fk@z> >-----Original Message----- >From: Thomas Monjalon [mailto:thomas@monjalon.net] >Sent: Thursday, May 9, 2019 12:24 PM >To: Wang, Yipeng1 ; Gobriel, Sameh >Cc: dev@dpdk.org; Dharmik Thakkar ; honnappa.naga= rahalli@arm.com; zhongdahulinfan@163.com >Subject: Re: [dpdk-dev] [PATCH v4 0/3] hash: fix bugs in 'free key with po= sition' > >09/05/2019 19:19, Dharmik Thakkar: >> This patch series solves 2 bugs reported on Bugzilla (bug-261) within >> the function rte_hash_free_key_with_postion(). It also adds a test case >> to catch similar bugs in the future. >> >> https://bugs.dpdk.org/show_bug.cgi?id=3D261 > >Yipeng, Sameh, should it enter in 19.05-rc4? >Are you sure it does not break things more? >If yes, please give your ack. [Wang, Yipeng]=20 Please go ahead Thomas, I reviewed the code and it will not break other thi= ngs. The changes are refrained inside an experimental API function. I haven't done the meson build test though.