From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3743FA00E6 for ; Mon, 8 Jul 2019 18:51:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C049B324D; Mon, 8 Jul 2019 18:51:29 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id E703F2C5E for ; Mon, 8 Jul 2019 18:51:27 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Jul 2019 09:51:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,466,1557212400"; d="scan'208";a="170335453" Received: from orsmsx103.amr.corp.intel.com ([10.22.225.130]) by orsmga006.jf.intel.com with ESMTP; 08 Jul 2019 09:51:26 -0700 Received: from orsmsx104.amr.corp.intel.com ([169.254.4.232]) by ORSMSX103.amr.corp.intel.com ([169.254.5.44]) with mapi id 14.03.0439.000; Mon, 8 Jul 2019 09:51:26 -0700 From: "Wang, Yipeng1" To: Thomas Monjalon , Honnappa Nagarahalli CC: "dev@dpdk.org" , "Gobriel, Sameh" , "Richardson, Bruce" , "De Lara Guarch, Pablo" , "gavin.hu@arm.com" , "ruifeng.wang@arm.com" , "nd@arm.com" Thread-Topic: [dpdk-dev] [PATCH v2 0/2] lib/hash: perf improvements for lock-free Thread-Index: AQHVMRt4jrske87QpEydcWqAgjuWhaa7GPkAgAXeTsA= Date: Mon, 8 Jul 2019 16:51:26 +0000 Message-ID: References: <20190625211520.43181-1-honnappa.nagarahalli@arm.com> <20190702211634.37940-1-honnappa.nagarahalli@arm.com> <1762755.dMxNbvATuU@xps> In-Reply-To: <1762755.dMxNbvATuU@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTFhNWU5ZmYtMzI0NS00MTgwLTk4NTAtMGEyZjIxNTI0ZjFlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZ0RwOXViSGNOdlwvV1cwb0IwczdGeG5cL2szTnR3SU1xUW9OZW14TXVDUm9nXC9IcStSS2ZBZlBIODdtSlBjanRDUSJ9 x-originating-ip: [10.22.254.138] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 0/2] lib/hash: perf improvements for lock-free X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >-----Original Message----- >From: Thomas Monjalon [mailto:thomas@monjalon.net] >Sent: Thursday, July 4, 2019 9:10 AM >To: Honnappa Nagarahalli >Cc: dev@dpdk.org; Wang, Yipeng1 ; Gobriel, Sameh <= sameh.gobriel@intel.com>; Richardson, Bruce >; De Lara Guarch, Pablo ; gavin.hu@arm.com; >ruifeng.wang@arm.com; nd@arm.com >Subject: Re: [dpdk-dev] [PATCH v2 0/2] lib/hash: perf improvements for loc= k-free > >02/07/2019 23:16, Honnappa Nagarahalli: >> v2 >> - Dropped moving the tbl_chng_cnt to the beginning of the cache line >> commit >> - Changed the commit log for patch 1 to indicate that it improves >> performance (Yipeng) >> - Changed the comment in the search_one_bucket_lf function (Yipeng) >> - Changed the commit log for patch2 to indicate that changes to >> store-release of 'pdata' is cosmetic (Yipeng) >> >> Honnappa Nagarahalli (2): >> lib/hash: use ordered loads only if signature matches >> lib/hash: load pData after full key compare > >This series is missing 19.08 because of a lack of review. >It was expected because it was sent late in 19.08 cycle, >so this is just to make the status clear: it will be considered for 19.11. > >PS: please think about --in-reply-to when sending new versions. > [Wang, Yipeng] Hi, Thomas, Thanks for your work. I finished the review of this patch, I think it is good to go. Please inclu= de it if it is convenient for you. Honnappa confirmed that my understanding of the code is correct, and it sho= uld help performance.