From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 814D6A034F; Mon, 25 Nov 2019 23:03:15 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 88E1D28EE; Mon, 25 Nov 2019 23:03:14 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 4CEC2235 for ; Mon, 25 Nov 2019 23:03:13 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Nov 2019 14:02:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,242,1571727600"; d="scan'208";a="206273491" Received: from orsmsx101.amr.corp.intel.com ([10.22.225.128]) by fmsmga008.fm.intel.com with ESMTP; 25 Nov 2019 14:02:56 -0800 Received: from orsmsx104.amr.corp.intel.com ([169.254.4.122]) by ORSMSX101.amr.corp.intel.com ([169.254.8.229]) with mapi id 14.03.0439.000; Mon, 25 Nov 2019 14:02:56 -0800 From: "Wang, Yipeng1" To: Thomas Monjalon , Dharmik Thakkar CC: "dev@dpdk.org" , "Gobriel, Sameh" , "Richardson, Bruce" , "honnappa.nagarahalli@arm.com" Thread-Topic: [dpdk-dev] [PATCH] lib/hash: remove unnecessary locks in lock-free Thread-Index: AQHVoJgRBX2f6MTaQEyJe/MSKQYvmKecQL8QgAC6HQD//3uSwA== Date: Mon, 25 Nov 2019 22:02:55 +0000 Message-ID: References: <20191121181759.11401-1-dharmik.thakkar@arm.com> <10640783.jF6kOFs2fc@xps> In-Reply-To: <10640783.jF6kOFs2fc@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjk1YzI1YjUtOWYwZS00MmMxLTk2YTQtODBhMTNhYmVlMzhhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoia01sd1pRYU43SkJIajNnSGM3RXArM2kwWjkxRmRFN2RkSnpTN3gwWGtjd1czV0thSjYyanBVZElvNU9zeFwvZTQifQ== x-originating-ip: [10.22.254.139] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] lib/hash: remove unnecessary locks in lock-free X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >-----Original Message----- >From: Thomas Monjalon [mailto:thomas@monjalon.net] >Sent: Monday, November 25, 2019 1:55 PM >To: Wang, Yipeng1 ; Dharmik Thakkar >Cc: dev@dpdk.org; Gobriel, Sameh ; Richardson, Br= uce ; >honnappa.nagarahalli@arm.com >Subject: Re: [dpdk-dev] [PATCH] lib/hash: remove unnecessary locks in lock= -free > >25/11/2019 19:49, Wang, Yipeng1: >> >-----Original Message----- >> >From: Dharmik Thakkar [mailto:dharmik.thakkar@arm.com] >> >Sent: Thursday, November 21, 2019 10:18 AM >> >To: Wang, Yipeng1 ; Gobriel, Sameh ; Richardson, Bruce >> > >> >Cc: dev@dpdk.org; honnappa.nagarahalli@arm.com; Dharmik Thakkar >> >Subject: [PATCH] lib/hash: remove unnecessary locks in lock-free >> > >> >Remove __hash_rw_reader_unlock() calls from lock free hash lookup >> > >> >Signed-off-by: Dharmik Thakkar >> >Reviewed-by: Gavin Hu >> >Reviewed-by: Honnappa Nagarahalli >> >--- >> Acked-by: Yipeng Wang >> >> Thanks for the patch! > >Excuse me, there is no motivation (the why) in this patch. >Is it critical? which gain? > [Wang, Yipeng]=20 Thomas, do you mean the commit message is not clear enough? I think it is self-explained that in the "lock-free" implementation, we don= 't need "read_unlock()" and the subject line also says that. But it is always better to be more explicit.