From: Harish Patil <harish.patil@qlogic.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
Rasesh Mody <rasesh.mody@qlogic.com>
Cc: "thomas.monjalon@6wind.com" <thomas.monjalon@6wind.com>,
"bruce.richardson@intel.com" <bruce.richardson@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Ameen Rahman <ameen.rahman@qlogic.com>,
Sony Chacko <sony.chacko@qlogic.com>
Subject: Re: [dpdk-dev] [PATCH v5 00/10] qede: Add qede PMD
Date: Fri, 1 Apr 2016 15:51:22 +0000 [thread overview]
Message-ID: <D323E5A4.1899B1%harish.patil@qlogic.com> (raw)
In-Reply-To: <20160401084440.05f3dcd3@xeon-e3>
>
>On Thu, 31 Mar 2016 19:15:17 -0700
>Rasesh Mody <rasesh.mody@qlogic.com> wrote:
>
>> Hi Thomas, Bruce,
>>
>> The v5 series incorporates the following review comments:
>> - move adapter_info logs under debug
>> - implement qede_mac_addr_remove()
>> - remove unused rc variable in qede_dev_configure()
>> - fix indentation in qede_dev_info_get()
>> - use c99 style struct init in qede_config_accept_any_vlan()
>> - check error in qede_config_rx_mode()
>> - update overview.rst since patch didn't apply
>>
>> The patches are generated and tested against latest dpdk based off of
>> v16.04-rc2.
>>
>> These patches are checked using checkpatch.sh with following additional
>> ignore option:
>> options="$options --ignore=BIT_MACRO,CONCATENATED_STRING"
>>
>> Please apply!
>
>Looks good.
>
>One question, is there any restriction on number of Tx queues, relative
>to number of Rx queues. Is it possible to have 8 Tx queues but only 2 Rx
>queues?
>I know bnx2x and some other drivers have that kind of restriction.
>
>Acked-by: Stephen Hemminger <stephen@networkplumber.org>
>
At the outset, thanks for all the review comments.
Yes, currently we only support symmetrical number of queue pairs.
So we have a check in place not to allow unequal no. of RX/TX queues (say
RX=2, TX=8).
We have a work item to address that later. There is no FW/HW restriction.
Thanks,
Harish
prev parent reply other threads:[~2016-04-01 15:51 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 2:15 Rasesh Mody
2016-04-01 2:15 ` [dpdk-dev] [PATCH v5 01/10] qede: Add maintainers Rasesh Mody
2016-04-18 16:41 ` Thomas Monjalon
2016-04-18 21:40 ` Harish Patil
2016-04-01 2:15 ` [dpdk-dev] [PATCH v5 02/10] qede: Add documentation Rasesh Mody
2016-04-01 2:15 ` [dpdk-dev] [PATCH v5 03/10] qede: Add license file Rasesh Mody
2016-04-01 2:15 ` [dpdk-dev] [PATCH v5 04/10] qede: Add base driver Rasesh Mody
2016-04-01 2:15 ` [dpdk-dev] [PATCH v5 05/10] qede: Add core driver Rasesh Mody
2016-04-01 15:41 ` Stephen Hemminger
2016-04-01 15:42 ` Stephen Hemminger
2016-04-19 12:35 ` Thomas Monjalon
2016-04-19 12:59 ` Thomas Monjalon
2016-04-20 1:09 ` Rasesh Mody
2016-04-20 8:54 ` Thomas Monjalon
2016-04-22 10:48 ` [dpdk-dev] Compiler minimum versions. (Was: [PATCH v5 05/10] qede: Add core driver) Bruce Richardson
2016-04-19 13:18 ` [dpdk-dev] [PATCH v5 05/10] qede: Add core driver Thomas Monjalon
2016-04-20 1:10 ` Rasesh Mody
2016-04-01 2:15 ` [dpdk-dev] [PATCH v5 06/10] qede: Add L2 support Rasesh Mody
2016-04-01 2:15 ` [dpdk-dev] [PATCH v5 07/10] qede: Add SRIOV support Rasesh Mody
2016-04-01 2:15 ` [dpdk-dev] [PATCH v5 08/10] qede: Add attention support Rasesh Mody
2016-04-01 2:15 ` [dpdk-dev] [PATCH v5 09/10] qede: Add DCBX support Rasesh Mody
2016-04-19 12:51 ` Thomas Monjalon
2016-04-01 2:15 ` [dpdk-dev] [PATCH v5 10/10] qede: Enable PMD build Rasesh Mody
2016-04-18 15:34 ` Thomas Monjalon
2016-04-20 0:07 ` Harish Patil
2016-04-18 15:37 ` Thomas Monjalon
2016-04-20 0:14 ` Harish Patil
2016-04-20 8:51 ` Thomas Monjalon
2016-04-20 9:25 ` Bruce Richardson
2016-04-20 16:43 ` Harish Patil
2016-04-21 10:01 ` Bruce Richardson
2016-04-20 16:36 ` Harish Patil
2016-04-01 15:44 ` [dpdk-dev] [PATCH v5 00/10] qede: Add qede PMD Stephen Hemminger
2016-04-01 15:51 ` Harish Patil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D323E5A4.1899B1%harish.patil@qlogic.com \
--to=harish.patil@qlogic.com \
--cc=ameen.rahman@qlogic.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=rasesh.mody@qlogic.com \
--cc=sony.chacko@qlogic.com \
--cc=stephen@networkplumber.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).