From: Harish Patil <harish.patil@qlogic.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Rasesh Mody <rasesh.mody@qlogic.com>,
Sony Chacko <sony.chacko@qlogic.com>
Subject: Re: [dpdk-dev] [PATCH] qede: fix icc build error
Date: Tue, 10 May 2016 20:02:13 +0000 [thread overview]
Message-ID: <D3578A37.18DDD%harish.patil@qlogic.com> (raw)
In-Reply-To: <1462879407-27649-1-git-send-email-ferruh.yigit@intel.com>
Hi Ferruh,
>fix errors:
>icc: command line warning #10006: ignoring unknown option
>'-Wno-unused-value'
>icc: command line warning #10006: ignoring unknown option
>'-Wno-format-nonliteral'
>icc: command line warning #10006: ignoring unknown option
>'-Wno-shift-negative-value'
>qede/base/ecore_dev.c(1643): error #188: enumerated type mixed with
>another type
> return 0;
> ^
>
>Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>---
> drivers/net/qede/Makefile | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/net/qede/Makefile b/drivers/net/qede/Makefile
>index 47e01be..d0c1361 100644
>--- a/drivers/net/qede/Makefile
>+++ b/drivers/net/qede/Makefile
>@@ -27,7 +27,6 @@ OS_TYPE := $(shell uname -s)
> # CFLAGS
> #
> CFLAGS_BASE_DRIVER = -Wno-unused-parameter
>-CFLAGS_BASE_DRIVER += -Wno-unused-value
> CFLAGS_BASE_DRIVER += -Wno-sign-compare
> CFLAGS_BASE_DRIVER += -Wno-missing-prototypes
> CFLAGS_BASE_DRIVER += -Wno-cast-qual
>@@ -35,12 +34,16 @@ CFLAGS_BASE_DRIVER += -Wno-unused-function
> CFLAGS_BASE_DRIVER += -Wno-unused-variable
> CFLAGS_BASE_DRIVER += -Wno-strict-aliasing
> CFLAGS_BASE_DRIVER += -Wno-missing-prototypes
>+
>+ifneq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
>+CFLAGS_BASE_DRIVER += -Wno-unused-value
This change is not for the actual build error but to mask the warning:
icc: command line warning #10006: ignoring unknown option
'-Wno-unused-value’, right?
If so, what about for Wno-format-nonliteral and Wno-shift-negative-value?
> CFLAGS_BASE_DRIVER += -Wno-format-nonliteral
> ifeq ($(OS_TYPE),Linux)
> ifeq ($(shell clang -Wno-shift-negative-value -Werror -E - < /dev/null >
>/dev/null 2>&1; echo $$?),0)
> CFLAGS_BASE_DRIVER += -Wno-shift-negative-value
> endif
> endif
>+endif
>
> ifneq (,$(filter gcc gcc48,$(CC)))
> CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable
>@@ -57,7 +60,7 @@ ifeq ($(shell clang -Wno-pointer-bool-conversion
>-Werror -E - < /dev/null > /dev
> CFLAGS_BASE_DRIVER += -Wno-pointer-bool-conversion
> endif
> else
>-#icc flags
>+CFLAGS_BASE_DRIVER += -wd188 #188: enumerated type mixed with another
>type
> endif
>
> #
>--
>2.5.5
>
>
Looks good.
I hope its retested against gcc/clang also to make sure the change doesn’t
cause build errors.
Acked-by: Harish Patil <harish.patil@qlogic.com>
next prev parent reply other threads:[~2016-05-10 20:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-10 11:23 Ferruh Yigit
2016-05-10 20:02 ` Harish Patil [this message]
2016-05-11 17:17 ` Ferruh Yigit
2016-05-13 15:27 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D3578A37.18DDD%harish.patil@qlogic.com \
--to=harish.patil@qlogic.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=rasesh.mody@qlogic.com \
--cc=sony.chacko@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).