Re: [dpdk-dev] [PATCH] timer: remove unnecessary timer add call

["Sanford, Robert" <rsanford@akamai.com>]

On 7/17/16 1:35 PM, "Hiroyuki Mikita" <h.mikita89@gmail.com> wrote:

>When timer_set_running_state() fails in rte_timer_manage(),
>the failed timer is put back on pending-list.
>In this case, another core tries to reset or stop the timer.
>It does not need to be on pending-list
>
>Signed-off-by: Hiroyuki Mikita <h.mikita89@gmail.com>
>---
> lib/librte_timer/rte_timer.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
>diff --git a/lib/librte_timer/rte_timer.c b/lib/librte_timer/rte_timer.c
>index 3dcdab5..94878d3 100644
>--- a/lib/librte_timer/rte_timer.c
>+++ b/lib/librte_timer/rte_timer.c
>@@ -562,10 +562,9 @@ void rte_timer_manage(void)
> 			pprev = &tim->sl_next[0];
> 		} else {
> 			/* another core is trying to re-config this one,
>-			 * remove it from local expired list and put it
>-			 * back on the priv_timer[] skip list */
>+			 * remove it from local expired list
>+			 */
> 			*pprev = next_tim;
>-			timer_add(tim, lcore_id, 1);
> 		}
> 	}
> 
>-- 
>2.7.4
>

Acked-by: Robert Sanford <rsanford@akamai.com>