DPDK patches and discussions
 help / color / mirror / Atom feed
From: Harish Patil <harish.patil@qlogic.com>
To: Chas Williams <3chas3@gmail.com>,
	Rasesh Mody <rasesh.mody@qlogic.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: Dept-Eng DPDK Dev <Dept-EngDPDKDev@qlogic.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] bnx2x: fix maximum PF queues
Date: Tue, 11 Oct 2016 14:22:20 +0000	[thread overview]
Message-ID: <D422414B.9B96F%Harish.Patil@cavium.com> (raw)
In-Reply-To: <1476194171.1627.7.camel@gmail.com>

>

>On Wed, 2016-10-05 at 22:36 -0700, Rasesh Mody wrote:
>> Fix the max number of PF rx/tx queues. Set the value based
>> on BNX2X_MAX_RSS_COUNT() rather than hard coding it to 128.
>> 
>> Fixes: 540a211 ("bnx2x: driver core")
>> 
>> Signed-off-by: Rasesh Mody <rasesh.mody@qlogic.com>
>> ---
>>  drivers/net/bnx2x/bnx2x.c |    4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c
>> index a49a07f..2bb4a84 100644
>> --- a/drivers/net/bnx2x/bnx2x.c
>> +++ b/drivers/net/bnx2x/bnx2x.c
>> @@ -9556,8 +9556,8 @@ static void bnx2x_init_rte(struct bnx2x_softc *sc)
>>  		sc->max_rx_queues = min(BNX2X_VF_MAX_QUEUES_PER_VF,
>>  					sc->igu_sb_cnt);
>>  	} else {
>> -		sc->max_tx_queues = 128;
>> -		sc->max_rx_queues = 128;
>> +		sc->max_rx_queues = BNX2X_MAX_RSS_COUNT(sc);
>> +		sc->max_tx_queues = sc->max_rx_queues;
>>  	}
>>  }
>
>Technically, I think max_tx_queues would be max_rx_queues * max_cos.
>However, I don't think there are any DPDK applications that would take
>advantage of this.
>
>Acked-By: Chas Williams <3chas3@gmail.com>
>

Thanks Chas.
Ideally yes that’s the case.
But the driver doesn’t support asymmetrical no. of rx/tx queues, its only
the queue-pairs and hence RX=TX.
Many places in the driver assumes rx/tx queues are same and loop on rss_id
to access the corresponding tss_id.

Thanks,
Harish 


  reply	other threads:[~2016-10-11 14:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-06  5:36 Rasesh Mody
2016-10-06  5:36 ` [dpdk-dev] [PATCH 2/2] bnx2x: fix to use SOCKET_ID_ANY for slowpath memory Rasesh Mody
2016-10-11 13:56 ` [dpdk-dev] [PATCH 1/2] bnx2x: fix maximum PF queues Chas Williams
2016-10-11 14:22   ` Harish Patil [this message]
2016-10-12 16:33 ` Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D422414B.9B96F%Harish.Patil@cavium.com \
    --to=harish.patil@qlogic.com \
    --cc=3chas3@gmail.com \
    --cc=Dept-EngDPDKDev@qlogic.com \
    --cc=dev@dpdk.org \
    --cc=rasesh.mody@qlogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).