From: Harish Patil <harish.patil@qlogic.com>
To: "Charles (Chas) Williams" <ciwillia@brocade.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: Harish Patil <harish.patil@qlogic.com>
Subject: Re: [dpdk-dev] [PATCH] net/bnx2x: Fix transmit queue free threshold
Date: Thu, 23 Feb 2017 00:26:08 +0000 [thread overview]
Message-ID: <D4D36BB2.10914C%Harish.Patil@cavium.com> (raw)
In-Reply-To: <1486757526-12028-1-git-send-email-ciwillia@brocade.com>
>
>The default tx_free_thresh is potentially larger than the allocated queue
>which will result in TX queue cleanup never happening. To fix this,
>lower the default free threshold and ensure that the free threshold is
>never greater than the maximum outstanding transmit buffers.
>
>Fixes: 827ed2a118cc ("net/bnx2x: restructure Tx routine")
>
>Signed-off-by: Chas Williams <ciwillia@brocade.com>
>---
> drivers/net/bnx2x/bnx2x_rxtx.c | 2 ++
> drivers/net/bnx2x/bnx2x_rxtx.h | 2 +-
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/net/bnx2x/bnx2x_rxtx.c
>b/drivers/net/bnx2x/bnx2x_rxtx.c
>index 170e48f..adf0309 100644
>--- a/drivers/net/bnx2x/bnx2x_rxtx.c
>+++ b/drivers/net/bnx2x/bnx2x_rxtx.c
>@@ -273,6 +273,8 @@ bnx2x_dev_tx_queue_setup(struct rte_eth_dev *dev,
>
> txq->tx_free_thresh = tx_conf->tx_free_thresh ?
> tx_conf->tx_free_thresh : DEFAULT_TX_FREE_THRESH;
>+ txq->tx_free_thresh = min(txq->tx_free_thresh,
>+ txq->nb_tx_desc - BDS_PER_TX_PKT);
>
> PMD_INIT_LOG(DEBUG, "fp[%02d] req_bd=%u, thresh=%u, usable_bd=%lu, "
> "total_bd=%lu, tx_pages=%u",
>diff --git a/drivers/net/bnx2x/bnx2x_rxtx.h
>b/drivers/net/bnx2x/bnx2x_rxtx.h
>index dd251aa..2e38ec2 100644
>--- a/drivers/net/bnx2x/bnx2x_rxtx.h
>+++ b/drivers/net/bnx2x/bnx2x_rxtx.h
>@@ -11,7 +11,7 @@
> #ifndef _BNX2X_RXTX_H_
> #define _BNX2X_RXTX_H_
>
>-#define DEFAULT_TX_FREE_THRESH 512
>+#define DEFAULT_TX_FREE_THRESH 64
> #define RTE_PMD_BNX2X_TX_MAX_BURST 1
>
> /**
>--
>2.1.4
>
>
Acked-by: Harish Patil <harish.patil@qlogic.com>
next prev parent reply other threads:[~2017-02-23 0:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-10 20:12 Charles (Chas) Williams
2017-02-23 0:26 ` Harish Patil [this message]
2017-02-23 10:09 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D4D36BB2.10914C%Harish.Patil@cavium.com \
--to=harish.patil@qlogic.com \
--cc=ciwillia@brocade.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).