From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6705445AA0; Thu, 3 Oct 2024 14:43:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3782540299; Thu, 3 Oct 2024 14:43:35 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 301A84014F for ; Thu, 3 Oct 2024 14:43:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727959413; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Rxv49iAUOsjVwKLG1CYjT35XM3DsuFqhUyBxnSnrbXM=; b=GWK5wMgLUf+icUaXh1Dsup7UXiDQqmTrycixBzIVUJbAhMPEbY821MCXSO0z3o0Lu+rAzY 4hFQE1eu8aQjli3LmRrxmjzvKTHoZsXRK35drCZiVlPhy/WExDRVsSEwUmAcS3TdO5xI93 sMitsO57sBPDRZuvlA8IDSNeiVd7mGg= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-104-YNQWzmK5M3238BhEM_zMzQ-1; Thu, 03 Oct 2024 08:43:32 -0400 X-MC-Unique: YNQWzmK5M3238BhEM_zMzQ-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-42cbcf60722so6211255e9.1 for ; Thu, 03 Oct 2024 05:43:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727959411; x=1728564211; h=in-reply-to:references:user-agent:subject:to:from:cc:message-id :date:content-transfer-encoding:mime-version:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=YmxBzUTk6O+fHYi5eqR0SN78Eaf79TCKp3fmWjBUryY=; b=WpkIXRLKanuagRQ6g/UtzgjwRUVy3sixBiGSNvmKLICwo179GRdn41hol5xlo/fksz r/+8A8RdiVPuD/TcSrQTW2F7ZKrLZ7bHVyQqgm4B+iX38rT0dr3/e+BMdS4IAksKy3dK brYTWzzJ0drst3Pb4fNQlfuj7wv9sgmoIVaHwbkkgKC7s4eVXAP6D6M2se4YX7q31syh 18vR3mQzuHdUfA7wEba9hs0ktGQNwmwqKXYKR2cz17SxTQMb/rufqirTaoBuD06GSJUv 2AYYDTJ5ItwaYpfZ2UwOgfl9AVoc5axDdVrJ/wlEmhVZpPfMW2TgUWK18RXR+PYEeiiZ tzRw== X-Gm-Message-State: AOJu0YzRBqMltAsgUH9fOcKzMJUUocDoZhM9D2Q1TDiwG4QZAH6GRPSz LywEL2DKHcIO0BVFnSoNrKrCpvfkQQnJIe0Q4f3oBN6FKK9BjguNsxmRXENtDL1SmS8gW0JV4Qz B9dC34nNV0VthTDPXmm/JGEY+yA5DuW3bR7k+FBTm X-Received: by 2002:a05:600c:4455:b0:42c:b7f9:4bbd with SMTP id 5b1f17b1804b1-42f778f3477mr53427465e9.26.1727959411362; Thu, 03 Oct 2024 05:43:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEkaS9gnHfX17s94DkNui769ua3hh5I3GyRYGMQ5b/se1/6X2yw/xk5Liqfn9cIcNT1JweseQ== X-Received: by 2002:a05:600c:4455:b0:42c:b7f9:4bbd with SMTP id 5b1f17b1804b1-42f778f3477mr53427285e9.26.1727959410967; Thu, 03 Oct 2024 05:43:30 -0700 (PDT) Received: from localhost (2a01cb00025433006239e1f47a0b2371.ipv6.abo.wanadoo.fr. [2a01:cb00:254:3300:6239:e1f4:7a0b:2371]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42f802656f7sm14837795e9.27.2024.10.03.05.43.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Oct 2024 05:43:30 -0700 (PDT) Mime-Version: 1.0 Date: Thu, 03 Oct 2024 14:43:30 +0200 Message-Id: Cc: , , From: "Robin Jarry" To: "Bruce Richardson" Subject: Re: [PATCH dpdk v2 1/2] telemetry: add api to register command with private argument User-Agent: aerc/0.18.2-74-g7e4ac1a5f54c References: <20241002155709.2522273-1-david.marchand@redhat.com> <20241003112438.902397-6-rjarry@redhat.com> In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8; format=Flowed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Robin Jarry, Oct 03, 2024 at 14:36: >>> +typedef int (*telemetry_arg_cb)(const char *cmd, const char *params, >>> +=09=09struct rte_tel_data *info, void *arg); >>> + >> >> Not sure about this, but I'd tend to have the arg parameter as second >> parameter, to keep the "info" as the final parameter. My suggested order >> would be: (cmd, arg, params, info) > > I don't have any objections. I'll send a v3. Reflecting back, I think the void* arg would fit better as the first=20 callback argument. Thoughts?