Re: [dpdk-dev] [PATCH v7 1/7] qede: add base driver

["Patil, Harish" <Harish.Patil@cavium.com>]

>

><...>
>
>>>> +
>>>> +#
>>>> +# Add extra flags for base ecore driver files # to disable warnings
>>>> +in them # # BASE_DRIVER_OBJS=$(patsubst %.c,%.o,$(notdir $(wildcard
>>>> +$(SRCDIR)/base/*.c))) $(foreach obj, $(BASE_DRIVER_OBJS), $(eval
>>>> +CFLAGS+=$(CFLAGS_BASE_DRIVER)))
>>>
>>> My eyes just caught this one, above line adds $(CFLAGS_BASE_DRIVER)
>>> many times to $(CFLAGS), but real intentions is add to obj specific
>>>CFLAGS
>>> and only being limited to base files.
>>>
>>> Like:
>>> $(foreach obj, $(BASE_DRIVER_OBJS), $(eval
>>> CFLAGS_$(obj)+=$(CFLAGS_BASE_DRIVER)))
>>>
>>> Can you please fix this?
>> 
>> We will look into this, we plan to submit the fix as separate bug fix
>>patch in 17.05 timeframe.
>
>Reminder.

Hi Ferruh,
Yes, we are going to submit this along side few bug fixes.
Thanks.

>
>> 
>> Thanks!
>> -Rasesh
>> 
>>>
>>> Fixing this may give some build errors on non-base driver files,
>>>although not
>>> sure.
>>>
>>> Thanks,
>>> ferruh
>