From: "Wiles, Keith" <keith.wiles@intel.com>
To: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Kumar Sanghvi <kumaras@chelsio.com>,
Nirranjan Kirubaharan <nirranjan@chelsio.com>
Subject: Re: [dpdk-dev] Pktgen-DPDK build errors on ppc64le
Date: Tue, 28 Feb 2017 14:50:19 +0000 [thread overview]
Message-ID: <D5FAAFAA-B5FB-4972-A100-C8555251CB21@intel.com> (raw)
In-Reply-To: <20170228084834.GB12546@chelsio.com>
> On Feb 28, 2017, at 2:48 AM, Rahul Lakkireddy <rahul.lakkireddy@chelsio.com> wrote:
>
> Hi All,
>
> We are seeing Pktgen-DPDK not building on ppc64le with latest dpdk git
> repo.
Yes, it looks like Pktgen needs to change to account for 256 cores. It is using uint8_t and needs to change to uint16_t variables. I can only suggest you can change the sizes in the places the compiler gives an error. I will try to get Pktgen updated to fix this issue in the next release.
>
> Below build errors are seen:
> -------------------------
> [pktgen-dpdk]# make
> == lib
> == common
> CC l2p.o
> In file included from /root/pktgen-dpdk/lib/common/l2p.c:88:0:
> /root/pktgen-dpdk/lib/common/l2p.h: In function ‘pg_raw_dump_l2p’:
> /root/pktgen-dpdk/lib/common/l2p.h:103:2: error: comparison is always true due to limited range of data type [-Werror=type-limits]
> for (i = 0; i < RTE_MAX_LCORE; i++)
> ^
> /root/pktgen-dpdk/lib/common/l2p.h:109:2: error: comparison is always true due to limited range of data type [-Werror=type-limits]
> for (j = 0; j < RTE_MAX_LCORE; j++) {
> ^
> /root/pktgen-dpdk/lib/common/l2p.h: In function ‘pg_dump_l2p’:
> /root/pktgen-dpdk/lib/common/l2p.h:486:2: error: comparison is always true due to limited range of data type [-Werror=type-limits]
> for (lid = 0; lid < RTE_MAX_LCORE; lid++) {
> ^
> /root/pktgen-dpdk/lib/common/l2p.c: In function ‘pg_port_matrix_dump’:
> /root/pktgen-dpdk/lib/common/l2p.c:477:3: error: large integer implicitly truncated to unsigned type [-Werror=overflow]
> cnt.rxtx = get_map(l2p, pid, RTE_MAX_LCORE);
> ^
> /root/pktgen-dpdk/lib/common/l2p.c:488:3: error: large integer implicitly truncated to unsigned type [-Werror=overflow]
> cnt.rxtx = get_map(l2p, pid, RTE_MAX_LCORE);
> ^
> cc1: all warnings being treated as errors
> make[3]: *** [l2p.o] Error 1
> make[2]: *** [all] Error 2
> make[1]: *** [common] Error 2
> make: *** [lib] Error 2
> -------------------------
>
> By changing CONFIG_RTE_MAX_LCORE to 128 in defconfig_ppc_64-power8-linuxapp-gcc
> file, Pktgen-DPDK then builds fine.
>
> Thanks,
> Rahul
Regards,
Keith
prev parent reply other threads:[~2017-02-28 14:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-28 8:48 Rahul Lakkireddy
2017-02-28 14:50 ` Wiles, Keith [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D5FAAFAA-B5FB-4972-A100-C8555251CB21@intel.com \
--to=keith.wiles@intel.com \
--cc=dev@dpdk.org \
--cc=kumaras@chelsio.com \
--cc=nirranjan@chelsio.com \
--cc=rahul.lakkireddy@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).