From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 9AB7D5583 for ; Fri, 17 Feb 2017 16:05:42 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP; 17 Feb 2017 07:05:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,172,1484035200"; d="scan'208";a="1098234283" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga001.jf.intel.com with ESMTP; 17 Feb 2017 07:05:41 -0800 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 17 Feb 2017 07:05:41 -0800 Received: from fmsmsx113.amr.corp.intel.com ([169.254.13.230]) by FMSMSX112.amr.corp.intel.com ([169.254.5.137]) with mapi id 14.03.0248.002; Fri, 17 Feb 2017 07:05:40 -0800 From: "Wiles, Keith" To: "Richardson, Bruce" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/tap: fix coverity warning on strncpy Thread-Index: AQHSiSxu0UOBkRtifUWmL5b4b9dVdaFt0Y2AgAAAz4A= Date: Fri, 17 Feb 2017 15:05:40 +0000 Message-ID: References: <20170217144426.47823-1-keith.wiles@intel.com> <20170217150245.GB8652@bricha3-MOBL3.ger.corp.intel.com> In-Reply-To: <20170217150245.GB8652@bricha3-MOBL3.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.102.97] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/tap: fix coverity warning on strncpy X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Feb 2017 15:05:43 -0000 > On Feb 17, 2017, at 9:02 AM, Richardson, Bruce wrote: >=20 > On Fri, Feb 17, 2017 at 08:44:26AM -0600, Keith Wiles wrote: >> Calling strncpy with a maximum size argument of 16 bytes on destination >> array "ifr.ifr_ifrn.ifrn_name" of size 16 bytes might leave the >> destination string unterminated. >>=20 >> Signed-off-by: Keith Wiles >> --- >> drivers/net/tap/rte_eth_tap.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >>=20 >> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap= .c >> index efc4426..f9938d7 100644 >> --- a/drivers/net/tap/rte_eth_tap.c >> +++ b/drivers/net/tap/rte_eth_tap.c >> @@ -297,7 +297,7 @@ tap_link_set_flags(struct pmd_internals *pmd, short = flags, int add) >> return -1; >> } >> memset(&ifr, 0, sizeof(ifr)); >> - strncpy(ifr.ifr_name, pmd->name, IFNAMSIZ); >> + strncpy(ifr.ifr_name, pmd->name, IFNAMSIZ-1); > This is why I always prefer to use snprintf for copying strings, you > can't avoid null terminating. Normally I use snprintf to not sure why I reverted to strncpy. Maybe leftov= er from a previous driver I used as the template. >=20 > snprintf(ifr.ifr_name, IFNAMSIZ, "%s", pmd->name); >=20 > /Bruce Regards, Keith