From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0087.outbound.protection.outlook.com [104.47.1.87]) by dpdk.org (Postfix) with ESMTP id 13C182BA7 for ; Mon, 7 May 2018 23:37:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=exPi06RBtFkmV32lDVHYpqLLvc+W46Fus0rk8SvxAXE=; b=J2/Is8GzNww+a8tww0fVhLaxYtvLkBU+QAq3/W0nYXSgxLUHrCUJ/qefVV/YNrQJiqIUhZyhu1p6LCLSZTIaAhjVrD453muljcpJrcpuBKhWEGiBw0dHsKDyz0dPnGgGEKZmBkt0Zi9Tu8bCUtkswcj2wqNGCn6/yqjocUkM6wQ= Received: from VI1PR0501MB2045.eurprd05.prod.outlook.com (10.167.195.147) by VI1PR0501MB2415.eurprd05.prod.outlook.com (10.168.135.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.735.17; Mon, 7 May 2018 21:37:24 +0000 Received: from VI1PR0501MB2045.eurprd05.prod.outlook.com ([fe80::11b2:1e2d:709c:695d]) by VI1PR0501MB2045.eurprd05.prod.outlook.com ([fe80::11b2:1e2d:709c:695d%13]) with mapi id 15.20.0735.019; Mon, 7 May 2018 21:37:24 +0000 From: Yongseok Koh To: Shahaf Shuler CC: Adrien Mazarguil , =?iso-8859-1?Q?N=E9lio_Laranjeiro?= , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 1/5] net/mlx5: trim debug messages for reference counters Thread-Index: AQHT5QS3r5bFMuHIZkym2mbUF+mc5aQkzSGA Date: Mon, 7 May 2018 21:37:24 +0000 Message-ID: References: <20180502231654.7596-1-yskoh@mellanox.com> <20180502231654.7596-2-yskoh@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR0501MB2415; 7:rj8QYUyQURM5ySFBWzGQ7TqsDcvGT2Amom23/pXvLjcU2M0reqdJEiX8A/hMg+WBVGOaHHSNUv+N45MGKsBbh9ogcrsY1XQWVbTrz20WnFgkbHZXsFfYQj5ZO8qdlQikqIX3iio2EJkm9UEPpLUAHdi1Uk4V3Co2RJCFNcx292p/6wyUFOqOBaRhPCP1fGhtSaBu5Q02i0di4LQK8KIZ3TeaJYKw+jxjEa98evZOQKJ3ufeqPUt7BbEtxqa8qf93 x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(48565401081)(2017052603328)(7153060)(7193020); SRVR:VI1PR0501MB2415; x-ms-traffictypediagnostic: VI1PR0501MB2415: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3002001)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(6072148)(201708071742011); SRVR:VI1PR0501MB2415; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0501MB2415; x-forefront-prvs: 066517B35B x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(376002)(39860400002)(366004)(39380400002)(346002)(189003)(199004)(33656002)(54906003)(81156014)(478600001)(6246003)(36756003)(6862004)(66066001)(25786009)(316002)(105586002)(2906002)(3280700002)(11346002)(476003)(83716003)(102836004)(3660700001)(81166006)(5660300001)(5250100002)(37006003)(486006)(26005)(2616005)(446003)(99286004)(86362001)(7736002)(2900100001)(6116002)(82746002)(6486002)(97736004)(68736007)(53546011)(6512007)(106356001)(6506007)(53936002)(4326008)(229853002)(59450400001)(14454004)(8936002)(305945005)(3846002)(6636002)(76176011)(15650500001)(6436002)(87944003); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB2415; H:VI1PR0501MB2045.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: fSSylriXdFGbI9egmmY/E3B6BuaMBMpeAXmdMIvbCcg6mRFz6p5HYL8ivaests6a7adKoDfn1OOoGnmS8U8DMWlSsEkmtb4WBk6twSUbF0hwwJDcS2B4QD0IeqGESGG0BfOYSQpQVWU7hQgRI4iaPKA6zXhk+5x2PJA5c59WmpFCcLfO59rDSZT2LLdSQQ9H spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-ID: <2C13E6C7BED3E44EA4AF01490F2DB543@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: fa959f07-2aa6-4fd8-e88e-08d5b462b8d1 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: fa959f07-2aa6-4fd8-e88e-08d5b462b8d1 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 May 2018 21:37:24.2102 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2415 Subject: Re: [dpdk-dev] [PATCH 1/5] net/mlx5: trim debug messages for reference counters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 May 2018 21:37:26 -0000 > On May 5, 2018, at 11:37 PM, Shahaf Shuler wrote: >=20 > Thursday, May 3, 2018 2:17 AM, Yongseok Koh: >> Subject: [dpdk-dev] [PATCH 1/5] net/mlx5: trim debug messages for >> reference counters >>=20 >> Remove debug messages when getting an object. When releasing an object, >> debug message will be printed only if the object is really freed. >>=20 >> Signed-off-by: Yongseok Koh >> --- >=20 > Only one general comment as you are making some order here. >=20 > I think it will be better to be explicit in the logging. Saying when new = object is created: > "port %u new ... .. for queue ... " >=20 > No need for the refcnt as it is obviously 0.=20 >=20 > And when object is destroyed: > "port %u .. ... for queue... is destroyed" I'd rather drop this patch. This is Nelio's code and he might still want to keep it. As he is now OOO, we can't hear from him. This patch is nothing but cleanup. Thanks, Yongseok=