From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id D43AB1BAFB for ; Fri, 11 Jan 2019 20:47:59 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jan 2019 11:47:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,466,1539673200"; d="scan'208";a="105929834" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga007.jf.intel.com with ESMTP; 11 Jan 2019 11:47:58 -0800 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 11 Jan 2019 11:47:57 -0800 Received: from fmsmsx117.amr.corp.intel.com ([169.254.3.160]) by fmsmsx124.amr.corp.intel.com ([169.254.8.80]) with mapi id 14.03.0415.000; Fri, 11 Jan 2019 11:47:57 -0800 From: "Wiles, Keith" To: Stephen Hemminger CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 0/6] net/tap: fixes and cleanups Thread-Index: AQHUqdiD00nR8siNJ0einzu0w9SD/KWq/4MA Date: Fri, 11 Jan 2019 19:47:57 +0000 Message-ID: References: <20190111180659.5972-1-stephen@networkplumber.org> In-Reply-To: <20190111180659.5972-1-stephen@networkplumber.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.35.122] Content-Type: text/plain; charset="us-ascii" Content-ID: <38C7C7E59D142B4F811F382335AF46E2@intel.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 0/6] net/tap: fixes and cleanups X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jan 2019 19:48:00 -0000 > On Jan 11, 2019, at 12:06 PM, Stephen Hemminger wrote: >=20 > The tap device (used by vdev_netvsc on Azure) has a bug that > prevents it working with primary/secondary process model because > the device name generation assumed a single process. The fix for > this is to have the kernel assign the device name (patch #5). >=20 > While investigating this, found a number of other small issues > that should be cleaned up as well. >=20 > Stephen Hemminger (6): > net/tap: use strlcpy for interface name > net/tap: allow full length names > net/tap: check interface name in kvargs > net/tap: lower the priority of log messages > net/tap: let kernel choose tun device name > net/tap: get rid of global tuntap_name >=20 > drivers/net/tap/rte_eth_tap.c | 106 +++++++++++++++++++++------------- > 1 file changed, 65 insertions(+), 41 deletions(-) >=20 > --=20 > 2.20.1 >=20 All of these look good except for a few comments. The styling changes I thi= nk need to be address, but if everyone is find with it then I will be OK a= fter a few more drinks. Acked-by Keith Wiles Regards, Keith