From: Yongseok Koh <yskoh@mellanox.com> To: David Marchand <david.marchand@redhat.com> Cc: Olivier Matz <olivier.matz@6wind.com>, Shahaf Shuler <shahafs@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org> Subject: Re: [dpdk-dev] [PATCH v2 1/2] mbuf: add function returning default buffer address Date: Thu, 10 Jan 2019 18:22:08 +0000 Message-ID: <D966BCB1-7F6F-4643-AFDE-4C93B6830CAC@mellanox.com> (raw) In-Reply-To: <CAJFAV8ze4K90-snGs0Ddj7Ff6sejgd7KY-Zw=3wHST=gcqLOVw@mail.gmail.com> On Jan 9, 2019, at 5:46 AM, David Marchand <david.marchand@redhat.com<mailto:david.marchand@redhat.com>> wrote: On Wed, Jan 9, 2019 at 2:19 PM Yongseok Koh <yskoh@mellanox.com<mailto:yskoh@mellanox.com>> wrote: This patch introduces two new functions - rte_mbuf_buf_addr_default() and rte_mbuf_data_baddr_default(). rte_mbuf_buf_addr_default() reutrns the default buffer address of given mbuf which comes after mbuf structure and private data. The buffer address should always be the same for a given mbuf, there is no "default" value for it, there is only one value. So for me s/rte_mbuf_buf_addr_default/rte_mbuf_buf_addr/g. +1 rte_mbuf_data_baddr_default() returns the default address of mbuf data taking the headroom into account. Or just rte_mbuf_data_addr_default() ? +1 Signed-off-by: Yongseok Koh <yskoh@mellanox.com<mailto:yskoh@mellanox.com>> Those are new functions, they should go through the EXPERIMENTAL api marking process. If that's the rule, I'll follow anyway, although these are too obvious to be experimental. Thanks, Yongseok
next prev parent reply other threads:[~2019-01-10 18:22 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-01-09 8:54 [dpdk-dev] [PATCH] net/mlx5: fix instruction hotspot on replenishing Rx buffer Yongseok Koh 2019-01-09 9:38 ` David Marchand 2019-01-09 9:52 ` Olivier Matz 2019-01-09 9:56 ` Yongseok Koh 2019-01-09 10:05 ` David Marchand 2019-01-09 10:11 ` Yongseok Koh 2019-01-09 13:19 ` [dpdk-dev] [PATCH v2 1/2] mbuf: add function returning default buffer address Yongseok Koh 2019-01-09 13:19 ` [dpdk-dev] [PATCH v2 2/2] net/mlx5: fix instruction hotspot on replenishing Rx buffer Yongseok Koh 2019-01-09 13:46 ` [dpdk-dev] [PATCH v2 1/2] mbuf: add function returning default buffer address David Marchand 2019-01-10 1:39 ` Rami Rosen 2019-01-10 18:18 ` Yongseok Koh 2019-01-10 18:22 ` Yongseok Koh [this message] 2019-01-10 18:35 ` [dpdk-dev] [PATCH v3 " Yongseok Koh 2019-01-10 18:35 ` [dpdk-dev] [PATCH v3 2/2] net/mlx5: fix instruction hotspot on replenishing Rx buffer Yongseok Koh 2019-01-10 19:10 ` Shahaf Shuler 2019-01-11 8:14 ` [dpdk-dev] [PATCH v3 1/2] mbuf: add function returning default buffer address Andrew Rybchenko 2019-01-11 11:03 ` Yongseok Koh 2019-01-11 11:17 ` Andrew Rybchenko 2019-01-11 11:37 ` Yongseok Koh 2019-01-11 11:57 ` Bruce Richardson 2019-01-11 12:48 ` David Marchand 2019-01-14 15:51 ` Olivier Matz 2019-01-10 22:40 ` [dpdk-dev] [PATCH v4 " Yongseok Koh 2019-01-10 22:40 ` [dpdk-dev] [PATCH v4 2/2] net/mlx5: fix instruction hotspot on replenishing Rx buffer Yongseok Koh 2019-01-11 8:05 ` [dpdk-dev] [PATCH v4 1/2] mbuf: add function returning default buffer address Olivier Matz 2019-01-11 8:11 ` David Marchand 2019-01-11 8:32 ` David Marchand 2019-01-11 11:09 ` Yongseok Koh 2019-01-11 10:25 ` Thomas Monjalon 2019-01-14 21:16 ` [dpdk-dev] [PATCH v5 1/2] mbuf: add function returning " Yongseok Koh 2019-01-14 21:16 ` [dpdk-dev] [PATCH v5 2/2] net/mlx5: fix instruction hotspot on replenishing Rx buffer Yongseok Koh 2019-02-06 15:54 ` Kevin Traynor 2019-02-21 19:10 ` Kevin Traynor 2019-03-08 2:05 ` Yongseok Koh 2019-01-15 1:35 ` [dpdk-dev] [PATCH v5 1/2] mbuf: add function returning buffer address Thomas Monjalon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=D966BCB1-7F6F-4643-AFDE-4C93B6830CAC@mellanox.com \ --to=yskoh@mellanox.com \ --cc=david.marchand@redhat.com \ --cc=dev@dpdk.org \ --cc=olivier.matz@6wind.com \ --cc=shahafs@mellanox.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git