From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00059.outbound.protection.outlook.com [40.107.0.59]) by dpdk.org (Postfix) with ESMTP id 8FDF11B885 for ; Thu, 10 Jan 2019 19:22:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EgK8JIPx8NrT7ic4QGlzKapxHPej/CZ9MYMJXHE4yr8=; b=Wuz8QaG74W+9HDum4rZfusnPpLiFO6Mnkd77RappWPVGSI1ho2dnmhyWsJ2aIGVOSVZ+TShZsa62mKpRZCzR4Cp4HpP6vNrLgOK5MVUjG+31SZYS8GQyfrthmFwDzUPPzwrI3EyR2bPeceQzIcb4jY5gRuFh9rfP3brAVXcj1N8= Received: from AM0PR0502MB3971.eurprd05.prod.outlook.com (52.133.40.151) by AM0PR0502MB3700.eurprd05.prod.outlook.com (52.133.46.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1516.13; Thu, 10 Jan 2019 18:22:08 +0000 Received: from AM0PR0502MB3971.eurprd05.prod.outlook.com ([fe80::599b:f42:d401:38ff]) by AM0PR0502MB3971.eurprd05.prod.outlook.com ([fe80::599b:f42:d401:38ff%2]) with mapi id 15.20.1495.011; Thu, 10 Jan 2019 18:22:08 +0000 From: Yongseok Koh To: David Marchand CC: Olivier Matz , Shahaf Shuler , "dev@dpdk.org" Thread-Topic: [PATCH v2 1/2] mbuf: add function returning default buffer address Thread-Index: AQHUqB3zZX02l6WopEasB2RdQfD+HqWm81SAgAHfOYA= Date: Thu, 10 Jan 2019 18:22:08 +0000 Message-ID: References: <20190109085426.39965-1-yskoh@mellanox.com> <20190109131908.4949-1-yskoh@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [69.181.245.183] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM0PR0502MB3700; 6:KH+CO0FammGGCC5E3Ehp6hQH5i6jVGTKBeDBVhUmiZU6/9stX19Hscyzqy1y1sDzSd+OVMlUd35YBPQ/cCvapprSbza83X5ImwAgBwSr5zb7M1xV9dsb2Sz0VszthWizARdabx+VXv5R2YU4VdbfwEnRuXS1rpl/BsUqQibLs1Wjk9CGJQOqVBupCZywuAgi3mkg1tvdvlzLTQ/GqzsZZ8lShMS6zXRZqq5js4V4yWhecs/SiMqaz4MOuY70CF4vK08Kj5/9j/Bp9ph0v/H65vG4q0b7ou6llpXeFkMK8bUeTUfVWASLDwa0fyLWJ7rdXYltebX5q9j/aeeq32V4TpBaQUkXzA/mAhErpvHu8ZXKsLxcBVTCchMqhM0SfVFXQkG8fg98B1kafSLlJpCI6bBO7AtSeyHXXpFZSsIQY6N00DmmT9nvVBu1R7Sl04rZebOEyOE88S8hbcCrOgwfkg==; 5:JfoA5iGk2DStRN4ksZuIh9QzHT+r+IpivcsBIx6XkXKb2OwmBMNODgJ1ui21B6YzwS2GHjmQ1rclP9YLk0QMo2o8bWEECXJCY2b4pHC38hsC1Gp8ydV8M95tewnCq/lr1VPFoHRqxi5IteVrL9UCrC+ARyJuYXtAqo2ztMmPE2JtgfsySlzKCN2UolFOPHlYYOucavnP8Frbuz2KtyZZZQ==; 7:4ZmswuhB7dG2sMOvGDhBthC41oss6JphVWefePfIX33/gZhhAv7Wb5LN0pYEMYBuy57HaVRRrq66av1ReAfApvR1iYDYBFn3axuFvnlNTi5MZlrmyey9DBmqedwz1MBfBBIjdn4sfv3Zd8uKTHQqvg== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 7a8fddcf-06c3-4a67-44e1-08d677288810 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600109)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM0PR0502MB3700; x-ms-traffictypediagnostic: AM0PR0502MB3700: x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(3230021)(908002)(999002)(5005026)(6040522)(8220060)(2401047)(8121501046)(93006095)(93001095)(3231475)(944501520)(52105112)(3002001)(10201501046)(6055026)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123560045)(20161123562045)(20161123564045)(201708071742011)(7699051)(76991095); SRVR:AM0PR0502MB3700; BCL:0; PCL:0; RULEID:; SRVR:AM0PR0502MB3700; x-forefront-prvs: 0913EA1D60 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(376002)(346002)(396003)(39860400002)(366004)(199004)(52314003)(189003)(446003)(5660300001)(486006)(2616005)(36756003)(478600001)(11346002)(97736004)(6916009)(81166006)(81156014)(8676002)(86362001)(6512007)(54896002)(8936002)(236005)(476003)(82746002)(83716004)(4744005)(68736007)(99286004)(71200400001)(71190400001)(53936002)(66066001)(14454004)(54906003)(316002)(76176011)(256004)(14444005)(6506007)(53546011)(6246003)(229853002)(186003)(6486002)(25786009)(4326008)(6436002)(7736002)(2906002)(3846002)(6116002)(33656002)(102836004)(105586002)(106356001)(26005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB3700; H:AM0PR0502MB3971.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: G8Jlq/zM+rFhCXduGBfiieCxcBiT9C0aCNzWSKrAyG1wzK/JHdwLPSGLJTjkRCmseGes5+kiSDkEUhfvlUpf2nKKs0ZWIqQcfkfE6wm3hM86Hsc3xUlloru7O3/54QPRqPOHL+vEkBwIB0aDEBpGeHi8kJxc/3mi2FdlKfy2bEZM08JCkWLkMK4sO4MBubm5PHOjKiuXWkDMlbySsRuVQUPLatga8UocDpUowEyr/5E9PcvTPh6td94lZ2rsAFu9eqcCejhGEcTGE+pH3f0CAYqyRP9HDMFGgFbOdNk9biIIPzJhrxZDfHYLvYsLc2OT spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7a8fddcf-06c3-4a67-44e1-08d677288810 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jan 2019 18:22:08.3886 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3700 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 1/2] mbuf: add function returning default buffer address X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jan 2019 18:22:09 -0000 On Jan 9, 2019, at 5:46 AM, David Marchand > wrote: On Wed, Jan 9, 2019 at 2:19 PM Yongseok Koh > wrote: This patch introduces two new functions - rte_mbuf_buf_addr_default() and rte_mbuf_data_baddr_default(). rte_mbuf_buf_addr_default() reutrns the default buffer address of given mbuf which comes after mbuf structure and private data. The buffer address should always be the same for a given mbuf, there is no = "default" value for it, there is only one value. So for me s/rte_mbuf_buf_addr_default/rte_mbuf_buf_addr/g. +1 rte_mbuf_data_baddr_default() returns the default address of mbuf data taking the headroom into account. Or just rte_mbuf_data_addr_default() ? +1 Signed-off-by: Yongseok Koh > Those are new functions, they should go through the EXPERIMENTAL api markin= g process. If that's the rule, I'll follow anyway, although these are too obvious to b= e experimental. Thanks, Yongseok