DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] virtio-net-pmd: .gitignore: ignore librte_pmd_virtio.so
@ 2014-10-14  7:53 Matthew Hall
  2014-10-14  9:44 ` Bruce Richardson
  0 siblings, 1 reply; 7+ messages in thread
From: Matthew Hall @ 2014-10-14  7:53 UTC (permalink / raw)
  To: dev

Signed-off-by: Matthew Hall <mhall@mhcomputing.net>
---
 .gitignore | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.gitignore b/.gitignore
index e69de29..08d831a 100644
--- a/.gitignore
+++ b/.gitignore
@@ -0,0 +1 @@
+librte_pmd_virtio.so
-- 
1.9.1

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dpdk-dev] [PATCH] virtio-net-pmd: .gitignore: ignore librte_pmd_virtio.so
  2014-10-14  7:53 [dpdk-dev] [PATCH] virtio-net-pmd: .gitignore: ignore librte_pmd_virtio.so Matthew Hall
@ 2014-10-14  9:44 ` Bruce Richardson
  2014-10-14  9:52   ` Stephen Hemminger
  2014-10-14 15:38   ` Matthew Hall
  0 siblings, 2 replies; 7+ messages in thread
From: Bruce Richardson @ 2014-10-14  9:44 UTC (permalink / raw)
  To: Matthew Hall; +Cc: dev

On Tue, Oct 14, 2014 at 07:53:56AM +0000, Matthew Hall wrote:
> Signed-off-by: Matthew Hall <mhall@mhcomputing.net>
> ---
>  .gitignore | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/.gitignore b/.gitignore
> index e69de29..08d831a 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -0,0 +1 @@
> +librte_pmd_virtio.so
> -- 
> 1.9.1
> 

I thought our .gitignore could do with a few entries added alright, I just 
never expected this one to be top of the list! While I don't think it does 
any harm, I'm just curious why you think it needs to be added?

/Bruce

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dpdk-dev] [PATCH] virtio-net-pmd: .gitignore: ignore librte_pmd_virtio.so
  2014-10-14  9:44 ` Bruce Richardson
@ 2014-10-14  9:52   ` Stephen Hemminger
  2014-10-14 15:40     ` Matthew Hall
  2014-10-14 15:38   ` Matthew Hall
  1 sibling, 1 reply; 7+ messages in thread
From: Stephen Hemminger @ 2014-10-14  9:52 UTC (permalink / raw)
  To: Bruce Richardson; +Cc: dev

On Tue, 14 Oct 2014 10:44:16 +0100
Bruce Richardson <bruce.richardson@intel.com> wrote:

> On Tue, Oct 14, 2014 at 07:53:56AM +0000, Matthew Hall wrote:
> > Signed-off-by: Matthew Hall <mhall@mhcomputing.net>
> > ---
> >  .gitignore | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/.gitignore b/.gitignore
> > index e69de29..08d831a 100644
> > --- a/.gitignore
> > +++ b/.gitignore
> > @@ -0,0 +1 @@
> > +librte_pmd_virtio.so
> > -- 
> > 1.9.1
> > 
> 
> I thought our .gitignore could do with a few entries added alright, I just 
> never expected this one to be top of the list! While I don't think it does 
> any harm, I'm just curious why you think it needs to be added?
> 
> /Bruce

Why not add *.so to ignore all built shared libraries

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dpdk-dev] [PATCH] virtio-net-pmd: .gitignore: ignore librte_pmd_virtio.so
  2014-10-14  9:44 ` Bruce Richardson
  2014-10-14  9:52   ` Stephen Hemminger
@ 2014-10-14 15:38   ` Matthew Hall
  2014-10-14 16:09     ` Thomas Monjalon
  1 sibling, 1 reply; 7+ messages in thread
From: Matthew Hall @ 2014-10-14 15:38 UTC (permalink / raw)
  To: Bruce Richardson; +Cc: dev

I import all my DPDK dependencies as git submodules. When the submodules contain unignored files, they get marked as dirty by git, and it makes like difficult when it comes to updating my submodule pointers.

Matthew.
-- 
Sent from my mobile device.

On October 14, 2014 2:44:16 AM PDT, Bruce Richardson <bruce.richardson@intel.com> wrote:
>On Tue, Oct 14, 2014 at 07:53:56AM +0000, Matthew Hall wrote:
>> Signed-off-by: Matthew Hall <mhall@mhcomputing.net>
>> ---
>>  .gitignore | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/.gitignore b/.gitignore
>> index e69de29..08d831a 100644
>> --- a/.gitignore
>> +++ b/.gitignore
>> @@ -0,0 +1 @@
>> +librte_pmd_virtio.so
>> -- 
>> 1.9.1
>> 
>
>I thought our .gitignore could do with a few entries added alright, I
>just 
>never expected this one to be top of the list! While I don't think it
>does 
>any harm, I'm just curious why you think it needs to be added?
>
>/Bruce

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dpdk-dev] [PATCH] virtio-net-pmd: .gitignore: ignore librte_pmd_virtio.so
  2014-10-14  9:52   ` Stephen Hemminger
@ 2014-10-14 15:40     ` Matthew Hall
  0 siblings, 0 replies; 7+ messages in thread
From: Matthew Hall @ 2014-10-14 15:40 UTC (permalink / raw)
  To: Stephen Hemminger, Bruce Richardson; +Cc: dev

Sure, I can put the classic C gitignore entries in there if you guys prefer. I was just trying to make the minimum change to get it to work right for my environment.
-- 
Sent from my mobile device.

On October 14, 2014 2:52:20 AM PDT, Stephen Hemminger <stephen@networkplumber.org> wrote:
>On Tue, 14 Oct 2014 10:44:16 +0100
>Bruce Richardson <bruce.richardson@intel.com> wrote:
>
>> On Tue, Oct 14, 2014 at 07:53:56AM +0000, Matthew Hall wrote:
>> > Signed-off-by: Matthew Hall <mhall@mhcomputing.net>
>> > ---
>> >  .gitignore | 1 +
>> >  1 file changed, 1 insertion(+)
>> > 
>> > diff --git a/.gitignore b/.gitignore
>> > index e69de29..08d831a 100644
>> > --- a/.gitignore
>> > +++ b/.gitignore
>> > @@ -0,0 +1 @@
>> > +librte_pmd_virtio.so
>> > -- 
>> > 1.9.1
>> > 
>> 
>> I thought our .gitignore could do with a few entries added alright, I
>just 
>> never expected this one to be top of the list! While I don't think it
>does 
>> any harm, I'm just curious why you think it needs to be added?
>> 
>> /Bruce
>
>Why not add *.so to ignore all built shared libraries

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dpdk-dev] [PATCH] virtio-net-pmd: .gitignore: ignore librte_pmd_virtio.so
  2014-10-14 15:38   ` Matthew Hall
@ 2014-10-14 16:09     ` Thomas Monjalon
  2014-10-14 16:12       ` Matthew Hall
  0 siblings, 1 reply; 7+ messages in thread
From: Thomas Monjalon @ 2014-10-14 16:09 UTC (permalink / raw)
  To: Matthew Hall; +Cc: dev

> >I thought our .gitignore could do with a few entries added alright, I
> >just never expected this one to be top of the list! While I don't think
> >it does any harm, I'm just curious why you think it needs to be added?
> >
> >/Bruce
> 
> I import all my DPDK dependencies as git submodules. When the submodules
> contain unignored files, they get marked as dirty by git, and it makes
> like difficult when it comes to updating my submodule pointers.
> 
> Matthew.

So you cannot update submodules without filling .gitignore?

I'm not a big fan of .gitignore because I like seeing what has been
generated by looking at "git status".
And it's not really needed in DPDK because compilation is often done in
a separate directory.

-- 
Thomas

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dpdk-dev] [PATCH] virtio-net-pmd: .gitignore: ignore librte_pmd_virtio.so
  2014-10-14 16:09     ` Thomas Monjalon
@ 2014-10-14 16:12       ` Matthew Hall
  0 siblings, 0 replies; 7+ messages in thread
From: Matthew Hall @ 2014-10-14 16:12 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: dev

In the virtio-net-pmd it is done in the same directory. Hence me submitting this to try to make it easier for others to use the product.

Also the default DPDK doesn't ignore the build target directories... but I already had to fork that one to fix clang compile failures in the examples files.

Matthew.
-- 
Sent from my mobile device.

On October 14, 2014 9:09:49 AM PDT, Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
>> >I thought our .gitignore could do with a few entries added alright,
>I
>> >just never expected this one to be top of the list! While I don't
>think
>> >it does any harm, I'm just curious why you think it needs to be
>added?
>> >
>> >/Bruce
>> 
>> I import all my DPDK dependencies as git submodules. When the
>submodules
>> contain unignored files, they get marked as dirty by git, and it
>makes
>> like difficult when it comes to updating my submodule pointers.
>> 
>> Matthew.
>
>So you cannot update submodules without filling .gitignore?
>
>I'm not a big fan of .gitignore because I like seeing what has been
>generated by looking at "git status".
>And it's not really needed in DPDK because compilation is often done in
>a separate directory.

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2014-10-14 16:05 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-14  7:53 [dpdk-dev] [PATCH] virtio-net-pmd: .gitignore: ignore librte_pmd_virtio.so Matthew Hall
2014-10-14  9:44 ` Bruce Richardson
2014-10-14  9:52   ` Stephen Hemminger
2014-10-14 15:40     ` Matthew Hall
2014-10-14 15:38   ` Matthew Hall
2014-10-14 16:09     ` Thomas Monjalon
2014-10-14 16:12       ` Matthew Hall

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git